[OGo-Developer] Bug in EOQualifierParser.m

[Helge Hess]

Hi,

thanks a lot, patch is applied!

Greets,
   Helge

On Jan 13, 2007, at 20:01, St=E9phane Corth=E9sy wrote:
> Hi,
>
> I found a bug in latest sope-core/EOControl/EOQualifierParser.m, =20
> line 960:
>
> 	if (!(_buf[pos + toklen] =3D=3D '\0' || isspace(_buf[pos + =
toklen])))
> 	  /* not at the string end or folloed by a space */
> 	  continue;
>
> The following qualifier string, which is valid, is not parsed =20
> correctly: the 'nil' token is wrongly interpreted as a string:
>
> (not (attribute =3D nil) and attribute.className =3D =20
> 'com.webobjects.foundation.NSTimestamp')
>
>
> The fix is easy, I guess: simply check for the right parenthesis too:
>
> 	if (!(_buf[pos + toklen] =3D=3D '\0' || isspace(_buf[pos + =
toklen]) || =20
> _buf[pos + toklen] =3D=3D ')'))
> 	  /* not at the string end or followed by a space or a right =20
> parenthesis */
> 	  continue;
>
> St=E9phane
>
> --
> OpenGroupware.org Developer
> developer@opengroupware.org
> http://mail.opengroupware.org/mailman/listinfo/developer

--=20
Helge Hess
http://www.helgehess.eu/