[OGo-Developer] Patches In Bugzilla

Adam Tauno Williams developer@opengroupware.org
Thu, 18 Jan 2007 09:18:16 -0500


> > Is there anything we can do to
> > scoot the process along of getting patches out of Bugzilla and into
> > trunk?  Or even of getting patches rejected.
> OK. I usually do a full review of Bugzilla about once every 6 months,  
> which obviously is not a lot and its no fun work at all ;-) Plus I'm  
> still quite busy with a specific project, so this is scheduled to  
> free slots ...

Understood.

> My suggestion: lets give Adam full commit permissions. 

Yikes.

> Adam, you  
> would need to check the patches one-by-one, test them and possibly  
> affected areas. And then approve/commit the patches (adding proper  
> revision numbers of patches in Svn). I would then do another quick  
> review prior doing a release.
> Adam, would you volunteer for that?

Yes;  although ultimately I might not be any faster than you. :)

As for "Adding proper revision numbers of patches in Svn".  Is there a
guide for this?  As in some kind of [at least rough] procedure as to the
canonical steps?

> PS: please remember that properly reviewing an Objective-C code  
> related patch from a beginner is often as much work as implementing a  
> given feature from scratch :-/ Thats not meant as a discouragement to  
> post patches, but please remember that applying them is a LOT of work.

Yep.