From developer@opengroupware.org Fri Jun 8 15:44:12 2007 From: developer@opengroupware.org (Wolfgang Sourdeau) Date: Fri, 08 Jun 2007 10:44:12 -0400 Subject: [OGo-Developer] WODirectAction not initted? (fwd) Message-ID: <259e6838652076e10dbeaa6a946ab6c0@Maestro.local> Actually I have found the problem In WODirectAction, init calls [self initWithRequest: nil], which in turn calls [super init]. This explains why my method was never called. I think this is bad practice because any Objective-C object is expected to possibly have an init method to instantiate its attributes... In which case, the call chain should be the other way around.... initWithRequest should call [self init] which then should call [super init]. And since init does nothing, it can actually be removed. Should I submit a patch for this? Wolfgang ---------- Forwarded message ---------- Date: 2007-06-08 10:35:27 -0400 From: Wolfgang Sourdeau Subject: WODirectAction not initted? Hi, I think I found a bug in the way WODirectAction is instantiated... I have setup a subclass of it, which is instantiated from its module's product.plist. However it seems that the init method is never called... How can that be possible? Shouldn't this be considered a bug? W. From developer@opengroupware.org Fri Jun 8 16:00:48 2007 From: developer@opengroupware.org (Helge Hess) Date: Fri, 8 Jun 2007 17:00:48 +0200 Subject: [OGo-Developer] WODirectAction not initted? (fwd) In-Reply-To: <259e6838652076e10dbeaa6a946ab6c0@Maestro.local> References: <259e6838652076e10dbeaa6a946ab6c0@Maestro.local> Message-ID: On Jun 8, 2007, at 16:44, Wolfgang Sourdeau wrote: > Actually I have found the problem > > In WODirectAction, init calls [self initWithRequest: nil], which in > turn calls [super init]. This explains why my method was never called. > > I think this is bad practice because any Objective-C object is > expected to possibly have an init method to instantiate its > attributes... In which case, the call chain should be the other way > around.... initWithRequest should call [self init] which then > should call [super init]. Uhm, no. Objective-C convention is to have a so called 'designated initializers' (DI). In SOPE I sometimes tag them explicitly with a comment // designated initializer after or before the method name. For WODirectAction the designated initializer is -initWithRequest:, for NSObject -init, and the -init chain looks proper to me. One could support multiple DIs, but this means more work for subclassers since they usually need to override all of them. > And since init does nothing, it can actually be removed. > > Should I submit a patch for this? I can't really follow the issue. If you want to override an initializer in the subclass you need to override the designated initializer(s). For WODirectAction subclasses this is -initWithRequest:. The current code looks fine to me (maybe we should explicitly tag the DI). But maybe I'm missing something. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Wed Jun 13 21:23:31 2007 From: developer@opengroupware.org (Wolfgang Sourdeau) Date: Wed, 13 Jun 2007 16:23:31 -0400 Subject: [OGo-Developer] SVN hazards Message-ID: <140c0c74acd17ba3eb2d4bd39051834e@Maestro.local> Hi all, There has been a lot of problems with the SVN repository of SOGo lately. Is this under control? Are you, Helge and crew, aware of that? Wolfgang From developer@opengroupware.org Thu Jun 14 13:16:05 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 14 Jun 2007 08:16:05 -0400 Subject: [OGo-Developer] docs.opengroupware.org Message-ID: <1181823365.4445.3.camel@aleph.whitemice.org> --=-U4aMwXMKp0+ghVgL/JTG Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Is docs.opengroupware.org down? --=-U4aMwXMKp0+ghVgL/JTG Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGcTGFLRePpNle04MRAnsqAJ4259BfL7smAx7BkCQqdAn9BwbKUQCfZvx4 LeGsNP7bL/tMpStAvbKaFMY= =VWZl -----END PGP SIGNATURE----- --=-U4aMwXMKp0+ghVgL/JTG-- From developer@opengroupware.org Thu Jun 14 15:50:44 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 14 Jun 2007 16:50:44 +0200 Subject: [OGo-Developer] SVN hazards In-Reply-To: <140c0c74acd17ba3eb2d4bd39051834e@Maestro.local> References: <140c0c74acd17ba3eb2d4bd39051834e@Maestro.local> Message-ID: <300F64EE-D0FF-4C84-AB37-400659E325A2@opengroupware.org> On Jun 13, 2007, at 22:23, Wolfgang Sourdeau wrote: > There has been a lot of problems with the SVN repository of SOGo > lately. > Is this under control? Are you, Helge and crew, aware of that? Yes, someone hacked an SSH account on the dev machine. Should be fixed now. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Thu Jun 14 16:25:24 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 14 Jun 2007 17:25:24 +0200 Subject: [OGo-Developer] docs.opengroupware.org In-Reply-To: <1181823365.4445.3.camel@aleph.whitemice.org> References: <1181823365.4445.3.camel@aleph.whitemice.org> Message-ID: <45C09278-60BC-4047-99D6-602414DA20E1@opengroupware.org> On Jun 14, 2007, at 14:16, Adam Tauno Williams wrote: > Is docs.opengroupware.org down? Could be, yes. I think Frank has taken most things down after the attack. BTW: all of you with an account: might make sense to change your passwords to secure ones on your developer account ... (/etc/shadow wasn't compromised, but the breakin was most likely due to an insecure password on one of the accounts ...) Thanks, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Thu Jun 14 16:50:39 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 14 Jun 2007 11:50:39 -0400 Subject: [OGo-Developer] docs.opengroupware.org In-Reply-To: <45C09278-60BC-4047-99D6-602414DA20E1@opengroupware.org> References: <1181823365.4445.3.camel@aleph.whitemice.org> <45C09278-60BC-4047-99D6-602414DA20E1@opengroupware.org> Message-ID: <1181836239.4445.39.camel@aleph.whitemice.org> --=-ZTCZyMeWfI2C1CiA2QCl Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2007-06-14 at 17:25 +0200, Helge Hess wrote: > On Jun 14, 2007, at 14:16, Adam Tauno Williams wrote: > > Is docs.opengroupware.org down? > Could be, yes. I think Frank has taken most things down after the =20 > attack. > BTW: all of you with an account: might make sense to change your =20 > passwords to secure ones on your developer account ... > (/etc/shadow wasn't compromised, but the breakin was most likely due =20 > to an insecure password on one of the accounts ...) Hmmm... can't log into developer.opengroupware.org awilliam@aleph:~> ssh adam@developer.opengroupware.org Password:=20 Password:=20 Password:=20 adam@developer.opengroupware.org's password:=20 Permission denied, please try again. adam@developer.opengroupware.org's password:=20 I had changed my password from the default/initially-assigned. --=-ZTCZyMeWfI2C1CiA2QCl Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGcWPPLRePpNle04MRAmOjAJ0WjCWD+SsVAgM1qKw/czkTaTAUXQCeO83D tTv+SznGBFFCPtJic7p86hU= =CVH4 -----END PGP SIGNATURE----- --=-ZTCZyMeWfI2C1CiA2QCl-- From developer@opengroupware.org Sun Jun 17 20:31:20 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Sun, 17 Jun 2007 21:31:20 +0200 Subject: [OGo-Developer] SkyProjectFileManagerCache.m does not compile anymore Message-ID: <20070617193121.688163E438@l00-bugdead-prods.de> ------=_=-_OpenGroupware_org_NGMime-9352-1182108680.989584-0------ content-type: text/plain; charset="us-ascii" content-transfer-encoding: 7bit content-length: 145 Hi, the SkyProjectFileManagerCache.m from the latest nightly ogo trunk package does not compile anymore. Appended patch fixes it. Sebastian ------=_=-_OpenGroupware_org_NGMime-9352-1182108680.989584-0------ content-disposition: inline; filename="patch-DocumentAPI_OGoDatabaseProject_SkyProjectFileManagerCache.m" content-length: 1118 content-transfer-encoding: 7bit content-type: application/octet-stream; name="patch-DocumentAPI_OGoDatabaseProject_SkyProjectFileManagerCache.m" --- DocumentAPI/OGoDatabaseProject/SkyProjectFileManagerCache.m Mon Jun 11 11:06:38 2007 +++ DocumentAPI/OGoDatabaseProject/SkyProjectFileManagerCache.m.new Sun Jun 17 21:05:57 2007 @@ -736,10 +736,10 @@ @"isPerson", yesNum, nil]; error = [channel selectAttributesX:personAttrs - describedByQualifier:qualifier fetchOrder:nil lock:NO] + describedByQualifier:qualifier fetchOrder:nil lock:NO]; if (error != nil) { [self errorWithFormat:@"[%s]: select failed for qualifier %@ attrs %@: %@", - __PRETTY_FUNCTION__, qualifier, personAttrs, error); + __PRETTY_FUNCTION__, qualifier, personAttrs, error]; [qualifier release]; qualifier = nil; [self rollbackTransaction]; return nil; @@ -756,7 +756,7 @@ if (![cid isNotNull]) { [self errorWithFormat:@"[%s]: missing companyId for account ...", - __PRETTY_FUNCTION__); + __PRETTY_FUNCTION__]; continue; } if (![(l = [row valueForKey:@"login"]) isNotNull]) ------=_=-_OpenGroupware_org_NGMime-9352-1182108680.989584-0-------- From developer@opengroupware.org Mon Jun 18 13:48:48 2007 From: developer@opengroupware.org (Olivier Hallot) Date: Mon, 18 Jun 2007 09:48:48 -0300 Subject: [OGo-Developer] SVN hazards In-Reply-To: <300F64EE-D0FF-4C84-AB37-400659E325A2@opengroupware.org> References: <140c0c74acd17ba3eb2d4bd39051834e@Maestro.local> <300F64EE-D0FF-4C84-AB37-400659E325A2@opengroupware.org> Message-ID: <46767F30.4090900@scinergy.com.br> This is a multi-part message in MIME format. --------------060206000607010306060803 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi I still have troubles with svn server. If I use my developer account at [olivier@olivier OGo-1.0a]$ svn info Path: . URL: http://developer.opengroupware.org/OpenGroupware.org/trunk Repository Root: http://developer.opengroupware.org/OpenGroupware.org Repository UUID: fda58e92-02e2-0310-b1e4-b2b32738dd10 Revision: 1985 I don't have problems updating my local development copy but if I use the anonymous svn server at [root@olivier OGo-1.0trunk]# svn info Path: . URL: http://svn.opengroupware.org/OpenGroupware.org/trunk Repository Root: http://svn.opengroupware.org/OpenGroupware.org Repository UUID: fda58e92-02e2-0310-b1e4-b2b32738dd10 Revision: 1957 I get a timeout. It seems that http://svn.opengroupware.org/OpenGroupware.org/trunk is out... Thanks in advance for fixing it. Olivier Helge Hess escreveu: > On Jun 13, 2007, at 22:23, Wolfgang Sourdeau wrote: >> There has been a lot of problems with the SVN repository of SOGo lately. >> Is this under control? Are you, Helge and crew, aware of that? > > Yes, someone hacked an SSH account on the dev machine. Should be fixed now. > > Greets, > Helge -- Olivier Hallot Scinergy Consulting Tel (021) 8822-8812 Rio de Janeiro, Brasil http://www.scinergy.com.br --------------060206000607010306060803 Content-Type: text/x-vcard; charset=utf-8; name="ohallot.vcf" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ohallot.vcf" begin:vcard fn:Olivier Hallot n:Hallot;Olivier org:Scienrgy Consulting Ltda adr:SL. 1102;;Av. Rio BRanco 124;Rio de Janeiro;RJ;20040-001;Brasil email;internet:ohallot@scinergy.com.br title:Diretor tel;work:+55-21-2224-3224 tel;fax:+55-21-2224-3224 url:http://www.scinergy.com.br version:2.1 end:vcard --------------060206000607010306060803-- From developer@opengroupware.org Mon Jun 18 15:19:04 2007 From: developer@opengroupware.org (Helge Hess) Date: Mon, 18 Jun 2007 16:19:04 +0200 Subject: [OGo-Developer] SVN hazards In-Reply-To: <46767F30.4090900@scinergy.com.br> References: <140c0c74acd17ba3eb2d4bd39051834e@Maestro.local> <300F64EE-D0FF-4C84-AB37-400659E325A2@opengroupware.org> <46767F30.4090900@scinergy.com.br> Message-ID: <45E375AD-C3A7-4193-8D18-5395301E6149@opengroupware.org> On Jun 18, 2007, at 14:48, Olivier Hallot wrote: > I still have troubles with svn server. Frank tells me that this has been fixed. Thanks, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Wed Jun 27 21:48:51 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 27 Jun 2007 16:48:51 -0400 Subject: [OGo-Developer] Case insensitive qsearch Message-ID: <1182977331.9156.9.camel@aleph.whitemice.org> --=-ELkdOLyR7NjM7sxexkgd Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Is there a way to use the ::qsearch command in a case insensitive manner? Just as an example, using the ogo-qsearch-persons tool: No result - ogo-qsearch-persons -login awilliam -password fred 'firstname =3D "adam" AND address.city LIKE "Grand%"' Finds result - ogo-qsearch-persons -login awilliam -password fred 'firstname =3D "Adam" AND address.city LIKE "Grand%"' --=-ELkdOLyR7NjM7sxexkgd Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGgs0zLRePpNle04MRAp5/AJ9wpfyEtGQo8AssU0DXbGTrNknzTwCggC/R JrHrohBkx7NI80QEvOs/CqU= =RU3t -----END PGP SIGNATURE----- --=-ELkdOLyR7NjM7sxexkgd-- From developer@opengroupware.org Wed Jun 27 23:19:23 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 28 Jun 2007 00:19:23 +0200 Subject: [OGo-Developer] Case insensitive qsearch In-Reply-To: <1182977331.9156.9.camel@aleph.whitemice.org> References: <1182977331.9156.9.camel@aleph.whitemice.org> Message-ID: <83863E02-1061-4FCF-A357-AB60C2B8110F@opengroupware.org> On 27.06.2007, at 22:48, Adam Tauno Williams wrote: > Is there a way to use the ::qsearch command in a case insensitive > manner? Maybe using 'caseInsensitiveLike:' instead of 'LIKE' as the operator? Greets, Helge From developer@opengroupware.org Thu Jun 28 13:54:24 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 28 Jun 2007 08:54:24 -0400 Subject: [OGo-Developer] Method not in header file Message-ID: <1183035264.4473.3.camel@aleph.whitemice.org> --=-t+83F6SI5uji/nnIoewq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable LSFoundation/OGoObjectLink.m contains the method: - (BOOL)isEqualToObjectLink:(OGoObjectLink *)_other But this method does not appear in LSFoundation/OGoObjectLink.h I use this method in zOGI, which works, but when I compile I get the warning: zOGIAction+Object.m: In function =E2=80=98-[zOGIAction(Object) _saveObjectLinks:forObject:]=E2=80=99: zOGIAction+Object.m:238: warning: no =E2=80=98-isEqualToObjectLink:=E2=80= =99 method found zOGIAction+Object.m:238: warning: (Messages without a matching method signature zOGIAction+Object.m:238: warning: will be assumed to return =E2=80=98id=E2= =80=99 and accept zOGIAction+Object.m:238: warning: =E2=80=98...=E2=80=99 as arguments.) Is there a reason this method is not in the header file? Adding it makes the warning go away. --=-t+83F6SI5uji/nnIoewq Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGg6+ALRePpNle04MRAlljAJ0XCY3bGIgcfArSNqgxba+BoBCeeACfQ0x6 JKw/yDDkptSAQFiaoUgfu00= =jFAd -----END PGP SIGNATURE----- --=-t+83F6SI5uji/nnIoewq-- From developer@opengroupware.org Thu Jun 28 13:58:45 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 28 Jun 2007 14:58:45 +0200 Subject: [OGo-Developer] Method not in header file In-Reply-To: <1183035264.4473.3.camel@aleph.whitemice.org> References: <1183035264.4473.3.camel@aleph.whitemice.org> Message-ID: <7B98EABC-8C03-417C-B131-0E551AFE4A94@opengroupware.org> On 28.06.2007, at 14:54, Adam Tauno Williams wrote: > Is there a reason this method is not in the header file? Adding it > makes the warning go away. Yes, the public method is NSObject's -isEqual:. You should not depend on internal methods. Greets, Helge From developer@opengroupware.org Thu Jun 28 14:03:54 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 28 Jun 2007 09:03:54 -0400 Subject: [OGo-Developer] Method not in header file In-Reply-To: <7B98EABC-8C03-417C-B131-0E551AFE4A94@opengroupware.org> References: <1183035264.4473.3.camel@aleph.whitemice.org> <7B98EABC-8C03-417C-B131-0E551AFE4A94@opengroupware.org> Message-ID: <1183035834.4473.5.camel@aleph.whitemice.org> --=-XvikqwHZ3oeY5lMgRhL2 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > > Is there a reason this method is not in the header file? Adding it =20 > > makes the warning go away. > Yes, the public method is NSObject's -isEqual:. You should not depend =20 > on internal methods. Ah, see that now. Fixed. --=-XvikqwHZ3oeY5lMgRhL2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGg7G6LRePpNle04MRAuIBAJ430BKvMUdzerFPK/SURejfjhCCCACfVqHn puaySkCGHyAjR22JrYlE6vE= =1M// -----END PGP SIGNATURE----- --=-XvikqwHZ3oeY5lMgRhL2-- From developer@opengroupware.org Fri Jun 29 14:45:47 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Fri, 29 Jun 2007 09:45:47 -0400 Subject: [OGo-Developer] Adding a user agent Message-ID: <1183124747.4471.23.camel@aleph.whitemice.org> --=-n8VrkfpjpVf1EbvgvZCF Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Since we use PEAR XML-RPC to access my zOGI bundle the ZideStore log contains thousands of - Jun 29 12:41:35 ogo-zidestore-1.5 [6486]: -[WEClientCapabilities initWithRequest:]: Unknown WebClient: user-agent=3D'PEAR XML_RPC' So I went searching on how to define a user-agent, and think I found it - add it to sope/sope-appserver/NGObjWeb/WEClientCapabilities.m Is this the correct/complete way to do this?=20 http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1882 --=-n8VrkfpjpVf1EbvgvZCF Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGhQ0LLRePpNle04MRAmefAJ93YRUjHZYsCDv8zmg1xdlkoeMRyACeL68M MbK+uqVq00eAALGMIR+2lEM= =mChS -----END PGP SIGNATURE----- --=-n8VrkfpjpVf1EbvgvZCF-- From developer@opengroupware.org Fri Jun 29 14:53:01 2007 From: developer@opengroupware.org (Helge Hess) Date: Fri, 29 Jun 2007 15:53:01 +0200 Subject: [OGo-Developer] Adding a user agent In-Reply-To: <1183124747.4471.23.camel@aleph.whitemice.org> References: <1183124747.4471.23.camel@aleph.whitemice.org> Message-ID: <9FB446BD-F5A8-4BE8-AE6A-C576CE75D6EF@opengroupware.org> On 29.06.2007, at 15:45, Adam Tauno Williams wrote: > So I went searching on how to define a user-agent, and think I > found it > - add it to sope/sope-appserver/NGObjWeb/WEClientCapabilities.m > > Is this the correct/complete way to do this? Yes. You might want to check the various methods of the cap object. (eg -isXmlRpcUserAgent). Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Fri Jun 29 15:55:27 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Fri, 29 Jun 2007 10:55:27 -0400 Subject: [OGo-Developer] Adding a user agent In-Reply-To: <9FB446BD-F5A8-4BE8-AE6A-C576CE75D6EF@opengroupware.org> References: <1183124747.4471.23.camel@aleph.whitemice.org> <9FB446BD-F5A8-4BE8-AE6A-C576CE75D6EF@opengroupware.org> Message-ID: <1183128927.4471.43.camel@aleph.whitemice.org> --=-PLxbf7qoKVabnPsBLIuB Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2007-06-29 at 15:53 +0200, Helge Hess wrote: > On 29.06.2007, at 15:45, Adam Tauno Williams wrote: > > So I went searching on how to define a user-agent, and think I =20 > > found it > > - add it to sope/sope-appserver/NGObjWeb/WEClientCapabilities.m > > Is this the correct/complete way to do this? > Yes. You might want to check the various methods of the cap object. =20 > (eg -isXmlRpcUserAgent). Yep, I added a - if (self->browser =3D=3D WEUA_PEAR_XMLRPC) return YES; - to (BOOL)isXmlRpcClient; that is in the patch. I didn't find a isXmlRpcUserAgent anywhere --=-PLxbf7qoKVabnPsBLIuB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBGhR1fLRePpNle04MRApz6AJ9aZMlP/E7DpIOxESFZJDWvYLlZvwCfWLKF IOBSxX9pRH+CTaSSy5rvgQI= =m9WM -----END PGP SIGNATURE----- --=-PLxbf7qoKVabnPsBLIuB--