[OGo-Developer] WODirectAction not initted? (fwd)

Wolfgang Sourdeau developer@opengroupware.org
Fri, 08 Jun 2007 10:44:12 -0400


Actually I have found the problem

In WODirectAction, init calls [self initWithRequest: nil], which in 
turn calls [super init]. This explains why my method was never called.

I think this is bad practice because any Objective-C object is 
expected to possibly have an init method to instantiate its 
attributes... In which case, the call chain should be the other way 
around.... initWithRequest should call [self init] which then should 
call [super init]. And since init does nothing, it can actually be 
removed.

Should I submit a patch for this?


Wolfgang


---------- Forwarded message ----------
Date: 2007-06-08 10:35:27 -0400
 From: Wolfgang Sourdeau <wsourdeau@inverse.ca>
Subject: WODirectAction not initted?

Hi,


I think I found a bug in the way WODirectAction is instantiated... I
have setup a subclass of it, which is instantiated from its module's
product.plist. However it seems that the init method is never
called...

How can that be possible? Shouldn't this be considered a bug?


W.