From developer@opengroupware.org Fri Mar 2 02:38:40 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 01 Mar 2007 21:38:40 -0500 Subject: [OGo-Developer] error: expected specifier-qualifier-list before =?UTF-8?Q?=E2=80=98NSData=E2=80=99?= Message-ID: <1172803120.4916.2.camel@aleph.whitemice.org> After doing an "svn up" SOPE now fails to build with the following message: Compiling file iCalYearlyRecurrenceCalculator.m ... Compiling file NGICalSaxHandler.m ... Compiling file NGVCard.m ... In file included from NGVCard.m:22: NGVCard.h:94: error: expected specifier-qualifier-list before ‘NSData’ NGVCard.h:160: error: expected ‘)’ before ‘NSData’ NGVCard.h:161: error: expected ‘)’ before ‘NSData’ NGVCard.m: In function ‘-[NGVCard setPhoto:]’: NGVCard.m:287: warning: conflicting types for ‘-(void)setPhoto:(NSData *)_photo’ NGVCard.h:160: warning: previous declaration of ‘-(void)setPhoto:(id)_photo’ NGVCard.m:288: error: ‘struct NGVCard’ has no member named ‘photo’ NGVCard.m:288: error: ‘struct NGVCard’ has no member named ‘photo’ NGVCard.m: In function ‘-[NGVCard photo]’: NGVCard.m:290: warning: conflicting types for ‘-(NSData *)photo’ NGVCard.h:161: warning: previous declaration of ‘-(id)photo’ NGVCard.m:291: error: ‘struct NGVCard’ has no member named ‘photo’ NGVCard.m:292: warning: control reaches end of non-void function make[3]: *** [shared_debug_obj/NGVCard.o] Error 1 make[2]: *** [libNGiCal.all.library.variables] Error 2 make[2]: Leaving directory `/home/awilliam/Documents/Works/OpenGroupware/sope/sope-ical/NGiCal' make[1]: *** [internal-all] Error 2 make[1]: Leaving directory `/home/awilliam/Documents/Works/OpenGroupware/sope/sope-ical' make: *** [internal-all] Error 2 awilliam@aleph:~/Works/OpenGroupware/sope> svn up At revision 1446. From developer@opengroupware.org Fri Mar 2 12:25:40 2007 From: developer@opengroupware.org (Helge Hess) Date: Fri, 2 Mar 2007 13:25:40 +0100 Subject: [OGo-Developer] =?WINDOWS-1252?Q?Re:_[OGo-Developer]_error:_expected_specifier-q?= =?WINDOWS-1252?Q?ualifier-list_before_=91NSData=92?= In-Reply-To: <1172803120.4916.2.camel@aleph.whitemice.org> References: <1172803120.4916.2.camel@aleph.whitemice.org> Message-ID: On Mar 2, 2007, at 03:38, Adam Tauno Williams wrote: > After doing an "svn up" SOPE now fails to build with the following > message: Fixed that. But note that OGo trunk is currently supposed to be used with the SOPE 4.6 branch. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Fri Mar 2 15:05:57 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Fri, 02 Mar 2007 10:05:57 -0500 Subject: [OGo-Developer] Patches In Bugzilla In-Reply-To: References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> Message-ID: <1172847957.4307.1.camel@aleph.whitemice.org> --=-rxqrehFwIZhcREKcvwZT Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > I'll try to find the time to create the account for you this week. Do =20 > you already have a login at developer.opengroupware.org? Yes, I have an account for POGI. Login is "awilliam" I believe. --=-rxqrehFwIZhcREKcvwZT Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF6D1VLRePpNle04MRAniFAJ9iI6wOUAFke5FLWSF7htSW7wbPCwCfQ1HN hLvsCBvHwUu/6OcqqxHj+7s= =cTov -----END PGP SIGNATURE----- --=-rxqrehFwIZhcREKcvwZT-- From developer@opengroupware.org Sun Mar 4 15:44:06 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Sun, 04 Mar 2007 16:44:06 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070304154407.314E13A3FF@l00-bugdead-prods.de> Hi, I try to get access to the extended person attributes and telephone numbers of the members of the teams in ogo in OGoGroupsPage WebUI. running ogo with -LSProfileCommands YES, I see that the following commands are called when I enter the Teams module. They are called in: LSGetMemberForTeamCommand.m 0.000s userdefaults::get 0.000s userdefaults::get 0.009s person::get-extattrs 0.007s person::get-telephones when I add some NSLog output lines in e.g. LSFetchTelsForPersonCommand.m, that defines person::get-telephones, I see on the command line output that ogo is retrieving the telephone numbers for the team members. but adding NSLog(@"Team members: %@", members); just after running the team::members command, only shows me an array of References: <20070304154407.314E13A3FF@l00-bugdead-prods.de> Message-ID: On Mar 4, 2007, at 16:44, Sebastian Reitenbach wrote: > but adding > NSLog(@"Team members: %@", members); > just after running the team::members command, only shows me an > array of > description Person attributes={ of the team members. Unfortunately > they do not > contain the extended attributes nor telephone numbers. That doesn't matter, the description only lists the attributes of the table. > I am looking for a way to access these values in the webui. If they are fetched, they should be available like 'item.01_tel' etc. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Mon Mar 5 21:31:47 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Mon, 05 Mar 2007 22:31:47 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070305213148.5A4E73A562@l00-bugdead-prods.de> developer@opengroupware.org wrote: > On Mar 4, 2007, at 16:44, Sebastian Reitenbach wrote: > > but adding > > NSLog(@"Team members: %@", members); > > just after running the team::members command, only shows me an > > array of > > > description Person attributes={ of the team members. Unfortunately > > they do not > > contain the extended attributes nor telephone numbers. > > That doesn't matter, the description only lists the attributes of the > table. > hmm, ok, did not know yet. > > I am looking for a way to access these values in the webui. > > If they are fetched, they should be available like 'item.01_tel' etc. > unfortunately doesn't seem to work for me. the code below create two empty lines where I thought would be fine if the telephone numbers appear. something must still be missing? Sebastian From developer@opengroupware.org Tue Mar 6 07:15:59 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Mar 2007 08:15:59 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070305213148.5A4E73A562@l00-bugdead-prods.de> References: <20070305213148.5A4E73A562@l00-bugdead-prods.de> Message-ID: On Mar 5, 2007, at 22:31, Sebastian Reitenbach wrote: >>> I am looking for a way to access these values in the webui. >> >> If they are fetched, they should be available like 'item.01_tel' etc. >> > unfortunately doesn't seem to work for me. the code below create > two empty lines > where I > thought would be fine if the telephone numbers appear. > > string="item.description" > selection="selectedGroup" > noSelectionString="noSelectionString" > const:onChange="document.editform.submit();" /> > > > > > > > var:_oid="account.companyId"> > > > > > something must still be missing? Well, I suppose the telephones are not fetched into the mentioned records. "session.teams" isn't really a recommended way to access teams anyways. I think the best bet is too look at the Appointment-Viewer "view details" button and what it does. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 6 08:09:12 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 06 Mar 2007 09:09:12 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070306080912.F074F3A5DC@l00-bugdead-prods.de> Hi Helge, > > Well, I suppose the telephones are not fetched into the mentioned > records. "session.teams" isn't really a recommended way to access > teams anyways. in OGoGroupsPage.m it fetches the members like this: /* fetch members */ members = [cmdctx runCommand:@"team::members", @"teams", self->groupList, @"returnType", intObj(LSDBReturnType_ManyObjects), nil]; team::members is defined in LSGetMemberForTeamCommand.m, in method - (void)_fetchMembersOfTeam:(id)team inContext:(id)_context { ... LSRunCommandV(_context, @"person", @"get-extattrs", @"objects", m, @"relationKey", @"companyValue", nil); /* get telephones */ LSRunCommandV(_context, @"person", @"get-telephones", @"objects", m, @"relationKey", @"telephones", nil); this is called, and get-telephones is defined in LSFetchTelsForPersonCommand.m and looks like this (including my NSLog statements): - (void)_setTels { int i, cnt = [[self object] count]; NSLog(@"in %@, setting telephones", [self description]); for (i = 0; i < cnt; i++) { id obj = [[self object] objectAtIndex:i]; NSArray *tels = [obj valueForKey:@"telephones"]; int j, cnt2 = [tels count]; NSLog(@"tels arrary: %@", tels); for (j = 0; j < cnt2; j++) { id tel = [tels objectAtIndex:j]; [obj takeValue:[tel valueForKey:@"number"] forKey:[tel valueForKey:@"type"]]; } NSLog(@"Telephones object: obj: %@", obj); } } I see, because of the NSLog statements, the telephone information is fetchted from the database, but If it is not used, I wonder why it is done in the first place. I wonder how I could the already fetched values up into the member record? another question, what are the differences between calling a command like this: /* get telephones */ LSRunCommandV(_context, @"person", @"get-telephones", @"objects", m, @"relationKey", @"telephones", nil); and like this: members = [cmdctx runCommand:@"team::members", @"teams", self->groupList, @"returnType", intObj(LSDBReturnType_ManyObjects), nil]; > > I think the best bet is too look at the Appointment-Viewer "view > details" button and what it does. maybe I should do this, but I thought it would be cleaner to use what is there in the OGoGroupsPage, but if nothing helps, I'll need to take a look there. Sebastian From developer@opengroupware.org Tue Mar 6 08:45:03 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Mar 2007 09:45:03 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070306080912.F074F3A5DC@l00-bugdead-prods.de> References: <20070306080912.F074F3A5DC@l00-bugdead-prods.de> Message-ID: <163BCCC9-A4C8-4D8C-820E-23E6B282F6B9@opengroupware.org> On Mar 6, 2007, at 09:09, Sebastian Reitenbach wrote: > in OGoGroupsPage.m it fetches the members like this: > /* fetch members */ > members = [cmdctx runCommand:@"team::members", > @"teams", self->groupList, > @"returnType", intObj(LSDBReturnType_ManyObjects), > nil]; ... > /* get telephones */ > LSRunCommandV(_context, @"person", @"get-telephones", > @"objects", m, > @"relationKey", @"telephones", nil); Well, then the telephones should be available in the 'telephones' array of the object. > I see, because of the NSLog statements, the telephone information > is fetchted > from the database, but If it is not used, I wonder why it is done > in the first place. Because its just a generic fetch method which fetches some superflous information. > another question, what are the differences between calling a > command like this: > /* get telephones */ > LSRunCommandV(_context, @"person", @"get-telephones", > @"objects", m, > @"relationKey", @"telephones", nil); > > and like this: > members = [cmdctx runCommand:@"team::members", > @"teams", self->groupList, > @"returnType", intObj(LSDBReturnType_ManyObjects), > nil]; No difference. One of those probably just calls the other. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 6 09:02:02 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 06 Mar 2007 10:02:02 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070306090202.89F4C3A5E5@l00-bugdead-prods.de> developer@opengroupware.org wrote: > On Mar 6, 2007, at 09:09, Sebastian Reitenbach wrote: > > in OGoGroupsPage.m it fetches the members like this: > > /* fetch members */ > > members = [cmdctx runCommand:@"team::members", > > @"teams", self->groupList, > > @"returnType", intObj(LSDBReturnType_ManyObjects), > > nil]; > ... > > /* get telephones */ > > LSRunCommandV(_context, @"person", @"get-telephones", > > @"objects", m, > > @"relationKey", @"telephones", nil); > > Well, then the telephones should be available in the 'telephones' > array of the object. ah, ok, so there is a members.telephones.01_tel key then? or do you mean I have to add an NSArray *telephones to the OGoGroupsPage so that the telephone numbers will be saved in there, while now as there is no such an array, they just disappear?. > > > I see, because of the NSLog statements, the telephone information > > is fetchted > > from the database, but If it is not used, I wonder why it is done > > in the first place. > > Because its just a generic fetch method which fetches some superflous > information. ok > > > another question, what are the differences between calling a > > command like this: > > /* get telephones */ > > LSRunCommandV(_context, @"person", @"get-telephones", > > @"objects", m, > > @"relationKey", @"telephones", nil); > > > > and like this: > > members = [cmdctx runCommand:@"team::members", > > @"teams", self->groupList, > > @"returnType", intObj(LSDBReturnType_ManyObjects), > > nil]; > > No difference. One of those probably just calls the other. ok, yes the team:members some time later calls that get-telephones command. kind regards Sebastian From developer@opengroupware.org Tue Mar 6 09:16:41 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Mar 2007 10:16:41 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070306090202.89F4C3A5E5@l00-bugdead-prods.de> References: <20070306090202.89F4C3A5E5@l00-bugdead-prods.de> Message-ID: <4633941E-3588-4D51-B2D4-BCF31BEABD1C@opengroupware.org> On Mar 6, 2007, at 10:02, Sebastian Reitenbach wrote: > ah, ok, so there is a members.telephones.01_tel key then? ? members is and array and telephones is an array. You probably need a WORepetition to walk over them. > or do you mean I have to add an NSArray *telephones to the > OGoGroupsPage so that the telephone numbers will be saved in there, > while now as there is no such an array, they just disappear?. Hm, no? >>> another question, what are the differences between calling a >>> command like this: >>> /* get telephones */ >>> LSRunCommandV(_context, @"person", @"get-telephones", >>> @"objects", m, >>> @"relationKey", @"telephones", nil); >>> >>> and like this: >>> members = [cmdctx runCommand:@"team::members", >>> @"teams", self->groupList, >>> @"returnType", intObj >>> (LSDBReturnType_ManyObjects), >>> nil]; >> >> No difference. One of those probably just calls the other. > ok, yes the team:members some time later calls that get-telephones > command. Ups, sorry. I thought you asked about the difference between LSRunCommandV function and the -runCommand: method. Then in fact I don't understand what you real question is. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 6 09:34:43 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 06 Mar 2007 10:34:43 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070306093444.4648F3A5DE@l00-bugdead-prods.de> Hi, developer@opengroupware.org wrote: > On Mar 6, 2007, at 10:02, Sebastian Reitenbach wrote: > > ah, ok, so there is a members.telephones.01_tel key then? > > ? members is and array and telephones is an array. You probably need > a WORepetition to walk over them. so telephones is an independent array from the members array then, but where is it defined? > > > or do you mean I have to add an NSArray *telephones to the > > OGoGroupsPage so that the telephone numbers will be saved in there, > > while now as there is no such an array, they just disappear?. > > Hm, no? But in OGoGroupsPage.m I do not have a telephones array, is this created from running the command? I am wondering where the telephones NSArray is created, while running the command? I do not understand where it comes from. > >> > >> No difference. One of those probably just calls the other. > > ok, yes the team:members some time later calls that get-telephones > > command. > > Ups, sorry. I thought you asked about the difference between > LSRunCommandV function and the -runCommand: method. > Then in fact I don't understand what you real question is. no, you got me right, I was just wondering why there are two ways to do the same thing, and thought there must be some kind of a difference between these two, but might be some older and newer things.... kind regards Sebastian From developer@opengroupware.org Tue Mar 6 09:45:02 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Mar 2007 10:45:02 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070306093444.4648F3A5DE@l00-bugdead-prods.de> References: <20070306093444.4648F3A5DE@l00-bugdead-prods.de> Message-ID: <49C7498C-6089-4BA5-8A8E-62E2A9CDF5FE@opengroupware.org> On Mar 6, 2007, at 10:34, Sebastian Reitenbach wrote: > developer@opengroupware.org wrote: >> On Mar 6, 2007, at 10:02, Sebastian Reitenbach wrote: >>> ah, ok, so there is a members.telephones.01_tel key then? >> >> ? members is and array and telephones is an array. You probably need >> a WORepetition to walk over them. > so telephones is an independent array from the members array then, > but where is > it defined? I can't follow you. Its a key of any given person object, what else could it be? :-) >>> or do you mean I have to add an NSArray *telephones to the >>> OGoGroupsPage so that the telephone numbers will be saved in there, >>> while now as there is no such an array, they just disappear?. >> Hm, no? > But in OGoGroupsPage.m I do not have a telephones array, is this > created from > running the command? I am wondering where the telephones NSArray is > created, while running > the command? > I do not understand where it comes from. Its set by /* get telephones */ LSRunCommandV(_context, @"person", @"get-telephones", @"objects", m, @"relationKey", @"telephones", nil); Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 6 09:58:44 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 06 Mar 2007 10:58:44 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070306095845.1729D3A5E6@l00-bugdead-prods.de> Hi, developer@opengroupware.org wrote: > On Mar 6, 2007, at 10:34, Sebastian Reitenbach wrote: > > developer@opengroupware.org wrote: > >> On Mar 6, 2007, at 10:02, Sebastian Reitenbach wrote: > >>> ah, ok, so there is a members.telephones.01_tel key then? > >> > >> ? members is and array and telephones is an array. You probably need > >> a WORepetition to walk over them. > > so telephones is an independent array from the members array then, > > but where is > > it defined? > > I can't follow you. Its a key of any given person object, what else > could it be? :-) /* fetch members */ members = [cmdctx runCommand:@"team::members", @"teams", self->groupList, @"returnType", intObj(LSDBReturnType_ManyObjects), nil]; NSLog(@"The team members telephones: %@", telephones); I get the following compiling errors: Making all for wobundle GroupsUI... Compiling file GroupsUIModule.m ... Compiling file OGoGroupsPage.m ... OGoGroupsPage.m: In function `-[OGoGroupsPage _fetchMyTeams]': OGoGroupsPage.m:280: error: `telephones' undeclared (first use in this function) OGoGroupsPage.m:280: error: (Each undeclared identifier is reported only once OGoGroupsPage.m:280: error: for each function it appears in.) gmake[1]: *** [shared_obj/OGoGroupsPage.o] Error 1 gmake: *** [GroupsUI.all.wobundle.variables] Error 2 will the telephones array be filled with values, when it exists, e.g. is declared in the class definition, before the command is run? > Its set by > /* get telephones */ > LSRunCommandV(_context, @"person", @"get-telephones", > @"objects", m, > @"relationKey", @"telephones", nil); but I am still wondering, how do I get the values from that telephones array up to the OGoGroupsPage, to make them available there. kind regards Sebastian From developer@opengroupware.org Tue Mar 6 10:03:44 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Mar 2007 11:03:44 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070306095845.1729D3A5E6@l00-bugdead-prods.de> References: <20070306095845.1729D3A5E6@l00-bugdead-prods.de> Message-ID: <9094F8D3-D9B3-4065-9E31-235FF462ED56@opengroupware.org> On Mar 6, 2007, at 10:58, Sebastian Reitenbach wrote: > /* fetch members */ > members = [cmdctx runCommand:@"team::members", > @"teams", self->groupList, > @"returnType", intObj(LSDBReturnType_ManyObjects), > nil]; > NSLog(@"The team members telephones: %@", telephones); Sebastian, sorry, but please do the obvious and get and read a C tutorial. Then read the Objective-C book. This is really 101 stuff. members = [cmdctx runCommand:@"team::members", @"teams", self->groupList, @"returnType", intObj(LSDBReturnType_ManyObjects), nil]; for (int i = 0; i < [members count]; i++) { NSLog(@"member: %@", [members objectAtIndex:i]); NSArray *tels = [[members objectAtIndex:i] valueForKey:@"telephones"]; for (int j = 0; j < [tels count]; j++) NSLog(@" tel: %@", [tels objectAtIndex:j]); } Of course you need no code at all when you do this using WORepetition's as I initially suggested. Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 6 10:28:08 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 06 Mar 2007 11:28:08 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070306102808.7CE6D3A5F1@l00-bugdead-prods.de> Hi Helge, developer@opengroupware.org wrote: > On Mar 6, 2007, at 10:58, Sebastian Reitenbach wrote: > > /* fetch members */ > > members = [cmdctx runCommand:@"team::members", > > @"teams", self->groupList, > > @"returnType", intObj(LSDBReturnType_ManyObjects), > > nil]; > > NSLog(@"The team members telephones: %@", telephones); > > Sebastian, sorry, but please do the obvious and get and read a C > tutorial. Then read the Objective-C book. This is really 101 stuff. I did read a lot of tutorials, e-books, ... available on objective C, gnustep, ... but it is a bit cumbersome, as some of the tutorials are working with libFoundation, some only with gnustep-base... inbetween I have no time to practice, and maybe forget... besides that, on the gnustep list I have read that libFoundation and gnustep-base will be merged. At least I know that sope and ogo compiles with gnustep-base instead of libFoundation installed, but without any Defautlts set, it was crashing immediately after startup. I tested this on OpenBSD. When the Libretto is back, I will use it install gnustep environment and ogo on it. So if you need someone testing sope and ogo running with gnustep-base, I'll volunteer. > > members = [cmdctx runCommand:@"team::members", > @"teams", self->groupList, > @"returnType", intObj(LSDBReturnType_ManyObjects), > nil]; > for (int i = 0; i < [members count]; i++) { > NSLog(@"member: %@", [members objectAtIndex:i]); > > NSArray *tels = [[members objectAtIndex:i] > valueForKey:@"telephones"]; > for (int j = 0; j < [tels count]; j++) > NSLog(@" tel: %@", [tels objectAtIndex:j]); > } > I was not aware that telephones will be accessible this way, but it looks very promising, I will test in the evening. > Of course you need no code at all when you do this using > WORepetition's as I initially suggested. thanks for your patience Sebastian From developer@opengroupware.org Tue Mar 6 10:36:33 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Mar 2007 11:36:33 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070306102808.7CE6D3A5F1@l00-bugdead-prods.de> References: <20070306102808.7CE6D3A5F1@l00-bugdead-prods.de> Message-ID: <068011A0-58B1-4711-9390-9DE56FF13F2A@opengroupware.org> On Mar 6, 2007, at 11:28, Sebastian Reitenbach wrote: > besides that, on the gnustep list I have read that libFoundation and > gnustep-base will be merged. Of course thats nonsense. The two can't be merged. Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 6 11:41:48 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 06 Mar 2007 06:41:48 -0500 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070306080912.F074F3A5DC@l00-bugdead-prods.de> References: <20070306080912.F074F3A5DC@l00-bugdead-prods.de> Message-ID: <1173181308.4440.8.camel@aleph.whitemice.org> > another question, what are the differences between calling a command like this: > /* get telephones */ > LSRunCommandV(_context, @"person", @"get-telephones", > @"objects", m, > @"relationKey", @"telephones", nil); > > and like this: > members = [cmdctx runCommand:@"team::members", > @"teams", self->groupList, > @"returnType", intObj(LSDBReturnType_ManyObjects), > nil]; The first adds the telephone information to each of the objects in "m", assuming "m" is an array of records (EOGenericRecord). The second initializes "members" to the array of records returned by the search. For retrieving phone numbers I've also used: NSArray *phones; phones = [cmdctx runCommand:@"telephone::get", @"companyId", _companyId, @"returnType", intObj(LSDBReturnType_ManyObjects), nil]; *Where _companyId is an NSNumber. From developer@opengroupware.org Tue Mar 6 11:43:46 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Mar 2007 12:43:46 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <1173181308.4440.8.camel@aleph.whitemice.org> References: <20070306080912.F074F3A5DC@l00-bugdead-prods.de> <1173181308.4440.8.camel@aleph.whitemice.org> Message-ID: <464E25DA-7881-4F00-9455-9D5DC4111C2D@opengroupware.org> On Mar 6, 2007, at 12:41, Adam Tauno Williams wrote: > For retrieving phone numbers I've also used: > NSArray *phones; > phones = [cmdctx runCommand:@"telephone::get", > @"companyId", _companyId, > @"returnType", intObj(LSDBReturnType_ManyObjects), > nil]; > *Where _companyId is an NSNumber. Thats only efficient for a single company record. Do not use it in combination with arrays (eg arrays of members). Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 6 12:06:00 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 06 Mar 2007 07:06:00 -0500 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070306102808.7CE6D3A5F1@l00-bugdead-prods.de> References: <20070306102808.7CE6D3A5F1@l00-bugdead-prods.de> Message-ID: <1173182760.4440.17.camel@aleph.whitemice.org> > > On Mar 6, 2007, at 10:58, Sebastian Reitenbach wrote: > > > /* fetch members */ > > > members = [cmdctx runCommand:@"team::members", > > > @"teams", self->groupList, > > > @"returnType", intObj(LSDBReturnType_ManyObjects), > > > nil]; > > > NSLog(@"The team members telephones: %@", telephones); > > Sebastian, sorry, but please do the obvious and get and read a C > > tutorial. Then read the Objective-C book. This is really 101 stuff. > I did read a lot of tutorials, e-books, ... available on objective C, gnustep, > ... > but it is a bit cumbersome, as some of the tutorials are working with > libFoundation, some > only with gnustep-base... inbetween I have no time to practice, and maybe > forget... It is confusing, but primarily because of the pile of new terminology. There seems to be few differences between GNUstep and libFoundation. Objective-C is actually really nice one you get a little used to it, and accustom yourself to the wacky square-bracket syntax. > besides that, on the gnustep list I have read that libFoundation and > gnustep-base will be merged. At least I know that sope and ogo compiles > with gnustep-base instead of libFoundation I think for the application-level developer libFoundation/GNUstep issue is irrelevant. libFoundation just implements the base classes. > > members = [cmdctx runCommand:@"team::members", > > @"teams", self->groupList, > > @"returnType", intObj(LSDBReturnType_ManyObjects), > > nil]; > > for (int i = 0; i < [members count]; i++) { > > NSLog(@"member: %@", [members objectAtIndex:i]); > > > > NSArray *tels = [[members objectAtIndex:i] > > valueForKey:@"telephones"]; > > for (int j = 0; j < [tels count]; j++) > > NSLog(@" tel: %@", [tels objectAtIndex:j]); > > } > I was not aware that telephones will be accessible this way, but it looks very > promising, I will test in the evening. It is. The - LSRunCommandV(_context, @"person", @"get-telephones", @"objects", m, @"relationKey", @"telephones", nil); - command adds them to the person records under the telephones key. EOGenericRecords are mutable, which, at first, was a mental hurdle for me as well. Each phone record has the following keys: telephoneId , companyId, info, number, realNumber, type, and url. > > Of course you need no code at all when you do this using > > WORepetition's as I initially suggested. From developer@opengroupware.org Tue Mar 6 13:55:20 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 06 Mar 2007 08:55:20 -0500 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <464E25DA-7881-4F00-9455-9D5DC4111C2D@opengroupware.org> References: <20070306080912.F074F3A5DC@l00-bugdead-prods.de> <1173181308.4440.8.camel@aleph.whitemice.org> <464E25DA-7881-4F00-9455-9D5DC4111C2D@opengroupware.org> Message-ID: <1173189320.5512.4.camel@aleph.whitemice.org> --=-uvaCNwmIp0+jUbdb+Jcb Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > > For retrieving phone numbers I've also used: > > NSArray *phones; > > phones =3D [cmdctx runCommand:@"telephone::get", > > @"companyId", _companyId, > > @"returnType", intObj(LSDBReturnType_ManyObjects), > > nil]; > > *Where _companyId is an NSNumber. >=20 > Thats only efficient for a single company record. Do not use it in =20 > combination with arrays (eg arrays of members). Yep, I'm aware of this; and ZOGI does bulk fetches in most places. =20 I need to clean-up/optimize the code that does some of the additive stuff. --=-uvaCNwmIp0+jUbdb+Jcb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF7XLILRePpNle04MRAh9CAJwOQ+LqUnZC/6UeMJl/MkbV2ouT5QCfUUXZ BLnTdF5Sto4Cp42/d1xv2ho= =B9H8 -----END PGP SIGNATURE----- --=-uvaCNwmIp0+jUbdb+Jcb-- From developer@opengroupware.org Tue Mar 6 13:59:02 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 06 Mar 2007 08:59:02 -0500 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <068011A0-58B1-4711-9390-9DE56FF13F2A@opengroupware.org> References: <20070306102808.7CE6D3A5F1@l00-bugdead-prods.de> <068011A0-58B1-4711-9390-9DE56FF13F2A@opengroupware.org> Message-ID: <1173189542.5512.7.camel@aleph.whitemice.org> --=-hhvPKS6+wdhqIAhe6xbE Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > > besides that, on the gnustep list I have read that libFoundation and > > gnustep-base will be merged. > Of course thats nonsense. The two can't be merged. I believe there was some mention once/somewhere that eventually libFoundation might be replaced by gnustep-base (not merged). --=-hhvPKS6+wdhqIAhe6xbE Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF7XOmLRePpNle04MRAp04AJ0U5vjSo9jHeHHSPkgG2SHhz0volwCeNsig fTwF8bBLF/nnTH24g90MdyI= =N6VG -----END PGP SIGNATURE----- --=-hhvPKS6+wdhqIAhe6xbE-- From developer@opengroupware.org Tue Mar 6 14:20:03 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 06 Mar 2007 15:20:03 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members inOGOGroupsPage Message-ID: <20070306142003.E6EE73A5F6@l00-bugdead-prods.de> Hi, developer@opengroupware.org wrote: > > > besides that, on the gnustep list I have read that libFoundation and > > > gnustep-base will be merged. > > Of course thats nonsense. The two can't be merged. > > I believe there was some mention once/somewhere that eventually > libFoundation might be replaced by gnustep-base (not merged). > yes, I think you are right, it libFoundation will be replaced by gnustep-base, I was wrong with the merge... kind regards Sebastian From developer@opengroupware.org Tue Mar 6 16:56:40 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 06 Mar 2007 11:56:40 -0500 Subject: [OGo-Developer] person::qsearch In-Reply-To: <541BD9AB-E418-4A42-8F1B-6A5A17BEFCDB@opengroupware.org> References: <20061122112449.5fywxqksmc4o8kkk@www.mormail.com> <1168701481.4857.29.camel@aleph.whitemice.org> <1171663286.7485.27.camel@aleph.whitemice.org> <1171663916.7485.29.camel@aleph.whitemice.org> <541BD9AB-E418-4A42-8F1B-6A5A17BEFCDB@opengroupware.org> Message-ID: <1173200200.5512.15.camel@aleph.whitemice.org> --=-PKp09xDcmgD31TsX+q9V Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > >> "lookup of person::qsearchqualifier failed, > >> missing info" in the logs. > >> Is there any way to trace the lookup of logic commands > > It appears to be in the logic bundle: > > awilliam@aleph:~> > > strings /usr/local/lib/opengroupware.org-1.1/commands/LSPerson.cmd/=20 > > LSPerson | grep -i LSQualifierSearchPersonCommand > > __objc_class_name_LSQualifierSearchPersonCommand > Yes, and "commands.plist" contains the mapping of =20 > "person::qsearchqualifier" to the class. "person::qsearch" is working fine; it must have just been a fat-finger bug in my code since deleting the relevant section and re-keying it fixed the issue. Watching the output of "NGBundleManagerDebugEnabled" was instructive regardless. :) --=-PKp09xDcmgD31TsX+q9V Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF7Z1ILRePpNle04MRAov9AJ9QgwhJCBTDuyVCLEkKZ9Zct7wXLQCfZIm2 Zakd4pb5Y+gxjIUJGWSgPjg= =feZh -----END PGP SIGNATURE----- --=-PKp09xDcmgD31TsX+q9V-- From developer@opengroupware.org Wed Mar 7 07:02:03 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Wed, 07 Mar 2007 08:02:03 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070307070203.E1D593A4C1@l00-bugdead-prods.de> Hi, > > members = [cmdctx runCommand:@"team::members", > @"teams", self->groupList, > @"returnType", intObj(LSDBReturnType_ManyObjects), > nil]; > for (int i = 0; i < [members count]; i++) { > NSLog(@"member: %@", [members objectAtIndex:i]); > > NSArray *tels = [[members objectAtIndex:i] > valueForKey:@"telephones"]; > for (int j = 0; j < [tels count]; j++) > NSLog(@" tel: %@", [tels objectAtIndex:j]); > } > thanks a lot for the example, tested it and this works well for the telephones and also for the companyValue. > Of course you need no code at all when you do this using > WORepetition's as I initially suggested. I haven't tried the WORepetition yet, but just another question to something I have observed, but I was unable to find an explanation for it yet: when I add these lines to OGoGroupsPage.wox: the EOGenericRecords are printed in the WebUI, and they look generally the same, besides the contents ;). when I add lines like these: then I see the following in the webui: ("","","","") (depending on companyValue or telephones) when I add a line like this: then the value of email1 shows up in the WebUI. and finally, when I add a line like this: an empty line is produced. now the question: what are the differences between these two EOGenericRecords, so that I can make the extended attributes show up in the webui, but not the telephone numbers? kind regards Sebastian From developer@opengroupware.org Wed Mar 7 08:52:58 2007 From: developer@opengroupware.org (Helge Hess) Date: Wed, 7 Mar 2007 09:52:58 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070307070203.E1D593A4C1@l00-bugdead-prods.de> References: <20070307070203.E1D593A4C1@l00-bugdead-prods.de> Message-ID: <10AEEF2F-D3C8-4453-9447-28F08A419985@opengroupware.org> On Mar 7, 2007, at 08:02, Sebastian Reitenbach wrote: > I haven't tried the WORepetition yet Then just do it. > when I add lines like these: > > > > > then I see the following in the webui: ("","","","") (depending on > companyValue > or telephones) When you invoke -valueForKey: on an array, it will return an array containing the values for the keys. Since the objects contained in the 'telephones' array do not have a '01_tel' key, you end up having and array of empty values. You probably want to use 'number', 'type' or something like that. > when I add a line like this: > > then the value of email1 shows up in the WebUI. If account is a document object (eg SkyAccountDocument), not an EO, other rules apply. Document objects are smarter about their relationships. It could also be that companyValues are always applied directly on the EO object, not sure. It probably is this way. > and finally, when I add a line like this: > > > an empty line is produced. > > now the question: what are the differences between these two > EOGenericRecords, > so that I can make the extended attributes show up in the webui, > but not the telephone > numbers? Which *two* EOGenericRecords? I see just one, 'account'. If it is in fact an EO. Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Thu Mar 8 05:46:40 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Thu, 08 Mar 2007 06:46:40 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070308054640.946B13A820@l00-bugdead-prods.de> Hi, developer@opengroupware.org wrote: > On Mar 7, 2007, at 08:02, Sebastian Reitenbach wrote: > > I haven't tried the WORepetition yet > > Then just do it. done, this shows me the telephone types and the numbers: > > > when I add lines like these: > > > > > > > > > > then I see the following in the webui: ("","","","") (depending on > > companyValue > > or telephones) > > When you invoke -valueForKey: on an array, it will return an array > containing the values for the keys. Since the objects contained in > the 'telephones' array do not have a '01_tel' key, you end up having > and array of empty values. > You probably want to use 'number', 'type' or something like that. yes, thanks for the explanation, a line like this: shows me the array of telephone types. > > > when I add a line like this: > > > > then the value of email1 shows up in the WebUI. > > If account is a document object (eg SkyAccountDocument), not an EO, > other rules apply. Document objects are smarter about their > relationships. where can I read about the different rules that apply? > > It could also be that companyValues are always applied directly on > the EO object, not sure. It probably is this way. where do I find out whether it is directly or not? At least for me, looking at the code, the companyValues and telephones are added to the members array in the same way. where and for what should I look to find out about whether they are differently applied to the members array or not? > > > and finally, when I add a line like this: > > > > > > an empty line is produced. > > > > now the question: what are the differences between these two > > EOGenericRecords, > > so that I can make the extended attributes show up in the webui, > > but not the telephone > > numbers? > > Which *two* EOGenericRecords? I see just one, 'account'. If it is in > fact an EO. when I use these lines in the .wox template: then the contents of two EOGenericRecords are printed in the webui, one containing the companyValues, one containing the telephones. Both are EOGenericRecords and the structure looks similar in my eyes, so for me, no difference. Therefore I wonder why this: gives me the value of email1, and produces an empty line. kind regards Sebastian From developer@opengroupware.org Thu Mar 8 06:38:07 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Thu, 08 Mar 2007 07:38:07 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070308063808.06B503A64C@l00-bugdead-prods.de> Hi again, developer@opengroupware.org wrote: > Hi, > developer@opengroupware.org wrote: > > On Mar 7, 2007, at 08:02, Sebastian Reitenbach wrote: > > > I haven't tried the WORepetition yet > > > > Then just do it. > done, this shows me the telephone types and the numbers: > > value="telephone.number" /> > just forgot, how can I tell ogo to replace the 01_tel with a string from the .strings file from the translation Resources? I added a 01_tel statement to the GroupsUI.strings, as I did for the Tab name, but it was not used. kind regards Sebastian From developer@opengroupware.org Thu Mar 8 07:08:09 2007 From: developer@opengroupware.org (=?ISO-8859-1?Q?Marcus_M=FCller?=) Date: Thu, 8 Mar 2007 08:08:09 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070308063808.06B503A64C@l00-bugdead-prods.de> References: <20070308063808.06B503A64C@l00-bugdead-prods.de> Message-ID: <5E5BAD89-06D8-41EB-8004-46391D413E3D@mulle-kybernetik.com> --Apple-Mail-5--390522475 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed On 08.03.2007, at 07:38, Sebastian Reitenbach wrote: >> done, this shows me the telephone types and the numbers: >> >> > >> value="telephone.number" /> >> > > just forgot, how can I tell ogo to replace the 01_tel with a string > from the > .strings file > from the translation Resources? I added a 01_tel statement to the > GroupsUI.strings, as I did > for the Tab name, but it was not used. This is done via a label association. First, you have to make sure that the label namespace is properly defined in your .wox template, which means, that in your top level XML element this should be defined: xmlns:label="OGo:label". Then, a binding like this will do the trick: WOLabelAssociations are either a constant label lookup (no preceeding dollar sign) or the result of a KeyPath lookup with final label lookup (if a preceeding dollar sign is found). In the example above, the keypath telephone.type is resolved, with the resulting stringValue being used as a label lookup. Easy. ;-) Cheers, Marcus -- Marcus Mueller . . . crack-admin/coder ;-) Mulle kybernetiK . http://www.mulle-kybernetik.com Current projects: http://www.mulle-kybernetik.com/znek/ --Apple-Mail-5--390522475 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1
On 08.03.2007, at = 07:38, Sebastian Reitenbach wrote:

done, this shows me the = telephone types and the numbers:
=A0 =A0 =A0 =A0 =A0 =A0 = <var:foreach list=3D"account.telephones" = item=3D"telephone">
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = <var:string value=3D"telephone.type" /><html:br = /><var:string=A0
=A0 =A0 =A0 =A0 = =A0 =A0 </var:foreach>

just = forgot, how can I tell ogo to replace the 01_tel with a string from = the
.strings file=A0
from the = translation Resources? I added a 01_tel statement to the
GroupsUI.strings, as I did=A0
for the = Tab name, but it was not used.

This is done via a label = association. First, you have to make sure that the label namespace is = properly defined in your .wox template, which means, that in your top = level XML element this should be = defined:=A0xmlns:label=3D"OGo:label".

Then, a binding like this = will do the trick:

= <var:foreach list=3D"account.telephones" = item=3D"telephone">
=A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 <var:string label:value=3D"$telephone.type" /><html:br = /><var:string=A0
value=3D"telephone.number" = /><html:br />
=A0 =A0 =A0 =A0 =A0 =A0 = </var:foreach>

WOLabelAssociations are = either a constant label lookup (no preceeding dollar sign) or the result = of a KeyPath lookup with final label lookup (if a preceeding dollar sign = is found). In the example above, the keypath telephone.type is resolved, = with the resulting stringValue being used as a label lookup. Easy. = ;-)

Cheers,


=A0=A0Marcus


--=A0

Marcus Mueller=A0=A0.=A0=A0.=A0=A0.=A0=A0crack-admin/coder = ;-)

Mulle = kybernetiK=A0=A0.=A0=A0http://www.mulle-kybernetik.com

Current = projects:=A0http://www.mulle-kybernetik= .com/znek/


 =

= --Apple-Mail-5--390522475-- From developer@opengroupware.org Thu Mar 8 12:26:20 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 08 Mar 2007 07:26:20 -0500 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage In-Reply-To: <20070308054640.946B13A820@l00-bugdead-prods.de> References: <20070308054640.946B13A820@l00-bugdead-prods.de> Message-ID: <1173356780.4927.9.camel@aleph.whitemice.org> > looks similar in my eyes, so for me, no difference. Therefore I wonder why this: > > gives me the value of email1, and > > produces an empty line. Perhaps Company values may be merged into the record rather than added as a subordinate key (".telephones"). But you can also find them in the key "attributeMap" ... NSMutableDictionary *valueList; NSEnumerator *enumerator; id value; valueList = [NSMutableDictionary new]; enumerator = [[eo valueForKey:@"attributeMap"] objectEnumerator]; while ((value = [enumerator nextObject]) != nil) { [valueList setObject:[NSDictionary dictionaryWithObjectsAndKeys: @"companyValue", @"entityName", [value valueForKey:@"companyValueId"], @"objectId", [value valueForKey:@"companyId"], @"companyObjectId", [self NIL:[value valueForKey:@"label"]], @"label", [self NIL:[value valueForKey:@"type"]], @"type", [self NIL:[value valueForKey:@"uid"]], @"uid", [self NIL:[value valueForKey:@"value"]], @"value", [value valueForKey:@"attribute"], @"attribute", nil] forKey:[value valueForKey:@"attribute"]]; } ..... From developer@opengroupware.org Fri Mar 9 05:55:23 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Fri, 09 Mar 2007 06:55:23 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070309055524.4A3C13A9BA@l00-bugdead-prods.de> Hi Marcus, thanks for taking time answering my basic questions. > > This is done via a label association. First, you have to make sure > that the label namespace is properly defined in your .wox template, > which means, that in your top level XML element this should be > defined: xmlns:label="OGo:label". > have added the namespace to the header. > Then, a binding like this will do the trick: > > > > value="telephone.number" /> > > with the added line in the header, your example works up to resolving the telephone type to e.g. 01_tel, but still no last resolving and usage of the values in the GroupsUI.strings file. the same as if I would use this: var:string value="telephone.type" /> I have an 01_tel statement in the GroupsUI.strings file, but it is not resolved. I see that this file is used, because when I change the tab name in there, then it changes in the webui too. I also tried lots of other variations of accessing/resolving the telephone.type. I found a similar usage of the key resolving in LSWScheduler/LSWAppointmentEditor.wox, therefore I tried sth. like this: but it did not helped. does there exist a good document explaining the inner workings of the wox templates, explaining the different namespaces that can be defined in the header and how they are used at all in the main document? on the opengroupware.org pages I only find some very basic examples like this one:http://sope.opengroupware.org/en/docs/snippets/wox.html, and on the apple pages I only find these "click some times here and there and you are done" xcode examples and writeups. kind regards Sebastian From developer@opengroupware.org Sat Mar 10 12:18:30 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Sat, 10 Mar 2007 13:18:30 +0100 Subject: [OGo-Developer] accessing telephone numbers of team members in OGOGroupsPage Message-ID: <20070310121831.22E7A3A88D@l00-bugdead-prods.de> Hi, developer@opengroupware.org wrote: > Hi Marcus, > > thanks for taking time answering my basic questions. > > > > This is done via a label association. First, you have to make sure > > that the label namespace is properly defined in your .wox template, > > which means, that in your top level XML element this should be > > defined: xmlns:label="OGo:label". > > > have added the namespace to the header. > > > Then, a binding like this will do the trick: > > > > > > > > > value="telephone.number" /> > > > > > with the added line in the header, your example works up to resolving the > telephone type to > e.g. 01_tel, but still no last resolving and usage of the values in the > GroupsUI.strings > file. > > the same as if I would use this: > var:string value="telephone.type" /> > > I have an 01_tel statement in the GroupsUI.strings file, but it is not resolved. > I see that > this file is used, because when I change the tab name in there, then it changes > in the webui > too. I also tried lots of other variations of accessing/resolving the > telephone.type. I found > a similar usage of the key resolving in LSWScheduler/LSWAppointmentEditor.wox, > therefore I > tried sth. like this: > > but it did not helped. I also tried a but I think this only makes a difference on non string objects, as I have seen no difference to before. > > does there exist a good document explaining the inner workings of the wox > templates, > explaining the different namespaces that can be defined in the header and how > they are used > at all in the main document? on the opengroupware.org pages I only find some > very basic > examples like this one:http://sope.opengroupware.org/en/docs/snippets/wox.html, > and on the > apple pages I only find these "click some times here and there and you are done" > xcode > examples and writeups. > Nevertheless, I still have not yet found all answers to my questions, but I summarized my findings so far in .wox template editing here: http://docs.opengroupware.org/Members/buzzdee/hacking ogo/webui/editing_wox_templates/document_view kind regards Sebastian From developer@opengroupware.org Mon Mar 12 07:48:52 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Mon, 12 Mar 2007 08:48:52 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: Message-ID: <20070312074853.3FA0D3AB82@l00-bugdead-prods.de> Hi list, due to the lots of explanations how commands are working and how to access values of objects, I tried again to work on skyjobnotify, to send out task reminders, more on this here on this bug report: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1167 In OGoJobs/SkyJobDocument.h, I have a setNotificationTime defined, as it is in the SkyAppointmentDocument.h for appointments, like this: - (void)setNotificationTime:(NSNumber *)_notificationTime; in skyjobnotify.m I have a following statement, where I want to set the notification time: // mark as send [job setNotificationTime:(id)[NSNull null]]; I get no compiler warnings or errors about it while compiling, but when I run skyjobnotify I get the following exception: Uncatched Objective-C exception: exceptionClass Reason: LSJob (instance) does not recognize setNotificationTime: UserInfo: no userinfo I more or less copied the stuff setNotificationTime from skyaptnotify. There it works, but I do not see a difference? anybody here with a suggestion, or need more info on what I did, what is the missing piece? kind regards Sebastian From developer@opengroupware.org Mon Mar 12 07:53:14 2007 From: developer@opengroupware.org (Helge Hess) Date: Mon, 12 Mar 2007 08:53:14 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: In-Reply-To: <20070312074853.3FA0D3AB82@l00-bugdead-prods.de> References: <20070312074853.3FA0D3AB82@l00-bugdead-prods.de> Message-ID: <98E55795-AE15-4135-AE0C-DF8500F19E43@opengroupware.org> On Mar 12, 2007, at 08:48, Sebastian Reitenbach wrote: > In OGoJobs/SkyJobDocument.h, I have a setNotificationTime defined, > as it is in > the > SkyAppointmentDocument.h for appointments, like this: - > (void)setNotificationTime:(NSNumber > *)_notificationTime; .... > [job setNotificationTime:(id)[NSNull null]]; ... > I get no compiler warnings or errors about it while compiling, (well, if you cast it to 'id', you can't expect warnings ... ;-) > Reason: LSJob (instance) does not recognize setNotificationTime: Yes, the LSJob class has no such method. You defined it on "SkyAppointmentDocument". You probably want to do: [job takeValue:nil forKey:@"notificationTime"]; or maybe [job takeValue:[NSNull null] forKey:@"notificationTime"]; though the former should be the better option (NSNull is more or less the object representation of 'nil' which is only required for collections like storing nil in NSArray or NSDictionary). Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Mon Mar 12 09:33:18 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Mon, 12 Mar 2007 10:33:18 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: Message-ID: <20070312093318.4E1BA3AC4F@l00-bugdead-prods.de> Hi, > > > Reason: LSJob (instance) does not recognize setNotificationTime: > > Yes, the LSJob class has no such method. You defined it on > "SkyAppointmentDocument". > > You probably want to do: > > [job takeValue:nil forKey:@"notificationTime"]; yes, this works well. I tried a setValue: forKey, but that already created a compiler warning. I think then I'll get it resetting the notification_time colum in the database today. thanks a lot Sebastian From developer@opengroupware.org Mon Mar 12 11:27:29 2007 From: developer@opengroupware.org (Adam Williams) Date: Mon, 12 Mar 2007 07:27:29 -0400 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: In-Reply-To: <20070312074853.3FA0D3AB82@l00-bugdead-prods.de> References: <20070312074853.3FA0D3AB82@l00-bugdead-prods.de> Message-ID: <1173698849.4040.11.camel@ws01.whitemice.org> Maybe while you hacking about in this bit of code you could also look at: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1043 That contains a scrambled patch to add properties (extended attributes) to tasks. > due to the lots of explanations how commands are working and how to access > values of objects, > I tried again to work on skyjobnotify, to send out task reminders, more on this > here on this > bug report: > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1167 > In OGoJobs/SkyJobDocument.h, I have a setNotificationTime defined, as it is in > the > SkyAppointmentDocument.h for appointments, like this: - > (void)setNotificationTime:(NSNumber > *)_notificationTime; From developer@opengroupware.org Tue Mar 13 05:39:20 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 13 Mar 2007 06:39:20 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognizesetNotificationTime: Message-ID: <20070313053921.2F8A63AD7D@l00-bugdead-prods.de> developer@opengroupware.org wrote: > Maybe while you hacking about in this bit of code you could also look > at: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1043 > > That contains a scrambled patch to add properties (extended attributes) > to tasks. Interesting, I'll definitly take a look. Sebastian From developer@opengroupware.org Tue Mar 13 05:50:53 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 13 Mar 2007 06:50:53 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: Message-ID: <20070313055053.BE3903AD8B@l00-bugdead-prods.de> developer@opengroupware.org wrote: > On Mar 12, 2007, at 08:48, Sebastian Reitenbach wrote: > > In OGoJobs/SkyJobDocument.h, I have a setNotificationTime defined, > > as it is in > > the > > SkyAppointmentDocument.h for appointments, like this: - > > (void)setNotificationTime:(NSNumber > > *)_notificationTime; > .... > > [job setNotificationTime:(id)[NSNull null]]; > ... > > I get no compiler warnings or errors about it while compiling, > > (well, if you cast it to 'id', you can't expect warnings ... ;-) I just checked, where this line comes from, and it is more or less copied from skyaptnotify ;) [_apt setNotificationTime:(id)[NSNull null]]; > [job takeValue:nil forKey:@"notificationTime"]; > as said, this works well now. I now only have one problem, updating the database. I have the following snippet in skyjobnotify: - (void)_processJob:(SkyJobDocument *)job onContext:(LSCommandContext *)_ctx { NSArray *devices; id cmdResult; id j; j = job; devices = [self _notificationDevicesForAccount:[j valueForKey:@"executant"]]; // email if ([devices containsObject:@"email"]) { [self _sendEMailForJob:job]; } // mark as send //[job setNotificationTime:0]; [j takeValue:0 forKey:@"notificationTime"]; cmdResult = [_ctx runCommand:@"job::set" arguments:j]; if (cmdResult != nil) { NSString *comment; comment = [NSString stringWithFormat:@"reminder sent"]; cmdResult = [_ctx runCommand:@"job::jobaction", @"object", j, @"action", @"comment", @"comment", comment, nil]; } if (self->beVerbose) NSLog(@"%s Notification sent to '%@' (%@) for '%@'", __PRETTY_FUNCTION__, [[job valueForKey:@"executant"] valueForKey:@"login"], [devices componentsJoinedByString:@", "], [job valueForKey:@"name"]); } when I run this with skyjobnotfiy -PGDebugEnabled YES I can observe the following: Mar 12 21:54:13 skyjobnotify [26001]: PG0x0x7d375484 SQL: BEGIN TRANSACTION ... Mar 12 21:54:14 skyjobnotify [26001]: Note: PostgreSQL72 adaptor using timezone 'MET' as default Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: UPDATE job SET keywords = null, notification_time = null, percent_complete = 0, job_comment = null, last_modified = null, parent_job_id = null, category = null, db_status = 'updated', notify_x = 0, sensitivity = 1, is_team_job = 0, executant_id = 10100, project_id = null, kind = null, source_url = null, timer_date = null, actual_work = 0, accounting_info = null, start_date = '2007-03-11 01:00:00+0100', end_date = '2007-03-13 01:00:00+0100', associated_companies = '', associated_contacts = '', total_work = 0, priority = 1, completion_date = null, name = 'testreminder', kilometers = null, is_control_job = null, job_status = '20_processing', creator_id = 10100 WHERE object_version=6 AND job_id=46330 <0x0x820e15e4[SkyAccessManager]> found no access handler for entity Job GID <0x0x86f18b84 [EOKeyGlobalID]: Job 46330>: {} Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: UPDATE job SET keywords = null, notification_time = null, percent_complete = 0, job_comment = null, last_modified = null, parent_job_id = null, category = null, db_status = 'updated', notify_x = 0, sensitivity = 1, is_team_job = 0, executant_id = 10100, project_id = null, kind = null, source_url = null, timer_date = null, actual_work = 0, accounting_info = null, start_date = '2007-03-11 01:00:00+0100', end_date = '2007-03-13 01:00:00+0100', associated_companies = '', associated_contacts = '', total_work = 0, priority = 1, completion_date = null, name = 'testreminder', kilometers = null, is_control_job = null, object_version = 7, job_status = '20_processing', creator_id = 10100 WHERE object_version=6 AND job_id=46330 Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: select nextval('key_generator') Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: INSERT INTO job_history (db_status, actor_id, action_date, job_status, job_history_id, job_id, action) VALUES ('inserted', 10000, '2007-03-12 21:54:14+0100', '20_processing', 46960, 46330, '10_commented') Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: SELECT t1.action, t1.action_date, t1.actor_id, t1.db_status, t1.job_history_id, t1.job_id, t1.job_status FROM job_history t1 WHERE t1.job_history_id=46960 Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: INSERT INTO obj_info ( obj_id, obj_type ) VALUES ( 46960, 'JobHistory' ); Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: select nextval('key_generator') Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: INSERT INTO job_history_info (db_status, job_history_id, comment, job_history_info_id) VALUES ('inserted', 46960, 'reminder sent', 46970) Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: select nextval('key_generator') Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: INSERT INTO log (object_id, account_id, log_id, creation_date, log_text, action) VALUES (46330, 10000, 46980, '2007-03-12 21:54:14+0100', 'Job comment', '05_changed') Mar 12 21:54:14 skyjobnotify [26001]: PG0x0x7d375484 SQL: SELECT t1.account_id, t1.action, t1.creation_date, t1.log_id, t1.log_text, t1.object_id FROM log t1 WHERE t1.log_id=46980 The transaction is not committed, and therefore nothing changed in the database. I can cut 'n paste the sql statements into psql and they work. How do I get the tool to send a COMMIT transaction to the database? kind regards Sebastian From developer@opengroupware.org Tue Mar 13 06:15:48 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 13 Mar 2007 07:15:48 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognizesetNotificationTime: Message-ID: <20070313061549.C2C123ABDF@l00-bugdead-prods.de> developer@opengroupware.org wrote: > developer@opengroupware.org wrote: > > Maybe while you hacking about in this bit of code you could also look > > at: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1043 > > > > That contains a scrambled patch to add properties (extended attributes) > > to tasks. > Interesting, I'll definitly take a look. I just created and uploaded a patch, from that what was already there, to that bugzilla entry. It applies to trunk, but have not compiled nor tested it yet. kind regards Sebastian From developer@opengroupware.org Tue Mar 13 09:00:24 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 13 Mar 2007 10:00:24 +0100 Subject: Svn Re: [OGo-Developer] Patches In Bugzilla In-Reply-To: <1172847957.4307.1.camel@aleph.whitemice.org> References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> <1172847957.4307.1.camel@aleph.whitemice.org> Message-ID: On Mar 2, 2007, at 16:05, Adam Tauno Williams wrote: >> I'll try to find the time to create the account for you this week. Do >> you already have a login at developer.opengroupware.org? > Yes, I have an account for POGI. Login is "awilliam" I believe. OK, you have a login 'adam' on developer.opengroupware.org and it looks like a password is set. Can you login via 'ssh adam@developer.opengroupware.org'? In fact you should be able to checkout OGo in r/w mode from http://developer.opengroupware.org/OpenGroupware.org/trunk Let me know whether it works. Thanks, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 13 09:03:16 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 13 Mar 2007 10:03:16 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: In-Reply-To: <20070313055053.BE3903AD8B@l00-bugdead-prods.de> References: <20070313055053.BE3903AD8B@l00-bugdead-prods.de> Message-ID: <3C0D940C-1F95-43DC-BC20-524BDBB14B29@opengroupware.org> On Mar 13, 2007, at 06:50, Sebastian Reitenbach wrote: > How do I get the tool to send a COMMIT transaction to the database? Well, what about committing your transaction? if ([cmdctx commit]) ... else ... Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 13 11:04:43 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 13 Mar 2007 07:04:43 -0400 Subject: Svn Re: [OGo-Developer] Patches In Bugzilla In-Reply-To: References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> <1172847957.4307.1.camel@aleph.whitemice.org> Message-ID: <1173783883.4680.3.camel@aleph.whitemice.org> On Tue, 2007-03-13 at 10:00 +0100, Helge Hess wrote: > On Mar 2, 2007, at 16:05, Adam Tauno Williams wrote: > >> I'll try to find the time to create the account for you this week. Do > >> you already have a login at developer.opengroupware.org? > > Yes, I have an account for POGI. Login is "awilliam" I believe. > OK, you have a login 'adam' on developer.opengroupware.org and it > looks like a password is set. Can you login via 'ssh > adam@developer.opengroupware.org'? Yes. > In fact you should be able to checkout OGo in r/w mode from > http://developer.opengroupware.org/OpenGroupware.org/trunk > Let me know whether it works. Nope. awilliam@aleph:~/Works/OpenGroupware/TRUNK> svn --username adam co http://developer.opengroupware.org/OpenGroupware.org/trunk Authentication realm: SVN for project OpenGroupware.org Password for 'adam': Authentication realm: SVN for project OpenGroupware.org Username: adam Password for 'adam': Authentication realm: SVN for project OpenGroupware.org Username: adam Password for 'adam': svn: PROPFIND request failed on '/OpenGroupware.org/trunk' svn: PROPFIND of '/OpenGroupware.org/trunk': authorization failed (http://developer.opengroupware.org) Using the same password both places. From developer@opengroupware.org Tue Mar 13 11:10:58 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 13 Mar 2007 12:10:58 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: Message-ID: <20070313111058.C41E83AD9F@l00-bugdead-prods.de> developer@opengroupware.org wrote: > On Mar 13, 2007, at 06:50, Sebastian Reitenbach wrote: > > How do I get the tool to send a COMMIT transaction to the database? > > Well, what about committing your transaction? > > if ([cmdctx commit]) > ... > else > ... > I saw a transaction begin and transaction commit on when the other commands did run, so I assumed that would be the same when I use job::set, but obviously they are a bit different. I'll try later in the evening, but this looks like it will work. Thanks Sebastian From developer@opengroupware.org Tue Mar 13 11:12:18 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 13 Mar 2007 12:12:18 +0100 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: In-Reply-To: <20070313111058.C41E83AD9F@l00-bugdead-prods.de> References: <20070313111058.C41E83AD9F@l00-bugdead-prods.de> Message-ID: <089DC3A5-F501-4A57-BACF-4A258A71444F@opengroupware.org> On Mar 13, 2007, at 12:10, Sebastian Reitenbach wrote: > I saw a transaction begin and transaction commit on when the other > commands did > run Commands never do a commit. Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Tue Mar 13 12:31:09 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 13 Mar 2007 08:31:09 -0400 Subject: [OGo-Developer] An Exception Has Occurred Message-ID: <1173789069.4538.0.camel@aleph.whitemice.org> --=-CEMNK6l/MPtB1B4KEIkI Content-Type: text/plain Content-Transfer-Encoding: quoted-printable At http://svn.opengroupware.org/viewcvs/ - An Exception Has Occurred Python Traceback Traceback (most recent call last): File "/usr/local/viewcvs-1.0-dev/lib/viewcvs.py", line 3194, in main request.run_viewcvs() File "/usr/local/viewcvs-1.0-dev/lib/viewcvs.py", line 264, in run_viewcv= s self.rootpath, rev) File "/usr/local/viewcvs-1.0-dev/lib/vclib/svn/__init__.py", line 322, in= __init__ self.repos =3D repos.svn_repos_open(rootpath, self.pool) SubversionException: ('Berkeley DB error while opening environment for file= system /svn/repos/OGo/db:\nDB_RUNRECOVERY: Fatal error, run database recove= ry', 160029) --=-CEMNK6l/MPtB1B4KEIkI Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF9pmNLRePpNle04MRAppwAJ4i4j6T5cFSxbOxSRCRv99iAHjgwACfYdGa Uc4EED9caJ8or99cdSz+FWM= =Tqza -----END PGP SIGNATURE----- --=-CEMNK6l/MPtB1B4KEIkI-- From developer@opengroupware.org Tue Mar 13 12:32:32 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 13 Mar 2007 08:32:32 -0400 Subject: [OGo-Developer] LSJob (instance) does not recognize setNotificationTime: In-Reply-To: <3C0D940C-1F95-43DC-BC20-524BDBB14B29@opengroupware.org> References: <20070313055053.BE3903AD8B@l00-bugdead-prods.de> <3C0D940C-1F95-43DC-BC20-524BDBB14B29@opengroupware.org> Message-ID: <1173789152.4538.2.camel@aleph.whitemice.org> --=-Bjef1mDVidd8wmjIEAw1 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > > How do I get the tool to send a COMMIT transaction to the database? > Well, what about committing your transaction? > if ([cmdctx commit]) And there is a concomitant [cmdctx rollback] if you want to rollback deliberately. --=-Bjef1mDVidd8wmjIEAw1 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF9pngLRePpNle04MRAsL3AJ4z5e2MTuBpl8xQQ8LdDCpttWgopQCfaEIZ w1ddiUL44mcW73xrPIB09HI= =OQ4d -----END PGP SIGNATURE----- --=-Bjef1mDVidd8wmjIEAw1-- From developer@opengroupware.org Tue Mar 13 13:12:06 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 13 Mar 2007 09:12:06 -0400 Subject: [OGo-Developer] LSJob (instance) does not recognizesetNotificationTime: In-Reply-To: <20070313061549.C2C123ABDF@l00-bugdead-prods.de> References: <20070313061549.C2C123ABDF@l00-bugdead-prods.de> Message-ID: <1173791526.4538.8.camel@aleph.whitemice.org> --=-4LuIsCcnCfLL6EjdeRx5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 2007-03-13 at 07:15 +0100, Sebastian Reitenbach wrote: > developer@opengroupware.org wrote:=20 > > developer@opengroupware.org wrote:=20 > > > Maybe while you hacking about in this bit of code you could also look > > > at: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1043 > > >=20 > > > That contains a scrambled patch to add properties (extended attribute= s) > > > to tasks. > > Interesting, I'll definitly take a look. > I just created and uploaded a patch, from that what was already there, to= that > bugzilla=20 > entry. It applies to trunk, but have not compiled nor tested it yet. Compiling file LSWJobEditor.m ... LSWJobEditor.m:64: error: expected identifier or =E2=80=98(=E2=80=99 before= =E2=80=98interface=E2=80=99 LSWJobEditor.m:66: error: expected =E2=80=98)=E2=80=99 before =E2=80=98SkyO= bjectPropertyManager=E2=80=99 LSWJobEditor.m:72: warning: =E2=80=98@end=E2=80=99 must appear in an @imple= mentation context LSWJobEditor.m: In function =E2=80=98compareAccounts=E2=80=99: LSWJobEditor.m:90: warning: unused variable =E2=80=98yesNum=E2=80=99 LSWJobEditor.m: In function =E2=80=98+[LSWJobEditor initialize]=E2=80=99: LSWJobEditor.m:145: error: =E2=80=98struct objc_object=E2=80=99 has no memb= er named =E2=80=98props=E2=80=99 LSWJobEditor.m:146: warning: =E2=80=98LSWJobEditor=E2=80=99 may not respond= to =E2=80=98+_setExtAttributes=E2=80=99 LSWJobEditor.m:146: warning: (Messages without a matching method signature LSWJobEditor.m:146: warning: will be assumed to return =E2=80=98id=E2=80=99= and accept LSWJobEditor.m:146: warning: =E2=80=98...=E2=80=99 as arguments.) LSWJobEditor.m: In function =E2=80=98-[LSWJobEditor init]=E2=80=99: LSWJobEditor.m:166: error: =E2=80=98struct LSWJobEditor=E2=80=99 has no mem= ber named =E2=80=98props=E2=80=99 LSWJobEditor.m:167: error: =E2=80=98struct LSWJobEditor=E2=80=99 has no mem= ber named =E2=80=98publicExtendedJobAttributes=E2=80=99 LSWJobEditor.m:168: error: =E2=80=98struct LSWJobEditor=E2=80=99 has no mem= ber named =E2=80=98privateExtendedJobAttributes=E2=80=99 LSWJobEditor.m:169: error: =E2=80=98struct LSWJobEditor=E2=80=99 has no mem= ber named =E2=80=98propMap=E2=80=99 LSWJobEditor.m: In function =E2=80=98-[LSWJobEditor dealloc]=E2=80=99: LSWJobEditor.m:173: error: =E2=80=98defaultPublicExtendedAttributes=E2=80= =99 undeclared (first use in this function) LSWJobEditor.m:173: error: (Each undeclared identifier is reported only once LSWJobEditor.m:173: error: for each function it appears in.) LSWJobEditor.m:173: error: expected =E2=80=98;=E2=80=99 before =E2=80=98{= =E2=80=99 token LSWJobEditor.m: At top level: LSWJobEditor.m:731: error: expected identifier or =E2=80=98(=E2=80=99 befor= e =E2=80=98{=E2=80=99 token LSWJobEditor.m: In function =E2=80=98-[LSWJobEditor _processInsertPropertie= s]=E2=80=99: LSWJobEditor.m:1219: warning: =E2=80=98LSWJobEditor=E2=80=99 may not respon= d to =E2=80=98-_setProperties=E2=80=99 LSWJobEditor.m:1221: error: =E2=80=98struct LSWJobEditor=E2=80=99 has no me= mber named =E2=80=98props=E2=80=99 LSWJobEditor.m:1224: warning: =E2=80=98return=E2=80=99 with a value, in fun= ction returning void LSWJobEditor.m: At top level: LSWJobEditor.m:1476: warning: incomplete implementation of class =E2=80=98LSWJobEditor=E2=80=99 LSWJobEditor.m:1476: warning: method definition for =E2=80=98-propertyManag= er=E2=80=99 not found make[3]: *** [shared_debug_obj/LSWJobEditor.o] Error 1 make[2]: *** [JobUI.all.wobundle.variables] Error 2 make[2]: Leaving directory `/usr/src/packages/BUILD/opengroupware.org/WebUI/JobUI' make[1]: *** [internal-all] Error 2 make[1]: Leaving directory `/usr/src/packages/BUILD/opengroupware.org/WebUI' make: *** [internal-all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.42439 (%build) --=-4LuIsCcnCfLL6EjdeRx5 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF9qMmLRePpNle04MRAsvxAJ40pCOn3IrHFGtIVSaQ0OwejXzM8wCfS9rh wwNXKtlS2xV/SzGECt7H46M= =7YsM -----END PGP SIGNATURE----- --=-4LuIsCcnCfLL6EjdeRx5-- From developer@opengroupware.org Tue Mar 13 13:17:10 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Tue, 13 Mar 2007 09:17:10 -0400 Subject: [OGo-Developer] LSJob (instance) does not recognizesetNotificationTime: In-Reply-To: <20070313061549.C2C123ABDF@l00-bugdead-prods.de> References: <20070313061549.C2C123ABDF@l00-bugdead-prods.de> Message-ID: <1173791830.4538.11.camel@aleph.whitemice.org> --=-6luGm82enAlW23Emmecp Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2007-03-13 at 07:15 +0100, Sebastian Reitenbach wrote: > developer@opengroupware.org wrote:=20 > > developer@opengroupware.org wrote:=20 > > > Maybe while you hacking about in this bit of code you could also look > > > at: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1043 > > > That contains a scrambled patch to add properties (extended attribute= s) > > > to tasks. > > Interesting, I'll definitly take a look. > I just created and uploaded a patch, from that what was already there, to= that > bugzilla=20 > entry. It applies to trunk, but have not compiled nor tested it yet. Another one related to both print-views and properties is show custom fields in appointment print view http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1839 - it was discusses on the mailing list not to long ago - http://mail.opengroupware.org/pipermail/users/2007-February/017291.html --=-6luGm82enAlW23Emmecp Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF9qRWLRePpNle04MRAnGiAJ9dmKzXLibVv4iDtqYxP6KafSUJHgCeIlbw 6CuxHVuAVBeY83pfZy5NMuA= =HTLi -----END PGP SIGNATURE----- --=-6luGm82enAlW23Emmecp-- From developer@opengroupware.org Tue Mar 13 15:55:16 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Tue, 13 Mar 2007 16:55:16 +0100 Subject: Where to discuss enhancements/bugs/patches to ogo WAS: [OGo-Developer] LSJob (instance) does notrecognizesetNotificationTime: Message-ID: <20070313155516.B453D3ADD7@l00-bugdead-prods.de> Hi, I'll take a look on why it is not compiling, later, will first try to get the skyjobnotfy to work ;) nevertheless, I propose to discuss bugs, patches and other enhancements via bugzilla. I mean those explicitly related to the enhancement, bug, ... just like problems like this compiling errror... Other questions related to things like this, e.g. if sth. could be accomplished in more than one way, and asking what is the preferred way, I think it should be done here. Or an other example, all my askings here about how things are working, they are not directly connected to the bug report, so they would clutter up the bugzilla too much, and nobody would search there for such questions/answers. I see it working this way and personally like it that way too, on the asterisk project. They keep discussions on patches/branches/enhancemnt in the according bugzilla entry, and this is working pretty well. for example take a look here: http://bugs.digium.com/view.php?id=5413 the SRTP patch for asterisk. I think this was discussed some weeks ago, but cannot really remember the outcome of it. any comments on this? kind regards Sebastian From developer@opengroupware.org Tue Mar 13 16:17:34 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 13 Mar 2007 17:17:34 +0100 Subject: Where to discuss enhancements/bugs/patches to ogo WAS: [OGo-Developer] LSJob (instance) does notrecognizesetNotificationTime: In-Reply-To: <20070313155516.B453D3ADD7@l00-bugdead-prods.de> References: <20070313155516.B453D3ADD7@l00-bugdead-prods.de> Message-ID: Hi, I'm not exactly sure what the question is since the procedures seem to be rather obvious. If you want to discuss features in general, use discuss. If you have technical questions related to development, ask on this list. etc If a patch submitted in Bugzilla doesn't compile, I would simple annotate the bug "doesn't compile", attach the logfile and set it to NEEDINFO. Though just closing the bug might be also a viable option, since the submitter of the bug should ensure that the patch actually works and makes sense. Bugzilla is certainly not for iterations to get a patch working at all. Thanks, Helge From developer@opengroupware.org Wed Mar 14 13:56:26 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Mar 2007 09:56:26 -0400 Subject: [OGo-Developer] Patches In Bugzilla In-Reply-To: References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> Message-ID: <1173880586.4401.8.camel@aleph.whitemice.org> --=-ewvaxK5LLbz8KuQKcXE8 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > > As for "Adding proper revision numbers of patches in Svn". Is there a > > guide for this? > If you do an 'svn commit' Subversion will give you a revision number =20 > (say r23456). Just add that to the bugfix in Bugzilla ;-) > > As in some kind of [at least rough] procedure as to the > > canonical steps? > After you applied a patch to the trunk checkout, the usual procedure is: > 1) bump the subminor version in the Version file of all affected =20 > directories > 2) add a description of the change to the ChangeLog file of the =20 > associated > directories, including the subminor you just bumped (should be =20 > obvious from > looking at the ChangeLog files). > 3) commit ;-) Maybe including the bug-id and a short text in the =20 > commit message > for reference. Okay, I applied the tiny patch for Bug#1635 http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1635 I applied the patch, compiled, tested, yada yada Then I - 1.) Edited WebUI/Project/OGoNote/Version changing "SUBMINOR_VERSION:=3D14" to "SUBMINOR_VERSION:=3D15" 2.) Editied ChangeLog in same directory, adding to top: 2007-03-14 Adam Tauno Williams * v5.1.15 * hasLSWProjects initialized incorrectly (should fix OGo bug #1635) 3.) Committed with "svn ci" with a short message: "Fix for Bug#1635; project link on notes not appearing due to improperly initialized hasLSWProjects" 4.) Closed the bug; changed to status "RESOLVED" with a comment of: "Applied in r1894" Correct? Question regarding #2: I get the 15 in 5.1.15 is the version of the directory, but where does the 5.1 come from? The next "Version" file up the tree says 5.3 (WebUI/Version). Maybe this doesn't mean anything, just curious. Question regarding #2: The whitespace before the "*" lines is a tab, this is required? I assume this is what the changeblogger parses. --=-ewvaxK5LLbz8KuQKcXE8 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF9/8JLRePpNle04MRAphBAJ0T294h7mr6Sg9/ZETEnsJhWIwSowCfVnV5 EjIS5EZ/aKdn1cLLvR6tiC4= =dZxl -----END PGP SIGNATURE----- --=-ewvaxK5LLbz8KuQKcXE8-- From developer@opengroupware.org Wed Mar 14 14:49:01 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Mar 2007 10:49:01 -0400 Subject: Where to discuss enhancements/bugs/patches to ogo WAS: [OGo-Developer] LSJob (instance) does notrecognizesetNotificationTime: In-Reply-To: References: <20070313155516.B453D3ADD7@l00-bugdead-prods.de> Message-ID: <1173883741.4401.11.camel@aleph.whitemice.org> --=-sGoIsjpFOSvWEbtTkwrC Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > I'm not exactly sure what the question is since the procedures seem =20 > to be rather obvious. > If you want to discuss features in general, use discuss. If you have =20 > technical questions related to development, ask on this list. etc As an aside I'd like to discuss@ the job notification feature. If you could post your explanation of the problem/deficiency and the logic of your proposed solution over on discuss@ it would be appreciated. --=-sGoIsjpFOSvWEbtTkwrC Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF+AtdLRePpNle04MRAs/oAJ9jn41hXrcqLxJupXYB7ugQ7v0RpgCePmfl n8M/qrfUZB0yZZfAY+cFZxY= =VRMn -----END PGP SIGNATURE----- --=-sGoIsjpFOSvWEbtTkwrC-- From developer@opengroupware.org Wed Mar 14 14:56:51 2007 From: developer@opengroupware.org (Helge Hess) Date: Wed, 14 Mar 2007 15:56:51 +0100 Subject: [OGo-Developer] Patches In Bugzilla In-Reply-To: <1173880586.4401.8.camel@aleph.whitemice.org> References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> <1173880586.4401.8.camel@aleph.whitemice.org> Message-ID: On Mar 14, 2007, at 14:56, Adam Tauno Williams wrote: > I applied the patch, compiled, tested, yada yada ;-) > Then I - > 1.) Edited WebUI/Project/OGoNote/Version changing > "SUBMINOR_VERSION:=14" > to "SUBMINOR_VERSION:=15" > 2.) Editied ChangeLog in same directory, adding to top: > 2007-03-14 Adam Tauno Williams ^^^^ This should state the email/name of the person who contributed the patch. If I make (significant) changes to the patch, I usually split it into two entries, like: ---snip--- 2007-03-14 Adam Tauno Williams * changed this and that to do that and this (v5.3.17) 2007-03-14 Bla Blub * did this and that ---snap--- > * v5.1.15 ^^^ wrong, we are at 5.3.x (OGo 1.1) > * hasLSWProjects initialized incorrectly > (should fix OGo bug #1635) If its just one change in a ChangeLog section, I directly append the version to the change, eg: ---snip--- * hasLSWProjects initialized incorrectly (should fix OGo bug #1635) (v5.3.15) ---snap--- > 3.) Committed with "svn ci" with a short message: "Fix for Bug#1635; > project link on notes not appearing due to improperly initialized > hasLSWProjects" Si. > 4.) Closed the bug; changed to status "RESOLVED" with a comment of: > "Applied in r1894" Awesome-O. > Correct? Mostly ;-) > Question regarding #2: I get the 15 in 5.1.15 is the version of the > directory, but where does the 5.1 come from? The next "Version" file > up the tree says 5.3 (WebUI/Version). Maybe this doesn't mean > anything, > just curious. You get it from WebUI/Version. v5.1.15 is incorrect, the version is v5.3.15. OGo 1.0alpha => v5.1 OGo 1.0 => v5.2 OGo 1.1 => v5.3 OGo 1.2 => v5.4 Note that we don't reset the subminor when we bump the minor, eg last change was in OGo 1.0a v5.1.15, the next change is in OGo 1.1 => v5.3.16. I wonder whether we should use the 'real' major numbers in OGo. That is, next OGo release wouldn't be 1.2 but OGo 5.4 :-) Thats not even cheated, because the codebase *is* iteration 5 (Skyrix 5). > Question regarding #2: The whitespace before the "*" lines is a tab, > this is required? I assume this is what the changeblogger parses. Marcus needs to say something about this. Don't know what Xemacs generates, could be a tab. Emacs has a special ChangeLog mode which does all the formatting. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Wed Mar 14 16:49:25 2007 From: developer@opengroupware.org (=?ISO-8859-1?Q?Marcus_M=FCller?=) Date: Wed, 14 Mar 2007 17:49:25 +0100 Subject: [OGo-Developer] Patches In Bugzilla In-Reply-To: References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> <1173880586.4401.8.camel@aleph.whitemice.org> Message-ID: --Apple-Mail-1-162753381 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed >> Question regarding #2: The whitespace before the "*" lines is a tab, >> this is required? I assume this is what the changeblogger parses. > > Marcus needs to say something about this. Don't know what Xemacs > generates, could be a tab. Emacs has a special ChangeLog mode which > does all the formatting. I'm just on my way out, lacking the time to properly look it up - but if memory serves correctly I think it definitely HAS to be a tab. It's not wrong in any case, so please use it. ;-) Cheers, Marcus -- Marcus Mueller . . . crack-admin/coder ;-) Mulle kybernetiK . http://www.mulle-kybernetik.com Current projects: http://www.mulle-kybernetik.com/znek/ --Apple-Mail-1-162753381 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1
Question = regarding #2: The whitespace before the "*" lines is a tab,
this is required?=A0 I assume this is what the = changeblogger parses.

Marcus needs to say something = about this. Don't know what Xemacs generates, could be a tab. Emacs has = a special ChangeLog mode which does all the = formatting.

I'm just on my way out, lacking = the time to properly look it up - but if memory serves correctly I think = it definitely HAS to be a tab. It's not wrong in any case, so please use = it. ;-)

Cheers,


=A0=A0Marcus


--=A0

Marcus Mueller=A0=A0.=A0=A0.=A0=A0.=A0=A0crack-admin/coder = ;-)

Mulle = kybernetiK=A0=A0.=A0=A0http://www.mulle-kybernetik.com

Current = projects:=A0http://www.mulle-kybernetik= .com/znek/


 =

= --Apple-Mail-1-162753381-- From developer@opengroupware.org Wed Mar 14 17:36:01 2007 From: developer@opengroupware.org (Adam Williams) Date: Wed, 14 Mar 2007 13:36:01 -0400 Subject: [OGo-Developer] Patches In Bugzilla In-Reply-To: References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> <1173880586.4401.8.camel@aleph.whitemice.org> Message-ID: <1173893761.4040.21.camel@ws01.whitemice.org> > > Then I - > > 1.) Edited WebUI/Project/OGoNote/Version changing > > "SUBMINOR_VERSION:=14" > > to "SUBMINOR_VERSION:=15" > > 2.) Editied ChangeLog in same directory, adding to top: > > 2007-03-14 Adam Tauno Williams > ^^^^ > This should state the email/name of the person who contributed the > patch. Ok. > If I make (significant) changes to the patch, I usually split > it into two entries, like: > ---snip--- > 2007-03-14 Adam Tauno Williams > > * changed this and that to do that and this (v5.3.17) > > 2007-03-14 Bla Blub > > * did this and that Ok. > ---snap--- > > > > * v5.1.15 > ^^^ > wrong, we are at 5.3.x (OGo 1.1) Makes sense now. > > > * hasLSWProjects initialized incorrectly > > (should fix OGo bug #1635) > > If its just one change in a ChangeLog section, I directly append the > version to the change, eg: > ---snip--- > * hasLSWProjects initialized incorrectly > (should fix OGo bug #1635) (v5.3.15) > ---snap--- Ok. > > 3.) Committed with "svn ci" with a short message: "Fix for Bug#1635; > > project link on notes not appearing due to improperly initialized > > hasLSWProjects" > Si. > > 4.) Closed the bug; changed to status "RESOLVED" with a comment of: > > "Applied in r1894" > Awesome-O. > > Correct? > Mostly ;-) > > Question regarding #2: I get the 15 in 5.1.15 is the version of the > > directory, but where does the 5.1 come from? The next "Version" file > > up the tree says 5.3 (WebUI/Version). Maybe this doesn't mean > > anything, > > just curious. > You get it from WebUI/Version. v5.1.15 is incorrect, the version is > v5.3.15. Makes sense now. > OGo 1.0alpha => v5.1 > OGo 1.0 => v5.2 > OGo 1.1 => v5.3 > OGo 1.2 => v5.4 > Note that we don't reset the subminor when we bump the minor, eg last > change was in OGo 1.0a v5.1.15, the next change is in OGo 1.1 => > v5.3.16. Ah! > I wonder whether we should use the 'real' major numbers in OGo. That > is, next OGo release wouldn't be 1.2 but OGo 5.4 :-) Yes; I definitely +1 that idea. > Thats not even cheated, because the codebase *is* iteration 5 (Skyrix > 5). Right, OGo isn't a 1.x product; this would make that clearer. > > Question regarding #2: The whitespace before the "*" lines is a tab, > > this is required? I assume this is what the changeblogger parses. > Marcus needs to say something about this. Don't know what Xemacs > generates, could be a tab. Emacs has a special ChangeLog mode which > does all the formatting. From developer@opengroupware.org Wed Mar 14 17:36:19 2007 From: developer@opengroupware.org (Adam Williams) Date: Wed, 14 Mar 2007 13:36:19 -0400 Subject: [OGo-Developer] Patches In Bugzilla In-Reply-To: References: <1169090295.7518.0.camel@aleph.whitemice.org> <07A55C34-2E2C-4131-BC7E-962180E5C175@opengroupware.org> <1169129896.4914.13.camel@aleph.whitemice.org> <1173880586.4401.8.camel@aleph.whitemice.org> Message-ID: <1173893779.4040.23.camel@ws01.whitemice.org> On Wed, 2007-03-14 at 17:49 +0100, Marcus Müller wrote: > > > Question regarding #2: The whitespace before the "*" lines is a > > > tab, > > > this is required? I assume this is what the changeblogger parses. > > Marcus needs to say something about this. Don't know what Xemacs > > generates, could be a tab. Emacs has a special ChangeLog mode which > > does all the formatting. > I'm just on my way out, lacking the time to properly look it up - but > if memory serves correctly I think it definitely HAS to be a tab. It's > not wrong in any case, so please use it. ;-) Will do. From developer@opengroupware.org Thu Mar 15 02:25:06 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Mar 2007 22:25:06 -0400 Subject: [OGo-Developer] Missing release in SkyNoteList? Message-ID: <1173925506.5030.4.camel@aleph.whitemice.org> In looking at the patch for Bug#1627 I notices that there is an "NSArray *projects", and it doesn't get released in the dealloc. (This wasn't introduced by the patch, I just noticed it because of the patch). A leak? Although neither in the page code or the template(s) do I see anything that looks like it refers to "projects". "project", but not "projects". But I could easily be missing something SkyNoteList.h declares... BOOL printMode; EOGlobalID *projectId; NSArray *notes; NSArray *projects; id appointment; id project; id note; id rootDocument; NSString *title; NSString *newNoteTitle; NSString *newNoteBody; And in SkyNoteList.m - - (void)dealloc { [self->newNoteTitle release]; [self->newNoteBody release]; [self->projectId release]; [self->project release]; [self->rootDocument release]; [self->title release]; [self->notes release]; [self->note release]; [self->appointment release]; [super dealloc]; } From developer@opengroupware.org Thu Mar 15 02:38:49 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 15 Mar 2007 03:38:49 +0100 Subject: [OGo-Developer] Missing release in SkyNoteList? In-Reply-To: <1173925506.5030.4.camel@aleph.whitemice.org> References: <1173925506.5030.4.camel@aleph.whitemice.org> Message-ID: <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> On Mar 15, 2007, at 03:25, Adam Tauno Williams wrote: > In looking at the patch for Bug#1627 I notices that there is an > "NSArray > *projects", and it doesn't get released in the dealloc. (This wasn't > introduced by the patch, I just noticed it because of the patch). A > leak? Looks like. > Although neither in the page code or the template(s) do I see anything > that looks like it refers to "projects". "project", but not > "projects". Try removing the ivar, do a "make clean all" and see what happens :-) In SOPE templates only access ivars using accessor methods (- setIvar:,-ivar), so if an ivar isn't referred from code, it can't be used by a template. [this is different to other ObjC Foundation libraries] Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Thu Mar 15 10:51:01 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 15 Mar 2007 06:51:01 -0400 Subject: [OGo-Developer] Missing release in SkyNoteList? In-Reply-To: <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> Message-ID: <1173955861.5030.8.camel@aleph.whitemice.org> > > In looking at the patch for Bug#1627 I notices that there is an > > "NSArray > > *projects", and it doesn't get released in the dealloc. (This wasn't > > introduced by the patch, I just noticed it because of the patch). A > > leak? > Looks like. > > Although neither in the page code or the template(s) do I see anything > > that looks like it refers to "projects". "project", but not > > "projects". > Try removing the ivar, do a "make clean all" and see what happens :-) Already did; it does noting. Without it you can still create, see, print, delete, edit, and link notes in both project and appointment views. > In SOPE templates only access ivars using accessor methods (- > setIvar:,-ivar), so if an ivar isn't referred from code, it can't be > used by a template. > [this is different to other ObjC Foundation libraries] Ok, that explains allot. From developer@opengroupware.org Thu Mar 15 11:20:30 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 15 Mar 2007 12:20:30 +0100 Subject: [OGo-Developer] Missing release in SkyNoteList? In-Reply-To: <1173955861.5030.8.camel@aleph.whitemice.org> References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> <1173955861.5030.8.camel@aleph.whitemice.org> Message-ID: <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> On Mar 15, 2007, at 11:51, Adam Tauno Williams wrote: > Already did; it does noting. Without it you can still create, see, > print, delete, edit, and link notes in both project and appointment > views. I suppose you can remove it then. If its used it wouldn't compile anymore. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Thu Mar 15 12:24:55 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 15 Mar 2007 08:24:55 -0400 Subject: [OGo-Developer] Missing release in SkyNoteList? In-Reply-To: <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> <1173955861.5030.8.camel@aleph.whitemice.org> <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> Message-ID: <1173961496.4394.0.camel@aleph.whitemice.org> --=-E4z0FNe5J4vhc4cXFzzc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2007-03-15 at 12:20 +0100, Helge Hess wrote: > On Mar 15, 2007, at 11:51, Adam Tauno Williams wrote: > > Already did; it does noting. Without it you can still create, see, > > print, delete, edit, and link notes in both project and appointment > > views. > I suppose you can remove it then. If its used it wouldn't compile =20 > anymore. It is gone. --=-E4z0FNe5J4vhc4cXFzzc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF+TsXLRePpNle04MRAs4EAJ9KAVvulPUZS7gNUfnncaK6vUU36gCePh9n sZJzX1NXwgRGpNbTtyHsrZ8= =09Mi -----END PGP SIGNATURE----- --=-E4z0FNe5J4vhc4cXFzzc-- From developer@opengroupware.org Thu Mar 15 12:33:33 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 15 Mar 2007 13:33:33 +0100 Subject: [OGo-Developer] SkyNotePrint In-Reply-To: <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> <1173955861.5030.8.camel@aleph.whitemice.org> <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> Message-ID: Hi, a few notes on SkyNotePrint. First, please be a bit more careful when naming things, eg SkyNotePrint is quite misleading (component to print *one* note?). Also we use OGo prefixes for all new stuff. Something like OGoNoteListPrintView would be more appropriate. Further SkyNotePrint registers itself for the 'print' command: LSWCommands = ( { verb = edit; type = "eo/note"; component = SkyNoteEditor; }, { verb = new; type = "eo/note"; component = SkyNoteEditor; }, + { verb = print; type = "eo/note"; component = SkyNotePrint; }, ); Hu? SkyNoteList is just a reusable component, it can't be activated using 'print' with an 'eo/note' object? This only makes sense if SkyNotePrint would indeed be a component to print *one* note (type: eo/note!, not an array of eo/note). And then you would need to implement the necessary API to get invoked by a command (- prepareFor... or -active* methods). Then you have added those -printMode/-setPrintMode: methods. I don't know what purpose those are supposed to serve? I mean the SkyNotePrint is always a printview, it has no "print mode" which can be turned off? The ChangeLog says: 'Removed unused ivar "projects" ... and takeValue' Ups? I can't see that 'takeValue' change in my diff, but this sounds dangerous. was there a -takeValue:forKey: method which contained code to assign the projects ivar? In this case we probably need to revert the change. But as mentioned I can't see the change in my local diff. Possibly the -takeValue:forKey: method got introduced by Sebastian's patch? Thanks, Helge From developer@opengroupware.org Thu Mar 15 12:52:39 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 15 Mar 2007 13:52:39 +0100 Subject: [OGo-Developer] SkyNotePrint In-Reply-To: References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> <1173955861.5030.8.camel@aleph.whitemice.org> <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> Message-ID: <0D4370FB-FB65-44B2-83D1-39D158033F92@opengroupware.org> Hi, wrt ChangeLog. If you change anything in WebUI/Resources, please update the associated ChangeLog! Eg: U WebUI/Resources/German.lproj/OGoNote.strings U WebUI/Resources/English.lproj/OGoNote.strings This makes it easier for translators to say up-to-date. Thanks, Helge From developer@opengroupware.org Thu Mar 15 13:59:35 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 15 Mar 2007 09:59:35 -0400 Subject: [OGo-Developer] SkyNotePrint In-Reply-To: <0D4370FB-FB65-44B2-83D1-39D158033F92@opengroupware.org> References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> <1173955861.5030.8.camel@aleph.whitemice.org> <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> <0D4370FB-FB65-44B2-83D1-39D158033F92@opengroupware.org> Message-ID: <1173967175.4394.17.camel@aleph.whitemice.org> --=-6B9l86ol0SfA1WDTANHb Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > wrt ChangeLog. If you change anything in WebUI/Resources, please =20 > update the associated ChangeLog! Eg: > U WebUI/Resources/German.lproj/OGoNote.strings > U WebUI/Resources/English.lproj/OGoNote.strings > This makes it easier for translators to say up-to-date. Ah! The ChangeLog in WebUI/Resources, I looked in WebUI/Resources/German.lproj and WebUI/Resources/English.lproj and didn't see a ChangeLog file. And the ChangeLog in WebUI/Templates applies to all the template directories. Got it. --=-6B9l86ol0SfA1WDTANHb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF+VFHLRePpNle04MRApWdAJ9UGqJL6AyGnnOJTHbzF4VotNsmdQCZARR8 wmzl3ru/RLiBpxXMy9KZz1o= =1S5E -----END PGP SIGNATURE----- --=-6B9l86ol0SfA1WDTANHb-- From developer@opengroupware.org Thu Mar 15 14:04:47 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 15 Mar 2007 10:04:47 -0400 Subject: [OGo-Developer] SkyNotePrint In-Reply-To: References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> <1173955861.5030.8.camel@aleph.whitemice.org> <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> Message-ID: <1173967487.4394.22.camel@aleph.whitemice.org> --=-0yoAhibxm0KhSSJOdaDj Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > a few notes on SkyNotePrint. > First, please be a bit more careful when naming things, eg > SkyNotePrint > is quite misleading (component to print *one* note?). Also we use OGo =20 > prefixes for all new stuff. > Something like > OGoNoteListPrintView > would be more appropriate. Understood. > Further SkyNotePrint registers itself for the 'print' command: > LSWCommands =3D ( > { verb =3D edit; type =3D "eo/note"; component =3D =20 > SkyNoteEditor; }, > { verb =3D new; type =3D "eo/note"; component =3D =20 > SkyNoteEditor; }, > + { verb =3D print; type =3D "eo/note"; component =3D =20 > SkyNotePrint; }, > ); > Hu? SkyNoteList is just a reusable component, it can't be activated =20 > using 'print' with an 'eo/note' object? This only makes sense if =20 > SkyNotePrint would indeed be a component to print *one* note (type: =20 > eo/note!, not an array of eo/note). Understood. --=-0yoAhibxm0KhSSJOdaDj Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF+VJ/LRePpNle04MRAv69AJ97OIAtT2ItIkJ/v3lAz80tCryMbACfUi6H tvV0tNrro6pqkotLeeCPcpY= =6R/L -----END PGP SIGNATURE----- --=-0yoAhibxm0KhSSJOdaDj-- From developer@opengroupware.org Thu Mar 15 14:05:41 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Thu, 15 Mar 2007 10:05:41 -0400 Subject: [OGo-Developer] SkyNotePrint In-Reply-To: References: <1173925506.5030.4.camel@aleph.whitemice.org> <2565FA6E-E0EF-4FAC-A24A-F1F572985CB0@opengroupware.org> <1173955861.5030.8.camel@aleph.whitemice.org> <28DB898F-FDDB-482D-93B1-94C905D0AF3E@opengroupware.org> Message-ID: <1173967541.4394.24.camel@aleph.whitemice.org> --=-CLPP5T63CeGgcDU0RJ6b Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > The ChangeLog says: > 'Removed unused ivar "projects" ... and takeValue' > Ups? I can't see that 'takeValue' change in my diff, but this sounds =20 > dangerous. was there a -takeValue:forKey: method which contained code =20 > to assign the projects ivar? In this case we probably need to revert =20 > the change. > But as mentioned I can't see the change in my local diff. Possibly =20 > the -takeValue:forKey: method got introduced by Sebastian's patch? I'll double check this. --=-CLPP5T63CeGgcDU0RJ6b Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBF+VK1LRePpNle04MRAryRAJ9qLgQjq/13JebflTuQFyID8K53LgCfWa5d ra8UThl05Ffe/OdJOUbAH0A= =ehXR -----END PGP SIGNATURE----- --=-CLPP5T63CeGgcDU0RJ6b-- From developer@opengroupware.org Wed Mar 28 23:48:19 2007 From: developer@opengroupware.org (Elim Qiu) Date: Wed, 28 Mar 2007 16:48:19 -0600 Subject: [OGo-Developer] where to start Message-ID: <1175122099.5791.65.camel@DebianLit> I just installted debian (Mar 25 test netinst) and then the full gnustep (by a single command: apt-get install gnustep gnustep-devel gnustep-games). It seems work. I just played the GWorkspace a bit. I need Gnustep for the EOF port and NSPropertyList related features. (Plust xml parser/convertor, this provides everything I need to get bidirectional mapping Obj <---> XML) Now I want to get OGO and SOPE. to work on the same debian laptop. My main interests is SOPE with G2 and mysql (or postgresql, if it can work with Chinese and English at the same time). Please advise me about what I need to do for the goal (package dependencies, apache config and database config), And what the recommended develop tools for SOPE on debian? I just tried to get SOPE but the it said the url was not right. This must happend very recently(see below) Thanks a lot. YL. *************** ERROR fetchh source ********************* elim@DebianLit:~/Projects/OGO$ svn co http://svn.opengroupware.org/SOPE/branches/4.4/ SOPE-4.4 svn: URL 'http://svn.opengroupware.org/SOPE/branches/4.4' doesn't exist From developer@opengroupware.org Thu Mar 29 00:25:04 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 29 Mar 2007 01:25:04 +0200 Subject: [OGo-Developer] where to start In-Reply-To: <1175122099.5791.65.camel@DebianLit> References: <1175122099.5791.65.camel@DebianLit> Message-ID: <6DB1523E-2113-4DB0-B944-D9716E5E217C@opengroupware.org> On Mar 29, 2007, at 24:48, Elim Qiu wrote: > http://svn.opengroupware.org/SOPE/branches/4.4/ SOPE-4.4 > svn: URL 'http://svn.opengroupware.org/SOPE/branches/4.4' doesn't > exist Yeah, thats sope-4.4 (or sope-4.6). Which is rather trivial to find out ... Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Thu Mar 29 00:28:11 2007 From: developer@opengroupware.org (Helge Hess) Date: Thu, 29 Mar 2007 01:28:11 +0200 Subject: [OGo-Developer] where to start In-Reply-To: <1175122099.5791.65.camel@DebianLit> References: <1175122099.5791.65.camel@DebianLit> Message-ID: <79440570-89FF-487D-98A0-4F6D74321E45@opengroupware.org> On Mar 29, 2007, at 24:48, Elim Qiu wrote: > I need Gnustep for the EOF port and NSPropertyList related features. > (Plust xml parser/convertor, this provides everything I need > to get bidirectional mapping Obj <---> XML) > > Now I want to get OGO and SOPE. to work on the same debian laptop. SOPE should work fine with GNUstep base, though we provide no precompiled packages for GNUstep. (so you need to fetch the source and build it) OGo might not yet work with GNUstep base, this is work in progress. > My main interests is SOPE with G2 and mysql (or postgresql, if it > can work with Chinese and English at the same time). I have no idea about Chinese requirements, but PostgreSQL should work just fine. SOPE has a MySQL adaptor, but the PostgreSQL one is much better tested. Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Fri Mar 30 23:16:37 2007 From: developer@opengroupware.org (Wolfgang Sourdeau) Date: Fri, 30 Mar 2007 18:16:37 -0400 Subject: [OGo-Developer] announcing SOGo (Inverse edition) Message-ID: <7c474e64a6c5f210b36d5e036cf0cb72@mozzarella> Hello everyone! After many months of development, we happy to publicize a little more our work. We, at Inverse, have been working actively in the past few months on Scalable Opengroupware.org (SOGo) and we created related projects around it. Here's what we've accomplished on various projects: [ Scalable OpenGroupware.org ] Based on the excellent work that already existed, we created an "Inverse" branch for the project. Our goal is to mimic the look and the functionality of the Mozilla application suite (Thunderbird / Lightning / Sunbird) in order to have a perfect integration between both. In pursuing that goal, we contributed to the project by adding, among many other things: - Fresh user interface based on AJAX which mimic Thunderbird / Lighthing / Sunbird look - Calendar and address book sharing capabilities using WebDAV ACLs - Tasks support and vCard storage support for contacts - Multiple address books and LDAP-based address books - CalDAV support We still actively work on the project and much more is to come very soon! [ Thunderbird Address Book GroupDAV Connector ] Synchronizing contacts with Thunderbird was also an important feature to have for SOGo. Thus, we created the Thunderbird Address Book GroupDAV Connector. It allows you to create any number of address books and synchronize them with any GroupDAV-based server. The plugin not only supports SOGo, but also OpenGroupware.org (OGo) and Citadel. [ Mozilla Thunderbird / Lightning ] Perfect integration with Mozilla Thunderbird and Lighthing is also one of our goals. In order to acheive that, we created a sma