[OGo-Developer] Patches In Bugzilla

[Adam Tauno Williams]

--=-ewvaxK5LLbz8KuQKcXE8
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

> > As for "Adding proper revision numbers of patches in Svn".  Is there a
> > guide for this?
> If you do an 'svn commit' Subversion will give you a revision number =20
> (say r23456). Just add that to the bugfix in Bugzilla ;-)
> > As in some kind of [at least rough] procedure as to the
> > canonical steps?
> After you applied a patch to the trunk checkout, the usual procedure is:
> 1) bump the subminor version in the Version file of all affected =20
> directories
> 2) add a description of the change to the ChangeLog file of the =20
> associated
>     directories, including the subminor you just bumped (should be =20
> obvious from
>     looking at the ChangeLog files).
> 3) commit ;-) Maybe including the bug-id and a short text in the =20
> commit message
>     for reference.

Okay,  I applied the tiny patch for Bug#1635

http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1635

I applied the patch, compiled, tested, yada yada

Then I -
1.) Edited WebUI/Project/OGoNote/Version changing "SUBMINOR_VERSION:=3D14"
to "SUBMINOR_VERSION:=3D15"
2.) Editied ChangeLog in same directory, adding to top:
2007-03-14  Adam Tauno Williams <awilliam@whitemiceconsulting.com>

        * v5.1.15

        * hasLSWProjects initialized incorrectly
          (should fix OGo bug #1635)
3.) Committed with "svn ci" with a short message: "Fix for Bug#1635;
project link on notes not appearing due to improperly initialized
hasLSWProjects"
4.) Closed the bug;  changed to status "RESOLVED" with a comment of:
"Applied in r1894"

Correct?

Question regarding #2:  I get the 15 in 5.1.15 is the version of the
directory,  but where does the 5.1 come from?  The next "Version" file
up the tree says 5.3 (WebUI/Version).  Maybe this doesn't mean anything,
just curious.
Question regarding #2: The whitespace before the "*" lines is a tab,
this is required?  I assume this is what the changeblogger parses.


--=-ewvaxK5LLbz8KuQKcXE8
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBF9/8JLRePpNle04MRAphBAJ0T294h7mr6Sg9/ZETEnsJhWIwSowCfVnV5
EjIS5EZ/aKdn1cLLvR6tiC4=
=dZxl
-----END PGP SIGNATURE-----

--=-ewvaxK5LLbz8KuQKcXE8--