[OGo-Developer] Missing release in SkyNoteList?

Adam Tauno Williams developer@opengroupware.org
Wed, 14 Mar 2007 22:25:06 -0400


In looking at the patch for Bug#1627 I notices that there is an "NSArray
*projects", and it doesn't get released in the dealloc.  (This wasn't
introduced by the patch, I just noticed it because of the patch).  A
leak?

Although neither in the page code or the template(s) do I see anything
that looks like it refers to "projects".  "project", but not "projects".
But I could easily be missing something

SkyNoteList.h declares...
  BOOL       printMode;
  EOGlobalID *projectId;
  NSArray    *notes;
  NSArray    *projects;
  id         appointment;
  id         project;
  id         note;
  id         rootDocument;
  NSString   *title;
  NSString   *newNoteTitle;
  NSString   *newNoteBody;

And in SkyNoteList.m -
- (void)dealloc {
  [self->newNoteTitle release];
  [self->newNoteBody  release];
  [self->projectId    release];
  [self->project      release];
  [self->rootDocument release];
  [self->title        release];
  [self->notes        release];
  [self->note         release];
  [self->appointment  release];
  [super dealloc];
}