[OGo-Developer] SkyNotePrint

[Helge Hess]

Hi,

a few notes on SkyNotePrint.


First, please be a bit more careful when naming things, eg

   SkyNotePrint

is quite misleading (component to print *one* note?). Also we use OGo  
prefixes for all new stuff.

Something like
   OGoNoteListPrintView
would be more appropriate.


Further SkyNotePrint registers itself for the 'print' command:
      LSWCommands = (
        { verb = edit; type = "eo/note";    component =  
SkyNoteEditor; },
        { verb = new;  type = "eo/note";    component =  
SkyNoteEditor; },
+      { verb = print; type = "eo/note";    component =  
SkyNotePrint;  },
      );

Hu? SkyNoteList is just a reusable component, it can't be activated  
using 'print' with an 'eo/note' object? This only makes sense if  
SkyNotePrint would indeed be a component to print *one* note (type:  
eo/note!, not an array of eo/note). And then you would need to  
implement the necessary API to get invoked by a command (- 
prepareFor... or -active* methods).


Then you have added those -printMode/-setPrintMode: methods. I don't  
know what purpose those are supposed to serve? I mean the  
SkyNotePrint is always a printview, it has no "print mode" which can  
be turned off?


The ChangeLog says:
   'Removed unused ivar "projects" ... and takeValue'

Ups? I can't see that 'takeValue' change in my diff, but this sounds  
dangerous. was there a -takeValue:forKey: method which contained code  
to assign the projects ivar? In this case we probably need to revert  
the change.
But as mentioned I can't see the change in my local diff. Possibly  
the -takeValue:forKey: method got introduced by Sebastian's patch?

Thanks,
   Helge