From developer@opengroupware.org Mon Nov 5 16:56:15 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Mon, 05 Nov 2007 11:56:15 -0500 Subject: [OGo-Developer] Task & kind Message-ID: <1194281775.4909.30.camel@WM_ADAM1.morrison.iserv.net> --=-bhBSgGLEihjRK4wdmVH0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Project's have a "kind" field that can be used to designate special types of projects. Tasks also have a "kind" field, but tasks with a kind other than NULL are always filtered out of todo/delegated lists. It looks like this "kind" field was used by some now obsolete features ("Root Process"?). Would it be safe / acceptable now to 'liberate' this field [1]? =20 It would be extremely useful to us to be able to designate a task type, but currently if we set this value the task completely vanishes both in the WebUI (which is OK, at least for us) and also via ZideStore / XML-RPC [ obviously, since the kind IS NULL constraint is in Logic ]. [1] Advising people before upgrading to purge ((kind IS NOT NULL) OR (is_control_job =3D 1)) detritus from their database). --=-bhBSgGLEihjRK4wdmVH0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBHL0svLRePpNle04MRAi8eAJ9Bu/f8dlIznXW5bRnbwMgeOhknyACfRZgf eFrS/D/c9rGfVxRKyKouMhs= =okCz -----END PGP SIGNATURE----- --=-bhBSgGLEihjRK4wdmVH0-- From developer@opengroupware.org Mon Nov 5 16:57:35 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Mon, 05 Nov 2007 11:57:35 -0500 Subject: [OGo-Developer] Changes to trunk, Testing In-Reply-To: References: Message-ID: <1194281855.4909.31.camel@WM_ADAM1.morrison.iserv.net> --=-58NB9yfpS5T1Ei7nwcxj Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2007-05-29 at 00:59 +0200, Helge Hess wrote: > I've done a few changes to the way insert/update operations work. > First of all primary key batches now work again, don't know how they =20 > got lost (the SQL sequences reserves a batch of 10 keys per =20 > invocation, so far we only used one of them resulting in wasted key =20 > space ...). > Next I changed the way object_version, last_modified, etc fields are =20 > updated, and I added those to a few classes which didn't have them =20 > before (eg docs, notes and projects). > Finally I plan to enhance the database schema for 5.4. Mostly: > - notes/documents attached to company records > - parent_id in project table > - a few other minor things > If someone has wishes for additional fields, shout now ;-) This isn't =20 > committed yet. Any more thoughts / updates on these changes? --=-58NB9yfpS5T1Ei7nwcxj Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBHL0t+LRePpNle04MRAkISAJ4ilKLtUE3ZoADLVXoDh5poK4LEXwCfXBTF icW3+VfCTwRrf2zMrgvq+Sc= =HTvQ -----END PGP SIGNATURE----- --=-58NB9yfpS5T1Ei7nwcxj-- From developer@opengroupware.org Mon Nov 5 22:02:18 2007 From: developer@opengroupware.org (Helge Hess) Date: Mon, 5 Nov 2007 23:02:18 +0100 Subject: [OGo-Developer] Task & kind In-Reply-To: <1194281775.4909.30.camel@WM_ADAM1.morrison.iserv.net> References: <1194281775.4909.30.camel@WM_ADAM1.morrison.iserv.net> Message-ID: <7E2B8CAA-FFFC-4B22-BDED-EA31F8A95695@opengroupware.org> On 05.11.2007, at 17:56, Adam Tauno Williams wrote: > Project's have a "kind" field that can be used to designate special > types of projects. > > Tasks also have a "kind" field, but tasks with a kind other than NULL > are always filtered out of todo/delegated lists. It looks like this > "kind" field was used by some now obsolete features ("Root Process"?). > Would it be safe / acceptable now to 'liberate' this field [1]? Looking at the source it seems that the "kind IS NULL" constraint is embedded rather deeply. Not sure whether it would be dangerous to relax that ... And then, I'm not sure what we need 'kind' for. [I don't remember what it was good for] In a legacy DB I could find those: => SELECT DISTINCT(kind) FROM job; kind ------------------- 00_process 01_root_milestone 01_root_process (4 rows) So it seems to be related to the "milestone" stuff which I mostly removed. > It would be extremely useful to us to be able to designate a task > type, > but currently if we set this value the task completely vanishes > both in > the WebUI (which is OK, at least for us) and also via ZideStore / > XML-RPC [ obviously, since the kind IS NULL constraint is in Logic ]. Not sure what "kinds" you think of. Probably "keywords" is what we want here? (and map that to iCal keywords?) Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Mon Nov 5 22:03:19 2007 From: developer@opengroupware.org (Helge Hess) Date: Mon, 5 Nov 2007 23:03:19 +0100 Subject: [OGo-Developer] Changes to trunk, Testing In-Reply-To: <1194281855.4909.31.camel@WM_ADAM1.morrison.iserv.net> References: <1194281855.4909.31.camel@WM_ADAM1.morrison.iserv.net> Message-ID: <335C9D5E-9BC6-4BAD-B368-AF03C1975DF8@opengroupware.org> On 05.11.2007, at 17:57, Adam Tauno Williams wrote: >> Next I changed the way object_version, last_modified, etc fields are >> updated, and I added those to a few classes which didn't have them >> before (eg docs, notes and projects). >> Finally I plan to enhance the database schema for 5.4. Mostly: >> - notes/documents attached to company records >> - parent_id in project table >> - a few other minor things >> If someone has wishes for additional fields, shout now ;-) This isn't >> committed yet. > Any more thoughts / updates on these changes? I have a few pending changes which I'm going to commit in Nov or so. Greets, Helge From developer@opengroupware.org Mon Nov 5 23:05:33 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Mon, 05 Nov 2007 18:05:33 -0500 Subject: [OGo-Developer] Task & kind In-Reply-To: <7E2B8CAA-FFFC-4B22-BDED-EA31F8A95695@opengroupware.org> References: <1194281775.4909.30.camel@WM_ADAM1.morrison.iserv.net> <7E2B8CAA-FFFC-4B22-BDED-EA31F8A95695@opengroupware.org> Message-ID: <1194303933.4527.2.camel@aleph> --=-fBcl5wBXhbMKLCTLpGBU Content-Type: text/plain Content-Transfer-Encoding: 7bit > > Tasks also have a "kind" field, but tasks with a kind other than NULL > > are always filtered out of todo/delegated lists. It looks like this > > "kind" field was used by some now obsolete features ("Root Process"?). > > Would it be safe / acceptable now to 'liberate' this field [1]? > Looking at the source it seems that the "kind IS NULL" constraint is > embedded rather deeply. Not sure whether it would be dangerous to > relax that ... And then, I'm not sure what we need 'kind' for. > [I don't remember what it was good for] > In a legacy DB I could find those: > => SELECT DISTINCT(kind) FROM job; > kind > ------------------- > 00_process > 01_root_milestone > 01_root_process > (4 rows) > So it seems to be related to the "milestone" stuff which I mostly > removed. That is pretty much what I assumed. Anyway, I've plucked the restriction out of at least the Logic bits, and so far.... by servers are still chugging away. I've tested the task lists in webui (todo, delegated, archived) and listing the tasks vi the project viewer. --=-fBcl5wBXhbMKLCTLpGBU Content-Disposition: attachment; filename=removeKindAndControlFiltersFromTaskLogic.patch Content-Type: text/x-patch; name=removeKindAndControlFiltersFromTaskLogic.patch; charset=utf-8 Content-Transfer-Encoding: 7bit Index: LSFilterArchivedJobCommand.m =================================================================== --- LSFilterArchivedJobCommand.m (revision 2045) +++ LSFilterArchivedJobCommand.m (working copy) @@ -45,16 +45,8 @@ enumerator = [[self jobList] objectEnumerator]; while ((job = [enumerator nextObject])) { - BOOL isControlJob = NO; - id ctrlJob = nil; NSString *jobStatus = [job valueForKey:@"jobStatus"]; - ctrlJob = [job valueForKey:@"isControlJob"]; - - if (ctrlJob != nil) { - isControlJob = [ctrlJob boolValue]; - } - if (([[job valueForKey:@"creatorId"] isEqual:[self creatorId]]) && ([jobStatus isEqualToString:LSJobArchived])) { [filteredJobs addObject:job]; Index: LSFilterToDoListJobCommand.m =================================================================== --- LSFilterToDoListJobCommand.m (revision 2045) +++ LSFilterToDoListJobCommand.m (working copy) @@ -46,17 +46,9 @@ enumerator = [[self jobList] objectEnumerator]; while ((job = [enumerator nextObject])) { - BOOL isControlJob = NO; - id ctrlJob = nil; NSString *jobStatus = [job valueForKey:@"jobStatus"]; - ctrlJob = [job valueForKey:@"isControlJob"]; - if (ctrlJob != nil) { - isControlJob = [ctrlJob boolValue]; - } - - if (!isControlJob && - ([[job valueForKey:@"executantId"] isEqual:[self executantId]]) && + if (([[job valueForKey:@"executantId"] isEqual:[self executantId]]) && (![jobStatus isEqualToString:LSJobArchived]) && (![jobStatus isEqualToString:LSJobDone])) { [filteredJobs addObject:job]; Index: LSFetchPrivateJobsCommand.m =================================================================== --- LSFetchPrivateJobsCommand.m (revision 2045) +++ LSFetchPrivateJobsCommand.m (working copy) @@ -38,16 +38,14 @@ initWithEntity:[self destinationEntity] qualifierFormat: @"((%A IS NULL) AND (%A <> '%@') AND " - @"(%A <> '%@') AND ((%A IS NULL) OR (%A = 0)) " - @"OR ((%A = '%@') AND (%A = %A))) AND " - @"(%A IS NULL)", + @"(%A <> '%@') " + @"OR ((%A = '%@') AND (%A = %A)))" @"projectId", @"jobStatus", LSJobArchived, @"jobStatus", LSJobDone, - @"isControlJob", @"isControlJob", @"jobStatus", LSJobDone, @"creatorId", @"executantId", - @"kind", nil] autorelease]; + nil] autorelease]; return [self _checkConjoinWithQualifier:qualifier]; } Index: LSFetchArchivedJobsCommand.m =================================================================== --- LSFetchArchivedJobsCommand.m (revision 2045) +++ LSFetchArchivedJobsCommand.m (working copy) @@ -37,11 +37,9 @@ qualifier = [[[EOSQLQualifier allocWithZone:[self zone]] initWithEntity:[self destinationEntity] qualifierFormat: - @"(%A = '%@') AND (%A IS NULL OR %A = 0) AND " - @"(%A IS NULL)", + @"(%A = '%@')", @"jobStatus", LSJobArchived, - @"isControlJob", @"isControlJob", - @"kind", nil] autorelease]; + nil] autorelease]; return [self _checkConjoinWithQualifier:qualifier]; } Index: LSFetchToDoJobsCommand.m =================================================================== --- LSFetchToDoJobsCommand.m (revision 2045) +++ LSFetchToDoJobsCommand.m (working copy) @@ -117,16 +117,14 @@ qualifier = [qualifier initWithEntity:[self destinationEntity] qualifierFormat: @"((%A <> '%@') AND ((%A <> '%@') OR " - @"(%A IN (%@))) AND ((%A IS NULL) OR " - @"(%A = 0)) AND (%A IN (%@)) AND (%A IS NULL)" - @"AND (((%A > %@) OR (%A = '%@')) AND " + @"(%A IN (%@))) AND " + @"(%A IN (%@)) AND " + @"(((%A > %@) OR (%A = '%@')) AND " @"(%A < %@)))", @"jobStatus", LSJobArchived, @"jobStatus", LSJobDone, @"creatorId", s, - @"isControlJob", @"isControlJob", @"executantId", s, - @"kind", @"endDate", formattedBegin, @"jobStatus", LSJobCreated, @"endDate", formattedEnd, nil]; @@ -134,16 +132,14 @@ else { qualifier = [qualifier initWithEntity:[self destinationEntity] qualifierFormat: - @"((%A <> '%@') AND ((%A <> '%@') OR " - @"(%A IN (%@))) AND ((%A IS NULL) OR " - @"(%A = 0)) AND (%A IN (%@)) AND " - @"(%A IS NULL))", + @"((%A <> '%@') AND " + @" ((%A <> '%@') OR(%A IN (%@))) AND " + @" (%A IN (%@)))", @"jobStatus", LSJobArchived, @"jobStatus", LSJobDone, @"creatorId", s, - @"isControlJob", @"isControlJob", @"executantId", s, - @"kind", nil]; + nil]; } return [qualifier autorelease]; } Index: GNUmakefile =================================================================== --- GNUmakefile (revision 2045) +++ GNUmakefile (working copy) @@ -10,12 +10,10 @@ LSTasks_OBJC_FILES = \ LSAllSubJobsDoneJobCommand.m \ LSAssignProjectToJobCommand.m \ - LSControlJobCommand.m \ LSDeleteJobCommand.m \ LSDeleteJobHistoryCommand.m \ LSDetachProjectFromJobCommand.m \ LSFetchArchivedJobsCommand.m \ - LSFetchControlJobsCommand.m \ LSFetchDelegatedJobsCommand.m \ LSFetchJobCommand.m \ LSFetchJobExecutantCommand.m \ @@ -26,7 +24,6 @@ LSFetchProjectToRootJobCommand.m \ LSFetchToDoJobsCommand.m \ LSFilterArchivedJobCommand.m \ - LSFilterControlJobCommand.m \ LSFilterDelegatedJobCommand.m \ LSFilterJobCommand.m \ LSFilterToDoListJobCommand.m \ Index: LSFetchProjectJobsCommand.m =================================================================== --- LSFetchProjectJobsCommand.m (revision 2045) +++ LSFetchProjectJobsCommand.m (working copy) @@ -64,16 +64,14 @@ initWithEntity:[self destinationEntity] qualifierFormat: @"((%A IS NOT NULL) AND (%A <> '%@') AND " - @"(%A <> '%@') AND ((%A IS NULL) OR (%A = 0)) " - @"OR ((%A = '%@') AND (%A = %A))) AND " - @"(%A IS NULL)", + @"(%A <> '%@') " + @"OR ((%A = '%@') AND (%A = %A)))" @"projectId", @"jobStatus", LSJobArchived, @"jobStatus", LSJobDone, - @"isControlJob", @"isControlJob", @"jobStatus", LSJobDone, @"creatorId", @"executantId", - @"kind", nil] autorelease]; + nil] autorelease]; return [self _checkConjoinWithQualifier:qualifier]; } Index: LSFetchJobsForExecutantCommand.m =================================================================== --- LSFetchJobsForExecutantCommand.m (revision 2045) +++ LSFetchJobsForExecutantCommand.m (working copy) @@ -78,13 +78,10 @@ qualifier = [[EOSQLQualifier allocWithZone:[self zone]] initWithEntity:[self destinationEntity] qualifierFormat: - @"((%A <> '%@') AND ((%A IS NULL) OR " - @"(%A = 0)) AND (%A IN (%@)) AND " - @"(%A IS NULL))", + @"((%A <> '%@') AND (%A IN (%@))", @"jobStatus", LSJobArchived, - @"isControlJob", @"isControlJob", @"executantId", s, - @"kind", nil]; + nil]; return AUTORELEASE(qualifier); } Index: commands.plist =================================================================== --- commands.plist (revision 2045) +++ commands.plist (working copy) @@ -7,7 +7,6 @@ new = { class = "LSNewJobCommand"; }; delete = { class = "LSDeleteJobCommand"; }; jobaction = { class = "LSJobActionCommand"; }; - controljob = { class = "LSControlJobCommand"; }; setcreator = { class = "LSDBFetchRelationCommand"; init = { @@ -79,14 +78,12 @@ init = { entity = "Job"; }; }; "filter-todolist" = { class = "LSFilterToDoListJobCommand"; }; - "filter-controljobs" = { class = "LSFilterControlJobCommand"; }; "filter-delegatedjobs" = { class = "LSFilterDelegatedJobCommand"; }; "filter-archivedjobs" = { class = "LSFilterArchivedJobCommand"; }; "getparentjobs" = { class = "LSGetParentJobsCommand"; }; "get-todo-jobs" = { class = "LSFetchToDoJobsCommand"; }; "get-private-jobs" = { class = "LSFetchPrivateJobsCommand"; }; "get-archived-jobs" = { class = "LSFetchArchivedJobsCommand"; }; - "get-control-jobs" = { class = "LSFetchControlJobsCommand"; }; "get-delegated-jobs" = { class = "LSFetchDelegatedJobsCommand"; }; "get-executant-jobs" = { class = "LSFetchJobsForExecutantCommand";}; "remove-waste-jobs" = { class = "LSRemoveWasteJobsCommand"; }; Index: bundle-info.plist =================================================================== --- bundle-info.plist (revision 2045) +++ bundle-info.plist (working copy) @@ -15,18 +15,15 @@ { name = "job::allsubjobs-done"; }, { name = "job::assign-to-project"; }, { name = "job::check-duration"; }, - { name = "job::controljob"; }, { name = "job::delete"; }, { name = "job::detach-from-project"; }, { name = "job::extended-search"; }, { name = "job::filter-archivedjobs"; }, - { name = "job::filter-controljobs"; }, { name = "job::filter-delegatedjobs"; }, { name = "job::filter-todolist"; }, { name = "job::get"; }, { name = "job::get-archived-jobs"; }, { name = "job::get-by-globalid"; }, - { name = "job::get-control-jobs"; }, { name = "job::get-delegated-jobs"; }, { name = "job::get-duration"; }, { name = "job::get-executant-jobs"; }, @@ -69,12 +66,10 @@ { name = LSTasksCommands; }, { name = LSAllSubJobsDoneJobCommand; }, { name = LSAssignProjectToJobCommand; }, - { name = LSControlJobCommand; }, { name = LSDeleteJobCommand; }, { name = LSDeleteJobHistoryCommand; }, { name = LSDetachProjectFromJobCommand; }, { name = LSFetchArchivedJobsCommand; }, - { name = LSFetchControlJobsCommand; }, { name = LSFetchDelegatedJobsCommand; }, { name = LSFetchJobCommand; }, { name = LSFetchJobExecutantCommand; }, @@ -85,7 +80,6 @@ { name = LSFetchProjectToRootJobCommand; }, { name = LSFetchToDoJobsCommand; }, { name = LSFilterArchivedJobCommand; }, - { name = LSFilterControlJobCommand; }, { name = LSFilterDelegatedJobCommand; }, { name = LSFilterJobCommand; }, { name = LSFilterToDoListJobCommand; }, Index: LSFetchDelegatedJobsCommand.m =================================================================== --- LSFetchDelegatedJobsCommand.m (revision 2045) +++ LSFetchDelegatedJobsCommand.m (working copy) @@ -37,13 +37,10 @@ qualifier = [[[EOSQLQualifier allocWithZone:[self zone]] initWithEntity:[self destinationEntity] qualifierFormat: - @"(%A <> '%@') AND " - @"((%A IS NULL) OR (%A = 0)) AND" - @"(%A <> %A) AND (%A IS NULL)", + @"(%A <> '%@') AND (%A <> %A)", @"jobStatus", LSJobArchived, - @"isControlJob", @"isControlJob", @"creatorId", @"executantId", - @"kind", nil] autorelease]; + nil] autorelease]; return [self _checkConjoinWithQualifier:qualifier]; } Index: LSFetchProjectToJobCommand.m =================================================================== --- LSFetchProjectToJobCommand.m (revision 2045) +++ LSFetchProjectToJobCommand.m (working copy) @@ -53,9 +53,7 @@ qualifier = [[EOSQLQualifier allocWithZone:[self zone]] initWithEntity:[self destinationEntity] - qualifierFormat: - @"((%A IS NULL) OR (%A = 0)) AND (%A IS NULL)", - @"isControlJob", @"isControlJob", @"kind", nil]; + qualifierFormat:@"(1 = 1)", nil]; [qualifier conjoinWithQualifier:[super _qualifier]]; return AUTORELEASE(qualifier); } Index: LSFilterDelegatedJobCommand.m =================================================================== --- LSFilterDelegatedJobCommand.m (revision 2045) +++ LSFilterDelegatedJobCommand.m (working copy) @@ -45,16 +45,9 @@ enumerator = [[self jobList] objectEnumerator]; while ((job = [enumerator nextObject])) { - BOOL isControlJob = NO; - id ctrlJob = nil; NSString *jobStatus = [job valueForKey:@"jobStatus"]; - ctrlJob = [job valueForKey:@"isControlJob"]; - if (ctrlJob != nil) { - isControlJob = [ctrlJob boolValue]; - } - if (!isControlJob && - ([[job valueForKey:@"creatorId"] isEqual:[self creatorId]]) && + if (([[job valueForKey:@"creatorId"] isEqual:[self creatorId]]) && (![jobStatus isEqualToString:LSJobArchived]) && (![jobStatus isEqualToString:LSJobDone])) { [filteredJobs addObject:job]; --=-fBcl5wBXhbMKLCTLpGBU-- From developer@opengroupware.org Mon Nov 5 23:20:19 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Mon, 05 Nov 2007 18:20:19 -0500 Subject: [OGo-Developer] Task & kind In-Reply-To: <7E2B8CAA-FFFC-4B22-BDED-EA31F8A95695@opengroupware.org> References: <1194281775.4909.30.camel@WM_ADAM1.morrison.iserv.net> <7E2B8CAA-FFFC-4B22-BDED-EA31F8A95695@opengroupware.org> Message-ID: <1194304819.4527.14.camel@aleph> > > It would be extremely useful to us to be able to designate a task > > type, > > but currently if we set this value the task completely vanishes > > both in > > the WebUI (which is OK, at least for us) and also via ZideStore / > > XML-RPC [ obviously, since the kind IS NULL constraint is in Logic ]. > Not sure what "kinds" you think of. Probably "keywords" is what we > want here? (and map that to iCal keywords?) We've used the task list to provide the users with a unified task list; now we've added specific types of tasks. The intranet displays tasks lists and the normal task information but it also looks at the kind of the task and displays additional fields based on the kind, those additional fields are then stored in properties. Intranet forms are also used to drive the creation of different kinds of tasks, making sure the creating user provides the necessary bits of information. We aren't using 'kind' as a human-readable value which I would think keywords should be. From developer@opengroupware.org Tue Nov 6 20:04:04 2007 From: developer@opengroupware.org (Helge Hess) Date: Tue, 6 Nov 2007 21:04:04 +0100 Subject: [OGo-Developer] Task & kind In-Reply-To: <1194303933.4527.2.camel@aleph> References: <1194281775.4909.30.camel@WM_ADAM1.morrison.iserv.net> <7E2B8CAA-FFFC-4B22-BDED-EA31F8A95695@opengroupware.org> <1194303933.4527.2.camel@aleph> Message-ID: <6F547A71-1705-448A-9F0A-3FC67E6C4B02@opengroupware.org> On 06.11.2007, at 00:05, Adam Tauno Williams wrote: > That is pretty much what I assumed. Anyway, I've plucked the > restriction out of at least the Logic bits, and so far.... by servers > are still chugging away. > > I've tested the task lists in webui (todo, delegated, archived) and > listing the tasks vi the project viewer. OK, I don't mind if you remove it. > We've used the task list to provide the users with a unified task > list; > now we've added specific types of tasks. The intranet displays tasks > lists and the normal task information but it also looks at the kind of > the task and displays additional fields based on the kind, those > additional fields are then stored in properties. Intranet forms are > also used to drive the creation of different kinds of tasks, making > sure > the creating user provides the necessary bits of information. > > We aren't using 'kind' as a human-readable value which I would think > keywords should be. Ack. Greets, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Wed Nov 14 11:44:43 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Wed, 14 Nov 2007 12:44:43 +0100 Subject: [OGo-Developer] bugfixes and enhancements for advanced document and contact/company searches Message-ID: <20071114114443.A50A3463EF@smtp.l00-bugdead-prods.de> Hi, I uploaded some patches a while ago to the bugzilla, one bug report, and two enhancements. The patch to this bug report would fix the save of AND/OR selector for contacts and company searches: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1920 The patch to this enhancement request would allow to create custom tabs for document searches within a project: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1919 everything is working here, but I have no idea how the custom tabs are filled with contents The patch to this enhancement would allow to create custom tabs for document searches across projects: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1921 here everything is working. The code may not be perfect, but if anybody could try these patches, and give some feedback, would be nice. Especially, I have no idea how to fix problem described for bug 1919. I spent hours to get contents into the tabs but noting worked so far. kind regards Sebastian From developer@opengroupware.org Wed Nov 14 13:53:16 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Nov 2007 08:53:16 -0500 Subject: [OGo-Developer] bugfixes and enhancements for advanced document and contact/company searches In-Reply-To: <20071114114443.A50A3463EF@smtp.l00-bugdead-prods.de> References: <20071114114443.A50A3463EF@smtp.l00-bugdead-prods.de> Message-ID: <1195048396.7125.2.camel@WM_ADAM1.morrison.iserv.net> --=-oJOmo9EoGCFU7/o4vldE Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > I uploaded some patches a while ago to the bugzilla, one bug report, and = two=20 > enhancements.=20 > The patch to this bug report would fix the save of AND/OR selector for > contacts and company searches: > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1920 > The patch to this enhancement request would allow to create custom > tabs for document searches within a project: > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1919 > everything is working here, but I have no idea how the custom tabs are=20 > filled with contents > The patch to this enhancement would allow to create custom tabs for=20 > document searches across projects: > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1921 > here everything is working. I'll take a look and test; although my knowledge is limited. > The code may not be perfect, but if anybody could try these patches, and=20 > give some feedback, would be nice. Especially, I have no idea how to fix=20 > problem described for bug 1919. I spent hours to get contents into the=20 > tabs but noting worked so far. Hey, same boat. I can't tell you how many hours I've spent trying to get contents to appear in a ZideStore folder. Ugh. --=-oJOmo9EoGCFU7/o4vldE Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBHOv3MLRePpNle04MRAvV/AJwNNZc3y2NjP91BEzvsSIrQ9gztTwCdFY5v sii7EqWNXwUFs/jFDOvIVh8= =OT63 -----END PGP SIGNATURE----- --=-oJOmo9EoGCFU7/o4vldE-- From developer@opengroupware.org Wed Nov 14 14:04:27 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Nov 2007 09:04:27 -0500 Subject: [OGo-Developer] bugfixes and enhancements for advanced document and contact/company searches In-Reply-To: <1195048396.7125.2.camel@WM_ADAM1.morrison.iserv.net> References: <20071114114443.A50A3463EF@smtp.l00-bugdead-prods.de> <1195048396.7125.2.camel@WM_ADAM1.morrison.iserv.net> Message-ID: <1195049067.7125.7.camel@WM_ADAM1.morrison.iserv.net> --=-W2hfEycY4Gm3ys7I3ksB Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2007-11-14 at 08:53 -0500, Adam Tauno Williams wrote: > > I uploaded some patches a while ago to the bugzilla, one bug report, an= d two=20 > > enhancements.=20 > > The patch to this bug report would fix the save of AND/OR selector for > > contacts and company searches: > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1920 > > The patch to this enhancement request would allow to create custom > > tabs for document searches within a project: > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1919 > > everything is working here, but I have no idea how the custom tabs are=20 > > filled with contents > > The patch to this enhancement would allow to create custom tabs for=20 > > document searches across projects: > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1921 > > here everything is working. > I'll take a look and test; although my knowledge is limited. As an aside, if you could find the time to write up a short document about developing in the webui - perhaps a short how-to-add-a-hello-world-module - I'd love to include something like that in WMOGAG, either as an addendum or I'd work it into a new chapter. Something like a step-by-step explanation of the stuff at http://www.opengroupware.org/en/devs/docs/snippets/WebUI/activation.html Since you create the Asterisk stuff, you've obviously figured some of it out. :) > > The code may not be perfect, but if anybody could try these patches, an= d=20 > > give some feedback, would be nice. Especially, I have no idea how to fi= x=20 > > problem described for bug 1919. I spent hours to get contents into the=20 > > tabs but noting worked so far. >=20 > Hey, same boat. I can't tell you how many hours I've spent trying to > get contents to appear in a ZideStore folder. Ugh. >=20 --=-W2hfEycY4Gm3ys7I3ksB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBHOwBrLRePpNle04MRAqeCAJ43y1ugHPtO36jUVpYZnT9duhUZSgCfTrGd Pong/3CIQkW3O+QxBRgwDPo= =riH1 -----END PGP SIGNATURE----- --=-W2hfEycY4Gm3ys7I3ksB-- From developer@opengroupware.org Wed Nov 14 14:48:37 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Wed, 14 Nov 2007 15:48:37 +0100 Subject: [OGo-Developer] bugfixes and enhancements for advanceddocument and contact/company searches Message-ID: <20071114144838.4B1A046480@smtp.l00-bugdead-prods.de> Hi, developer@opengroupware.org wrote: > > On Wed, 2007-11-14 at 08:53 -0500, Adam Tauno Williams wrote: > > > I uploaded some patches a while ago to the bugzilla, one bug report, and two > > > enhancements. > > > The patch to this bug report would fix the save of AND/OR selector for > > > contacts and company searches: > > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1920 > > > The patch to this enhancement request would allow to create custom > > > tabs for document searches within a project: > > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1919 > > > everything is working here, but I have no idea how the custom tabs are > > > filled with contents > > > The patch to this enhancement would allow to create custom tabs for > > > document searches across projects: > > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1921 > > > here everything is working. > > I'll take a look and test; although my knowledge is limited. > > As an aside, if you could find the time to write up a short document > about developing in the webui - perhaps a short > how-to-add-a-hello-world-module - I'd love to include something like > that in WMOGAG, either as an addendum or I'd work it into a new > chapter. Something like a step-by-step explanation of the stuff at > http://www.opengroupware.org/en/devs/docs/snippets/WebUI/activation.html > Since you create the Asterisk stuff, you've obviously figured some of it > out. :) Right now I am a bit busy porting linux-ha to OpenBSD, but I hope I get that right by the end of the month. But when I find the next time, I'll go do that. > > > > The code may not be perfect, but if anybody could try these patches, and > > > give some feedback, would be nice. Especially, I have no idea how to fix > > > problem described for bug 1919. I spent hours to get contents into the > > > tabs but noting worked so far. > > > > Hey, same boat. I can't tell you how many hours I've spent trying to > > get contents to appear in a ZideStore folder. Ugh. > > > Helge, maybe you could give us a hint on doing so? The document search over all projects, is implemented differently, and I have filled tabs. Or is there an example anywhere in the code where I it is implemented the same way? kind regards Sebastian From developer@opengroupware.org Wed Nov 14 16:51:05 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Nov 2007 11:51:05 -0500 Subject: [OGo-Developer] bugfixes and enhancements for advanceddocument and contact/company searches In-Reply-To: <20071114144838.4B1A046480@smtp.l00-bugdead-prods.de> References: <20071114144838.4B1A046480@smtp.l00-bugdead-prods.de> Message-ID: <1195059065.7125.12.camel@WM_ADAM1.morrison.iserv.net> --=-gbykmKmZ8xyhPpO8oUbd Content-Type: text/plain Content-Transfer-Encoding: quoted-printable > > > > I uploaded some patches a while ago to the bugzilla, one bug report= ,=20 > and two=20 > > > > enhancements.=20 > > > > The patch to this bug report would fix the save of AND/OR selector = for > > > > contacts and company searches: > > > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1920 > > > > The patch to this enhancement request would allow to create custom > > > > tabs for document searches within a project: > > > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1919 > > > > everything is working here, but I have no idea how the custom tabs = are=20 > > > > filled with contents > > > > The patch to this enhancement would allow to create custom tabs for= =20 > > > > document searches across projects: > > > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1921 > > > > here everything is working. > > > I'll take a look and test; although my knowledge is limited. > >=20 > > As an aside, if you could find the time to write up a short document > > about developing in the webui - perhaps a short > > how-to-add-a-hello-world-module - I'd love to include something like > > that in WMOGAG, either as an addendum or I'd work it into a new > > chapter. Something like a step-by-step explanation of the stuff at > > http://www.opengroupware.org/en/devs/docs/snippets/WebUI/activation.htm= l > > Since you create the Asterisk stuff, you've obviously figured some of i= t > > out. :) > Right now I am a bit busy porting linux-ha to OpenBSD, but I hope I get t= hat=20 > right by the end of the month. But when I find the next time, I'll go do=20 > that. Doesn't have to pretty, spelled correctly, etc... I'll do what ever beautification is necessary. --=-gbykmKmZ8xyhPpO8oUbd Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBHOyd5LRePpNle04MRAsKeAJ0dN/qweVkRlCuo99r7dKQVU5CdYwCfUznh dxWPN5it+iZJ02hFQSALVIY= =BqBn -----END PGP SIGNATURE----- --=-gbykmKmZ8xyhPpO8oUbd-- From developer@opengroupware.org Wed Nov 14 16:56:35 2007 From: developer@opengroupware.org (Helge Hess) Date: Wed, 14 Nov 2007 17:56:35 +0100 Subject: [OGo-Developer] bugfixes and enhancements for advanced document and contact/company searches In-Reply-To: <1195049067.7125.7.camel@WM_ADAM1.morrison.iserv.net> References: <20071114114443.A50A3463EF@smtp.l00-bugdead-prods.de> <1195048396.7125.2.camel@WM_ADAM1.morrison.iserv.net> <1195049067.7125.7.camel@WM_ADAM1.morrison.iserv.net> Message-ID: <17F75B05-0286-4C87-ACB6-3D3D4A5F09BB@opengroupware.org> On 14.11.2007, at 15:04, Adam Tauno Williams wrote: > As an aside, if you could find the time to write up a short document > about developing in the webui - perhaps a short > how-to-add-a-hello-world-module - I'd love to include something like > that in WMOGAG, either as an addendum or I'd work it into a new > chapter. http://svn.opengroupware.org/viewcvs/trunk/Misc/HelloWorld/ There is also HelloDB. Not a tutorial, but not too hard to understand either? Thanks, Helge From developer@opengroupware.org Wed Nov 14 16:59:04 2007 From: developer@opengroupware.org (Helge Hess) Date: Wed, 14 Nov 2007 17:59:04 +0100 Subject: [OGo-Developer] bugfixes and enhancements for advanceddocument and contact/company searches In-Reply-To: <20071114144838.4B1A046480@smtp.l00-bugdead-prods.de> References: <20071114144838.4B1A046480@smtp.l00-bugdead-prods.de> Message-ID: <868FC175-2E4F-4892-9DCE-BB04E2942382@opengroupware.org> On 14.11.2007, at 15:48, Sebastian Reitenbach wrote: > Helge, maybe you could give us a hint on doing so? The document > search over > all projects, is implemented differently, and I have filled tabs. > Or is > there an example anywhere in the code where I it is implemented the > same > way? Not sure what you want to know. I guess I shall write it for you? :-) Unfortunately I don't have the time to do this currently. Greets, Helge From developer@opengroupware.org Wed Nov 14 17:08:03 2007 From: developer@opengroupware.org (Reza Atai) Date: Wed, 14 Nov 2007 18:08:03 +0100 Subject: [OGo-Developer] unsubscribe In-Reply-To: <868FC175-2E4F-4892-9DCE-BB04E2942382@opengroupware.org> References: <20071114144838.4B1A046480@smtp.l00-bugdead-prods.de> <868FC175-2E4F-4892-9DCE-BB04E2942382@opengroupware.org> Message-ID: <000f01c826e0$eaecdae0$8d02a8c0@servermaster.local> Please unsubscribe me! Thanks -----Ursprüngliche Nachricht----- Von: developer-admin@opengroupware.org [mailto:developer-admin@opengroupware.org] Im Auftrag von Helge Hess Gesendet: Mittwoch, 14. November 2007 17:59 An: developer@opengroupware.org Betreff: Re: [OGo-Developer] bugfixes and enhancements for advanceddocument and contact/company searches On 14.11.2007, at 15:48, Sebastian Reitenbach wrote: > Helge, maybe you could give us a hint on doing so? The document > search over > all projects, is implemented differently, and I have filled tabs. > Or is > there an example anywhere in the code where I it is implemented the > same > way? Not sure what you want to know. I guess I shall write it for you? :-) Unfortunately I don't have the time to do this currently. Greets, Helge -- OpenGroupware.org Developer developer@opengroupware.org http://mail.opengroupware.org/mailman/listinfo/developer ____________ Virus checked by G DATA AntiVirusKit From developer@opengroupware.org Wed Nov 14 18:24:42 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Wed, 14 Nov 2007 19:24:42 +0100 Subject: [OGo-Developer] bugfixes and enhancements for advanceddocument and contact/company searches Message-ID: <20071114182443.1BD8D46505@smtp.l00-bugdead-prods.de> Hi, developer@opengroupware.org wrote: > On 14.11.2007, at 15:48, Sebastian Reitenbach wrote: > > Helge, maybe you could give us a hint on doing so? The document > > search over > > all projects, is implemented differently, and I have filled tabs. > > Or is > > there an example anywhere in the code where I it is implemented the > > same > > way? > > Not sure what you want to know. I guess I shall write it for you? :-) > Unfortunately I don't have the time to do this currently. thats a pity, but the problem is here: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1919 when you apply this patch. Then create a custom tab, based on the document search within a project. Then you click on the tab, but the tab has no contents, I do not get it to show the result of the search. A month or two ago I asked how this could be solved, and you gave me a little hint. Nevertheless, that did not got me any step forward, I tried different things but nothing worked. I've no idea anymore what to do, but would like to have that going :( sebastian > > Greets, > Helge > -- > OpenGroupware.org Developer > developer@opengroupware.org > http://mail.opengroupware.org/mailman/listinfo/developer > From developer@opengroupware.org Thu Nov 15 03:01:30 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Nov 2007 22:01:30 -0500 Subject: [OGo-Developer] bugfixes and enhancements for advanced document and contact/company searches In-Reply-To: <20071114114443.A50A3463EF@smtp.l00-bugdead-prods.de> References: <20071114114443.A50A3463EF@smtp.l00-bugdead-prods.de> Message-ID: <1195095690.5009.0.camel@aleph.morrison.iserv.net> On Wed, 2007-11-14 at 12:44 +0100, Sebastian Reitenbach wrote: > I uploaded some patches a while ago to the bugzilla, one bug report, and two > enhancements. > The patch to this bug report would fix the save of AND/OR selector for > contacts and company searches: > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1920 Committed in r2049. From developer@opengroupware.org Thu Nov 15 03:55:40 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Wed, 14 Nov 2007 22:55:40 -0500 Subject: [OGo-Developer] Task & kind In-Reply-To: <6F547A71-1705-448A-9F0A-3FC67E6C4B02@opengroupware.org> References: <1194281775.4909.30.camel@WM_ADAM1.morrison.iserv.net> <7E2B8CAA-FFFC-4B22-BDED-EA31F8A95695@opengroupware.org> <1194303933.4527.2.camel@aleph> <6F547A71-1705-448A-9F0A-3FC67E6C4B02@opengroupware.org> Message-ID: <1195098940.5009.2.camel@aleph.morrison.iserv.net> On Tue, 2007-11-06 at 21:04 +0100, Helge Hess wrote: > On 06.11.2007, at 00:05, Adam Tauno Williams wrote: > > That is pretty much what I assumed. Anyway, I've plucked the > > restriction out of at least the Logic bits, and so far.... by servers > > are still chugging away. > > I've tested the task lists in webui (todo, delegated, archived) and > > listing the tasks vi the project viewer. > OK, I don't mind if you remove it. Committed in r2051 From developer@opengroupware.org Thu Nov 15 06:04:15 2007 From: developer@opengroupware.org (Sebastian Reitenbach) Date: Thu, 15 Nov 2007 07:04:15 +0100 Subject: [OGo-Developer] bugfixes and enhancements for advanceddocument and contact/company searches Message-ID: <20071115060416.4E88646633@smtp.l00-bugdead-prods.de> developer@opengroupware.org wrote: > > On Wed, 2007-11-14 at 12:44 +0100, Sebastian Reitenbach wrote: > > I uploaded some patches a while ago to the bugzilla, one bug report, and two > > enhancements. > > The patch to this bug report would fix the save of AND/OR selector for > > contacts and company searches: > > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1920 > > Committed in r2049. thank you. Sebastian From developer@opengroupware.org Fri Nov 16 19:36:48 2007 From: developer@opengroupware.org (Adam Tauno Williams) Date: Fri, 16 Nov 2007 14:36:48 -0500 Subject: [OGo-Developer] task::qsearch & acccess Message-ID: <1195241808.10191.1.camel@WM_ADAM1.morrison.iserv.net> --=-9ECYja3TvntbItEHkYUn Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I've created a "job::qsearch" command like the "person::qsearch" and "enterprise::qsearch"; as LSQualifierSearchTaskCommand descended from LSQualifierSearchCommand. That was actually pretty easy. :) This is really useful to us since we use the task application as a knowledge base. The search capabilty regarding tasks in the mainline is really primitive. Also made a tool "ogo-qsearch-tasks" to test it. Two questions - (A) Is this something that can be committed to the mainline? (B) Of course jobs provide no access control, ergo... <0x0x8456c7c[SkyAccessManager]> found no access handler for entity Job GID <0x0x84b4b0c[EOKeyGlobalID]: Job 10502400>: {} ... in the logs. And this presents a problem as using just the todo/delegated/archived lists a user can't weasel into someone else's tasks. If (A) then is creating a OGoTaskAccessHandler object for use by the OGoAccessManager in the Tasks bundle acceptable? =20 - Access provided if user is the creator or executor (incl. executor via team) - Access provided if task is assigned to a project to which the user has "r" access. Currently task::qsearch only searches the task's core information. Down the line I want to search annotations, and possibly properties, like qsearch does with the addresses / telephones / company values of contacts and enterprises. Still hacking on that. --=-9ECYja3TvntbItEHkYUn Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBHPfFQLRePpNle04MRAuVHAJ9yIyvZEX6wHRE0zgQJlpCBqk/62gCeNK1e S0OLtjrj1uYcshKKiDb7F98= =C9H2 -----END PGP SIGNATURE----- --=-9ECYja3TvntbItEHkYUn-- From developer@opengroupware.org Fri Nov 16 23:59:02 2007 From: developer@opengroupware.org (Helge Hess) Date: Sat, 17 Nov 2007 00:59:02 +0100 Subject: [OGo-Developer] task::qsearch & acccess In-Reply-To: <1195241808.10191.1.camel@WM_ADAM1.morrison.iserv.net> References: <1195241808.10191.1.camel@WM_ADAM1.morrison.iserv.net> Message-ID: <4B8AB985-44D9-4D20-BFBC-F12A237B4EA0@opengroupware.org> On 16.11.2007, at 20:36, Adam Tauno Williams wrote: > I've created a "job::qsearch" command like the "person::qsearch" and > "enterprise::qsearch"; as LSQualifierSearchTaskCommand descended from > LSQualifierSearchCommand. That was actually pretty easy. :) > This is > really useful to us since we use the task application as a knowledge > base. The search capabilty regarding tasks in the mainline is really > primitive. ... > (A) Is this something that can be committed to the mainline? Sure why not, doesn't hurt anything else? > (B) Of course jobs provide no access control, ergo... Hm ... > <0x0x8456c7c[SkyAccessManager]> found no access handler for entity Job > GID <0x0x84b4b0c[EOKeyGlobalID]: Job 10502400>: {} Thats just a warning. I thought I removed in in HEAD, but apparently not. > ... in the logs. And this presents a problem as using just the > todo/delegated/archived lists a user can't weasel into someone else's > tasks. Hm, yes, probably. > If (A) then is creating a OGoTaskAccessHandler object for use by the > OGoAccessManager in the Tasks bundle acceptable? Sure. > - Access provided if user is the creator or executor (incl. executor > via team) > - Access provided if task is assigned to a project to which the user > has "r" access. Sounds good. We sometimes (events?) also do 'l' access which just means that the user can see the thing but has no full access. > Currently task::qsearch only searches the task's core information. > Down > the line I want to search annotations, Job annotations are in the database or in the FS? > and possibly properties, Si. Sounds good! Thanks, Helge -- Helge Hess http://www.helgehess.eu/ From developer@opengroupware.org Sat Nov 17 20:59:37 2007 From: developer@opengroupware.org (Lars Schimmer) Date: Sat, 17 Nov 2007 21:59:37 +0100 Subject: [OGo-Developer] [Fwd: Re: Lightning daily built 30.9.2007 & OpenGroupware.org & CalDav] Message-ID: <473F5639.8050901@cgv.tugraz.at> This is a multi-part message in MIME format. --------------010209050300070100070805 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi! I created a test OGo server SVN built 1 week ago for the lightning dev team. That email came back from them. Should I create a bugentry in bugzilla or is anyone of OGo dev team carry on from this point ? MfG, Lars Schimmer - -- - ------------------------------------------------------------- TU Graz, Institut für ComputerGraphik & WissensVisualisierung Tel: +43 316 873-5405 E-Mail: l.schimmer@cgv.tugraz.at Fax: +43 316 873-5402 PGP-Key-ID: 0x4A9B1723 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHP1Y4mWhuE0qbFyMRAntNAJ436MJMZTvzFgkobs0p5N9Ez9xU4ACeOIoJ HS+nZaovFAa4P9aPmWJGsRw= =in59 -----END PGP SIGNATURE----- --------------010209050300070100070805 Content-Type: message/rfc822; name="Re: Lightning daily built 30.9.2007 & OpenGroupware.org & CalDav.eml" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="Re: Lightning daily built 30.9.2007 & OpenGroupware.org & Ca"; filename*1="lDav.eml" Return-Path: Received: from europa.cgv.tugraz.at (localhost [127.0.0.1]) by europa.cgv.tugraz.at (Cyrus v2.1.18-IPv6-Debian-2.1.18-1+sarge2) with LMTP; Sat, 17 Nov 2007 20:21:07 +0100 X-Sieve: CMU Sieve 2.2 Received: from mailgate.tu-graz.ac.at ([129.27.2.200] helo=mailgate.tugraz.at) by europa.cgv.tugraz.at with esmtp (Exim 4.50) id 1ItTDt-0004Z7-Jq for l.schimmer@cgv.tugraz.at; Sat, 17 Nov 2007 20:21:07 +0100 Received: from agogare.doit.wisc.edu (agogare.doit.wisc.edu [144.92.197.211]) by mailgate2.tugraz.at (8.14.2/8.14.2) with ESMTP id lAHJKj4c001710 for ; Sat, 17 Nov 2007 20:20:52 +0100 (CET) Received: from avs-daemon.smtpauth2.wiscmail.wisc.edu by smtpauth2.wiscmail.wisc.edu (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JRO007010EKEH00@smtpauth2.wiscmail.wisc.edu> for l.schimmer@cgv.tugraz.at; Sat, 17 Nov 2007 13:20:44 -0600 (CST) Received: from [192.168.1.30] (24-183-101-240.dhcp.mdsn.wi.charter.com [24.183.101.240]) by smtpauth2.wiscmail.wisc.edu (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPA id <0JRO006ZR0ECB900@smtpauth2.wiscmail.wisc.edu> for l.schimmer@cgv.tugraz.at; Sat, 17 Nov 2007 13:20:43 -0600 (CST) Date: Sat, 17 Nov 2007 13:20:36 -0600 From: Bruno Browning In-reply-to: <4735F2EB.6050505@cgv.tugraz.at> To: Lars Schimmer Reply-to: browning@uwalumni.com Message-id: <473F3F04.4020308@uwalumni.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed References: <8cCdnf5LOpgeRpnanZ2dnUVZ_smnnZ2d@mozilla.org> <470856C8.7090301@uwalumni.com> <4735F2EB.6050505@cgv.tugraz.at> User-Agent: Thunderbird 2.0.0.6 (X11/20071022) X-Scanned-By: MIMEDefang 2.63 on 129.27.10.3 X-Scanned-By: milter-sender/1.15.914 .914 (mailgate2 [129.27.10.3]); Sat, 17 Nov 2007 20:20:52 +0100 X-TUGAntiSpamFlag: ham Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mailgate2.tugraz.at id lAHJKj4c001710 X-Spam-Stars: X-Spam-Status: No, score=0.3 required=6.0 tests=BAYES_50,FORGED_RCVD_HELO, NORMAL_HTTP_TO_IP,UNPARSEABLE_RELAY autolearn=no version=3.1.7 Subject: Re: Lightning daily built 30.9.2007 & OpenGroupware.org & CalDav Hi Lars-- Thanks for doing this. I've done a small amount of testing, and things=20 look fairly good with the Sunbird 0.7 release code: I can add, modify,=20 delete items. Things are not looking so good, however, with newer code: I see problems=20 that simply break interop. First two things I've noticed: 1) When I PUT a new resource into the store (using an 'If-None-Match: *'=20 header), I get a response of 200 Success. The way I read the RFC, and=20 the way the code is written, the response should be 201 Created if the=20 resource being PUT did not previously exist, and 200 Success if the=20 resource did previously exist and has been successfully=20 overwritten/modified. So Sunbird will consider a 200 on PUTting a new=20 resource as an error (probable name collision). 2) In order to minimize wire traffic, Sunbird is going to start to cache=20 item etags, so that when it needs to do a calendar query it can first=20 fetch only etags and second fetch new or changed items with a multiget,=20 pretty much as described in paragraph 8.2.1.3 of the spec. OGo does not=20 seem to support that initial query, which pretty much spoils=20 the party. I don't know where to report such issues, and hope I can do so through yo= u. I very much appreciate access to the server, and will try to include OGo=20 as I test future Mozilla calendar CalDAV patches. Regards, bb Lars Schimmer wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Bruno Browning wrote: > =20 >> Hi Lars-- >> >> I'm probably the developer most familiar with Sunbird/Lighning CalDAV >> support. I don't know specifically about the issues you mention, but y= ou >> are right: it's been difficult to deal with Lightning<-->OGo/CalDAV >> issues for lack of an OGo server to test against. If you could provide >> access to a test server that would be a help. Appreciate the offer. >> =20 > > Hi! > > First: sorry, had to much load and work to be done on other tracks, and > some bugs in OGo and system stopped me sometimes... > Now a special ogo is on and running. > URL: > http://129.27.224.217/OpenGroupware > user: test > pwd: 123456 > > Til yet NO data in OGo, just some users and groups. > And email not working, If you need emailing function out of OGo, contac= t > me. > > The CalDAV url will be like: > http://129.27.224.217/zidestore/dav/test/Calendar/ > for personal calendar > and: > http://129.27.224.217/zidestore/dav/test/Groups/all%20intranet/Calendar= / > for team/Group calendars. > > For other users: replace "test" with username. > For other groups: replace "all%20intranet" with the groupname. > > > Under http://129.27.224.217/zidestore/so/USERNAME/ > you see the zidestore server which provides ICS files and which handles > the CalDAV (which is NOT noted on that site). > The site needs auth via user/passwd. > > More users - password: > alice - alice1 > bob - bob1 > master - master1 > hugo - hugo1 > > groups - members: > sales - alice, test, hugo > coders - test, master, bob > loosers - alice, bob > winners - master, hugo, test > > private calendar URLs: > http://129.27.224.217/zidestore/dav/test/Calendar/ > http://129.27.224.217/zidestore/dav/hugo/Calendar/ > http://129.27.224.217/zidestore/dav/bob/Calendar/ > http://129.27.224.217/zidestore/dav/alice/Calendar/ > http://129.27.224.217/zidestore/dav/master/Calendar/ > > Group URLs: > http://129.27.224.217/zidestore/dav/test/Groups/all%20intranet/Calendar= / > http://129.27.224.217/zidestore/dav/test/Groups/sales/Calendar/ > http://129.27.224.217/zidestore/dav/test/Groups/coders/Calendar/ > http://129.27.224.217/zidestore/dav/test/Groups/loosers/Calendar/ > http://129.27.224.217/zidestore/dav/test/Groups/winners/Calendar/ > > > I hope you can test a lot with this setup - its not the fastest, but it= s > working. > If you need some help, new users, info, ask me :-) > > =20 >> bb >> =20 > > P.S.: the most annoying problem we got is: whole day function is not > working well and all entrys set with lightning are shifted 1 hour in > future (e.g. I enter 8:00, ogo writes 9:00 into database). > > MfG, > Lars Schimmer > - -- > - ------------------------------------------------------------- > TU Graz, Institut f=FCr ComputerGraphik & WissensVisualisierung > Tel: +43 316 873-5405 E-Mail: l.schimmer@cgv.tugraz.at > Fax: +43 316 873-5402 PGP-Key-ID: 0x4A9B1723 > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.7 (MingW32) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFHNfLqmWhuE0qbFyMRAt7wAJ0Zs2TQhroMlKQaaj5pfyNJDyalggCcDwj5 > poXle/jw5KAdI7aw1qRIhs4=3D > =3Dr6Zs > -----END PGP SIGNATURE----- > > =20 --------------010209050300070100070805-- From developer@opengroupware.org Sun Nov 18 01:06:08 2007 From: developer@opengroupware.org (Helge Hess) Date: Sun, 18 Nov 2007 02:06:08 +0100 Subject: [OGo-Developer] [Fwd: Re: Lightning daily built 30.9.2007 & OpenGroupware.org & CalDav] In-Reply-To: <473F5639.8050901@cgv.tugraz.at> References: <473F5639.8050901@cgv.tugraz.at> Message-ID: On 17.11.2007, at 21:59, Lars Schimmer wrote: > 1) When I PUT a new resource into the store (using an 'If-None- > Match: *' header), I get a response of 200 Success. The way I read > the RFC, and the way the code is written, the response should be > 201 Created if the resource being PUT did not previously exist, and > 200 Success if the resource did previously exist and has been > successfully overwritten/modified. So Sunbird will consider a 200 > on PUTting a new resource as an error (probable name collision). 2xx class codes all denote successfull storage, a 201 Created is certainly not required (nor widely implemented) for created items (though it makes sense [I think the difference is that 200 is supposed to contain a response body, but anyways]). However the reasoning is incorrect in the first place, if there is an 'if-none-match: *' it can *never* exist before. If it would, a 412 status would be the result, never a 2xx. And even if the 200 would imply that the resource did exist before, what then?? The old resource would have been overwritten! [havoc!!!] So the behaviour seems unreasonable. Summary: 201 would be nice, 200 is perfectly OK and checking for 200 vs 201 in the context of if-none-match is definitely wrong (if the server says 2xx the request definitely did succeed!). => OGo Enhancement (201 would be nice), Sunbird Bug (412 to ensure creations) > 2) In order to minimize wire traffic, Sunbird is going to start to > cache item etags, so that when it needs to do a calendar query it > can first fetch only etags and second fetch new or changed items > with a multiget, pretty much as described in paragraph 8.2.1.3 of > the spec. OGo does not seem to support that initial > query, which pretty much spoils the party. > > I don't know where to report such issues, and hope I can do so > through you. > > I very much appreciate access to the server, and will try to > include OGo as I test future Mozilla calendar CalDAV patches. Correct. OGo does not really support CalDAV REPORT requests (yet). But it would be nice if Sunbird could fallback to multiple GETs if multiget is unavailable (CalDAV vs GroupDAV). Thats not really hard and enables plain WebDAV servers as backends (certainly a viable goal!). Summary: missing CalDAV support in OGo, required REPORTs needs to be added. Would be nice if Sunbird would perform reasonable fallbacks to plain WebDAV. Thanks, Helge -- Helge Hess http://www.helgehess.eu/