[OGo-Developer] Javascript for ObjC (or "test that your code build!")

Wolfgang Sourdeau developer@opengroupware.org
Tue, 05 Feb 2008 10:15:41 -0500


Hi,


In sope-appserver/NGObjWeb/DynamicElements/ WOComplexHyperlink.m, line 385, we have the following lines:

  if (r.length > 0 && [ s characterAtIndex:0] =3D=3D '#')
    return false;

Unless the person who did this is using an obscure experimental bridge for Javascript and Objective C, this is erroneous and you should replace "false" with "NO"...

This just proves you didn't even bother to try to build your code before committing, which is very bad....
-- 
Wolfgang Sourdeau
T: +1 514 989-2000 ext. 2602 C: +1 514 755-3520

AVIS - Ce courriel pourrait contenir des renseignements confidentiels ou
privil=C3=A9gi=C3=A9s. Si vous n'en =C3=AAtes pas le v=C3=A9ritable destinataire, veuillez nous
aviser imm=C3=A9diatement. Merci.
NOTICE - This e-mail may contain confidential or privileged information.
If you are not the intended recipient, please notify us immediately. Thank you.