[OGo-Developer] Javascript for ObjC (or "test that your code build!")
Helge Hess
developer@opengroupware.org
Tue, 5 Feb 2008 16:26:11 +0100
On 05.02.2008, at 16:15, Wolfgang Sourdeau wrote:
> In sope-appserver/NGObjWeb/DynamicElements/ WOComplexHyperlink.m,
> line 385, we have the following lines:
>
> if (r.length > 0 && [ s characterAtIndex:0] == '#')
> return false;
>
> Unless the person who did this is using an obscure experimental
> bridge for Javascript and Objective C, this is erroneous and you
> should replace "false" with "NO"...
>
> This just proves you didn't even bother to try to build your code
> before committing, which is very bad....
Hu? Actually 'false' is regular C99 alias and of course I always build
code before a commit.
You could at least bother Google before blaming people ;-)
Anyways, 'NO' is still better for oldskool environments, I'll change it.
Thanks,
Helge
--
Helge Hess
http://www.helgehess.eu/