[OGo-Developer] Was: OGoAddressMapLink

[Sebastian Reitenbach]

Hi,
developer@opengroupware.org wrote: 
> developer@opengroupware.org wrote: 
> > > > I took a look at SkyExternalLink and added the functionality to 
> > > > OGoAddressMapLink. Also the SkyExternalLinkAction Default is 
honored.
> > > > In the end it turned out easier than expected ;)
> > > > I updated the tarball and page in the docs plone:
> > > 
> 
http://docs.opengroupware.org/Members/buzzdee/OGo%20AddOns/OGoAddressMapLink/document_view

> 
> > > ping!
> > > Anything else to be done to get this into svn?
> > 
> > Did you file it as a bug#+patch?  Also,  just glancing at the doc plone
> not yet, at least I don't think so.
> > page.  I think the template should have a conditional so that the map
> > link is only shown if the OGoAddressMapLink has been defined.
> > 
> > -  <#AddressTitle><#Buttons/>
> > +  <#AddressTitle><#MapLink/><#Buttons/>
> >    <#AddressViewer/>
> > 
> > ... becomes ...
> > 
> > -  <#AddressTitle><#Buttons/>
> > +  <#AddressTitle><#IfMapLink><#MapLink/></#IfMapLink><#Buttons/>
> >    <#AddressViewer/>
> > 
> I'll change this, and if I do not yet have a bug report created, I'll do 
and 
> upload there.
an entry in bugzilla is created:
http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1955

I've done it in an a bit different way. I made the MapLink itself a bit 
smarter. When two or more parameters given to it have a length > 0 then the 
icon and the link appears, otherwise not. Otherwise, the pages that embed 
the OGoAddressMapLink must provide a reasonable condition value somewhere, 
for the IfMapLink. I hope that makes it easier to embed the link into 
existing pages, as for example I haven't found something reasonable to user 
for IfMapLink in LSWAddressViewer.m. 

cheers
Sebastian