[OGo-Developer] Notes & Deleted projects (Bug#1976)

[Adam Tauno Williams]

<http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1976>

Currently OGo is pretty sloppy about deletes and leaves behind a fair
amount of detritus.

In relation to appointments, notes, and projects.

When an appointment is deleted, if there are any notes attached to it
they are unlinked.  The appointment is gone.

When a project is deleted, if there are any notes attached to it they
are not unlinked.

That would seem like a straight-forward bug, except...
If you see an appointment via-a-note in the project editor and you click
on the appointment - if the appointment has been deleted you get an
error.
If you see a project via-a-note in the appointment editor and the
project no longer exists the project link icon is x-ed out and not a
link.

The later seems weird to me.  If a project is deleted can we just unlink
the notes like we do when an appointment is deleted?  

This x-project icon that doesn't go anywhere doesn't make much sense to
me.

If both sides (project & appointment) unlink when they are deleted then
if project_id = NULL and date_id = NULL we can delete the note as well
(from db & filesystem).  Currently it appears that notes always remain
in the filesystem.