From bjoern@opengroupware.org Mon Jul 14 20:06:13 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id B35FE18F52C for ; Mon, 14 Jul 2003 20:06:13 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 19334-06 for ; Mon, 14 Jul 2003 20:06:13 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 1B8B918F51E for ; Mon, 14 Jul 2003 20:06:13 +0200 (CEST) Received: from grobi.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id 83559C9FFE for ; Mon, 14 Jul 2003 20:14:59 +0200 (CEST) Received: from opengroupware.org (localhost [127.0.0.1]) by grobi.in.skyrix.com (Postfix on Debian GNU/Linux) with ESMTP id 10FB87AD42 for ; Mon, 14 Jul 2003 20:16:03 +0200 (CEST) Message-ID: <3F12F363.8000203@opengroupware.org> Date: Mon, 14 Jul 2003 20:16:03 +0200 From: Bjoern Stierand Organization: OpenGroupware.org (www.opengroupware.org) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030708 Thunderbird/0.1a X-Accept-Language: en-us, en MIME-Version: 1.0 To: gnustep-port@opengroupware.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Administrativa Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Please ignore this message Bjoern -- http://www.opengroupware.org From mechanix@slider.rack66.net Tue Jul 15 00:34:16 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 97C3718F533 for ; Tue, 15 Jul 2003 00:34:16 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 20753-05 for ; Tue, 15 Jul 2003 00:34:15 +0200 (CEST) Received: from slider.rack66.net (slider.rack66.net [212.3.252.135]) by mail.opengroupware.org (Postfix) with ESMTP id C73C518F51B for ; Tue, 15 Jul 2003 00:34:15 +0200 (CEST) Received: by slider.rack66.net (Postfix, from userid 1026) id 6F865F075; Tue, 15 Jul 2003 00:38:20 +0200 (CEST) Date: Tue, 15 Jul 2003 00:38:20 +0200 From: Filip Van Raemdonck To: gnustep-port@opengroupware.org Message-ID: <20030714223820.GA17438@debian> Mail-Followup-To: gnustep-port@opengroupware.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] GNUstep define Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Hi, I assume this list is about building OpenGroupware.org with "regular" GNUstep environment instead of the one in ThirdParty? I've been trying to do that last friday, and this evening. I've had to make a few changes here and there, especially about including certain header files or not including them - mostly about Foundation Extensions. Now currently I'm using #if(n)def GNUSTEP to mark such changes; however AFAICT that is defined by NGExtensions which is from OGo and not GNUstep which makes it a chicken and egg problem while building NGExtensions itself (I just removed or altered conflicting code blocks there) and also requires the NGExtensions to be included to actually work. Since my knowledge of GNUstep is not all too extensive, does anyone with a better knowledge of it than me know of a #define which is GNUstep specific? Regards, Filip -- War does not prove who is right, it proves who is left. From nicola@brainstorm.co.uk Tue Jul 15 09:32:32 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 9AE4718F5A3 for ; Tue, 15 Jul 2003 09:32:32 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 29865-03 for ; Tue, 15 Jul 2003 09:32:31 +0200 (CEST) Received: from mail.brainstorm.co.uk (smtp.brainstorm.co.uk [217.169.5.196]) by mail.opengroupware.org (Postfix) with ESMTP id 7690D18F566 for ; Tue, 15 Jul 2003 09:32:31 +0200 (CEST) Received: from nicola.brainstorm.co.uk (IDENT:x9K8UzwehfV5ljYeMleUsCDBORmD0vUb@nicola.brainstorm.co.uk [192.168.4.138]) by mail.brainstorm.co.uk (8.11.4/8.11.4) with ESMTP id h6F7aZO02586; Tue, 15 Jul 2003 08:36:35 +0100 Date: Tue, 15 Jul 2003 08:40:34 +0100 (BST) From: Nicola Pero To: Filip Van Raemdonck Cc: gnustep-port@opengroupware.org Subject: Re: [OGo-GNUstep-Port] GNUstep define In-Reply-To: <20030714223820.GA17438@debian> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Tue, 15 Jul 2003, Filip Van Raemdonck wrote: > Hi, > > I assume this list is about building OpenGroupware.org with "regular" > GNUstep environment instead of the one in ThirdParty? > > I've been trying to do that last friday, and this evening. I've had to > make a few changes here and there, especially about including certain > header files or not including them - mostly about Foundation Extensions. > Now currently I'm using #if(n)def GNUSTEP to mark such changes; however > AFAICT that is defined by NGExtensions which is from OGo and not GNUstep > which makes it a chicken and egg problem while building NGExtensions > itself (I just removed or altered conflicting code blocks there) and also > requires the NGExtensions to be included to actually work. > > Since my knowledge of GNUstep is not all too extensive, does anyone with a > better knowledge of it than me know of a #define which is GNUstep specific? There seems to be some confusion here. GNUSTEP *is* a GNUstep specific #define. :-) The theory is that GNUSTEP is a GNUstep specific #define, and is #defined by gnustep-base to let the code know that gnustep-base is being used (check core/base/base.make). Which makes sense after all. It's unfortunate that NGExtensions/common.h is #defining GNUSTEP too. Maybe it was used in the past if the software was built without gnustep-make, to make a difference between the two ? Anyway, I suggest renaming that #define to something else as a start, to prevent conflicts. I can't really change the #define of GNUSTEP inside gnustep-base both because there is a lot of software outside my control using that #define, and because after all it makes more sense that GNUstep itself #defines GNUSTEP :-) My suggestions for changes in this area are to standardize the #defines used to the ones automatically defined by gnustep-make when compiling, documenting the options, and using them consistently in all the code. In practice, I'd suggest - - use GNUSTEP (or GNUSTEP_BASE_LIBRARY) to check that gnustep-base is used. - use LIB_FOUNDATION_LIBRARY to check that libFoundation is used. - use NeXT_FOUNDATION_LIBRARY to check that Cocoa FoundationKit is used. - use NeXT_RUNTIME and GNU_RUNTIME to check the ObjC runtime which is being used. I personally think that supporting the original NeXT runtime / NeXT foundation library is not worth the effort, and that we should better try to support the Apple Mac OS X runtime / foundation library properly, but I'm Ok with supporting it if people want to. I can add a #define APPLE_FOUNDATION_LIBRARY in gnustep-make if it seems more appropriate than NeXT_FOUNDATION_LIBRARY when compiling on Apple Mac OS X (that would be in addition to, not as a replacement of, NeXT_FOUNDATION_LIBRARY not to break code using NeXT_FOUNDATION_LIBRARY to check for non-GNU foundation libraries; I know it makes difficult to make a difference between Apple and NeXT foundation library, but is that really important ? who's using NeXT nowadays anyway ? ;-) ) I'd keep NeXT_RUNTIME because that is the official name which is also used in GCC's command line switches; newer GCC also predefine __NEXT_RUNTIME__ when using the NeXT ObjC runtime. I'd stick with this terminology, so I'd prefer not to define APPLE_RUNTIME. Let me know if you have any problems with these #defines. Else, I'd suggest to stick with this list of #defines, and to revise all OpenGroupWare code so that it consistently uses these #defines, and only these. Of course the #defines should be defined by gnustep-make (and additional makefiles installed in gnustep-make), not by OpenGroupWare itself. From mechanix@slider.rack66.net Thu Jul 17 21:11:29 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 28D8F18F66D for ; Thu, 17 Jul 2003 21:11:29 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 07025-07 for ; Thu, 17 Jul 2003 21:11:27 +0200 (CEST) Received: from slider.rack66.net (slider.rack66.net [212.3.252.135]) by mail.opengroupware.org (Postfix) with ESMTP id 6133918F666 for ; Thu, 17 Jul 2003 21:11:27 +0200 (CEST) Received: by slider.rack66.net (Postfix, from userid 1026) id B068CF123; Thu, 17 Jul 2003 21:16:33 +0200 (CEST) Date: Thu, 17 Jul 2003 21:16:33 +0200 From: Filip Van Raemdonck To: gnustep-port@opengroupware.org Message-ID: <20030717191633.GA23462@debian> Mail-Followup-To: gnustep-port@opengroupware.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] SOPE changes Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Attached are two patches - one for SOPE/skyrix-core and one for SOPE/skyrix-xml. Comments for the skyrix-sope patch are contained within; I tried grouping chunks by functionality as much as I could. The skyrix-xml patch are mostly just compiler warning fixes, except for the last chunk. That one makes it use a different codepath when building with GNUstep-base. (although I think it may even affect builds with the contained ThirdParty/ libs; See also my comment in an earlier message about definition if GNUSTEP) Feedback welcome. If this looks good, please someone apply them. They make skyrix-xml and skyrix-core build with almost no really relevant compiler warnings anymore when building with GNUstep-base. Regards, Filip -- "The most beautiful thing we can experience is the mysterious. It is the source of all true art and science." -- Albert Einstein --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=diff-skyrix-core # # zlib.h contains all we need to build on all systems, not just OS X. I think # the outer ifdef should be removed entirely, and zutil.h get rid of. # --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/FdExt.subproj/NSData+gzip.m +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/FdExt.subproj/NSData+gzip.m @@ -26,7 +26,7 @@ #ifdef Assert #undef Assert #endif -#ifdef __APPLE__ +//#ifdef __APPLE__ # include # ifndef DEF_MEM_LEVEL /* zutil.h */ # if MAX_MEM_LEVEL >= 8 @@ -36,9 +36,9 @@ # endif # define OS_CODE 0x07 # endif -#else -# include "zutil.h" -#endif +//#else +//# include "zutil.h" +//#endif #undef Assert @implementation NSData(gzip) --- opengroupware.org-core-0.9.0cvs20030717.orig/NGStreams/NGGZipStream.m +++ opengroupware.org-core-0.9.0cvs20030717/NGStreams/NGGZipStream.m @@ -28,7 +28,7 @@ #ifdef Assert #undef Assert #endif -#ifdef __APPLE__ +//#ifdef __APPLE__ # include # ifndef DEF_MEM_LEVEL /* zutil.h */ # if MAX_MEM_LEVEL >= 8 @@ -38,9 +38,9 @@ # endif # define OS_CODE 0x07 # endif -#else -# include "zutil.h" -#endif +//#else +//# include "zutil.h" +//#endif #undef Assert @implementation NGGZipStream # # NSMethodSignature+misc.m needs some work to properly build with GNUstep-base; # however it isn't used anywhere in the OGo source tree - rather remove it # --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/GNUmakefile +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/GNUmakefile @@ -83,7 +83,6 @@ NSEnumerator+misc.h \ NSException+misc.h \ NSFileManager+Extensions.h \ - NSMethodSignature+misc.h \ NSNull+misc.h \ NSObject+Logs.h \ NSObject+Values.h \ --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/NGExtensions.m +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/NGExtensions.m @@ -33,7 +33,6 @@ #include "NSArray+enumerator.h" #include "NSData+misc.h" #include "NSException+misc.h" -#include "NSMethodSignature+misc.h" #include "NSObject+Values.h" #include "NSSet+enumerator.h" #include "NSString+Formatting.h" --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/FdExt.subproj/GNUmakefile +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/FdExt.subproj/GNUmakefile @@ -14,7 +14,6 @@ NSEnumerator+misc.m \ NSException+misc.m \ NSFileManager+Extensions.m \ - NSMethodSignature+misc.m \ NSNull+misc.m \ NSObject+Logs.m \ NSObject+Values.m \ --- opengroupware.org-core-0.9.0cvs20030717.orig/SxCore.pbproj/project.pbxproj +++ opengroupware.org-core-0.9.0cvs20030717/SxCore.pbproj/project.pbxproj @@ -878,7 +878,6 @@ E80E559F04811A4000A865E9, E80E55A004811A4000A865E9, E80E55A104811A4000A865E9, - E80E55A204811A4000A865E9, E80E55A304811A4000A865E9, E80E55A404811A4000A865E9, E80E55A504811A4000A865E9, @@ -5109,7 +5108,6 @@ E80E55DC04811A4000A865E9, E80E55DD04811A4000A865E9, E80E55DE04811A4000A865E9, - E80E55DF04811A4000A865E9, E80E55E004811A4000A865E9, E80E55E104811A4000A865E9, E80E55E204811A4000A865E9, @@ -5173,7 +5171,6 @@ E80E561C04811A8300A865E9, E80E561D04811A8300A865E9, E80E561E04811A8300A865E9, - E80E561F04811A8300A865E9, E80E562004811A8300A865E9, E80E562104811A8300A865E9, E80E562204811A8300A865E9, @@ -7173,7 +7170,6 @@ E80E560804811A8300A865E9, E80E560904811A8300A865E9, E80E560A04811A8300A865E9, - E80E560B04811A8300A865E9, E80E560C04811A8300A865E9, E80E560D04811A8300A865E9, E80E560E04811A8300A865E9, @@ -7551,13 +7547,6 @@ path = "NGExtensions/NGExtensions/NSFileManager+Extensions.h"; refType = 4; }; - E80E55A204811A4000A865E9 = { - fileEncoding = 4; - isa = PBXFileReference; - name = "NSMethodSignature+misc.h"; - path = "NGExtensions/NGExtensions/NSMethodSignature+misc.h"; - refType = 4; - }; E80E55A304811A4000A865E9 = { fileEncoding = 4; isa = PBXFileReference; @@ -8078,15 +8067,6 @@ ); }; }; - E80E55DF04811A4000A865E9 = { - fileRef = E80E55A204811A4000A865E9; - isa = PBXBuildFile; - settings = { - ATTRIBUTES = ( - Public, - ); - }; - }; E80E55E004811A4000A865E9 = { fileRef = E80E55A304811A4000A865E9; isa = PBXBuildFile; @@ -8396,13 +8376,6 @@ path = "NGExtensions/FdExt.subproj/NSFileManager+Extensions.m"; refType = 4; }; - E80E560B04811A8300A865E9 = { - fileEncoding = 4; - isa = PBXFileReference; - name = "NSMethodSignature+misc.m"; - path = "NGExtensions/FdExt.subproj/NSMethodSignature+misc.m"; - refType = 4; - }; E80E560C04811A8300A865E9 = { fileEncoding = 4; isa = PBXFileReference; @@ -8527,12 +8500,6 @@ settings = { }; }; - E80E561F04811A8300A865E9 = { - fileRef = E80E560B04811A8300A865E9; - isa = PBXBuildFile; - settings = { - }; - }; E80E562004811A8300A865E9 = { fileRef = E80E560C04811A8300A865E9; isa = PBXBuildFile; # # The tests whether to link with libFoundationExt tell to do so even when # trying to build with GNUstep-base. Can someone with better knowledge of # GNUstep come up with failproof tests? # About the sasl thing: it (and with the right soname) should get pulled in # by libldap* if the latter is linked properly. # --- opengroupware.org-core-0.9.0cvs20030717.orig/EOControl/GNUmakefile.preamble +++ opengroupware.org-core-0.9.0cvs20030717/EOControl/GNUmakefile.preamble @@ -8,7 +8,7 @@ libEOControl_LIBRARIES_DEPEND_UPON += -lFoundation endif ifeq ($(FOUNDATION_LIB),nx) -libEOControl_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libEOControl_LIBRARIES_DEPEND_UPON += -lFoundationExt endif ifeq ($(FOUNDATION_LIB),gnu) libEOControl_LIBRARIES_DEPEND_UPON += -lgnustep-base --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/GNUmakefile.preamble +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/GNUmakefile.preamble @@ -8,7 +8,7 @@ libNGExtensions_LIBRARIES_DEPEND_UPON += -lEOControl -lDOM -lz ifneq ($(FOUNDATION_LIB),fd) -libNGExtensions_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libNGExtensions_LIBRARIES_DEPEND_UPON += -lFoundationExt endif ifeq ($(GNUSTEP_TARGET_OS),mingw32) @@ -19,10 +19,10 @@ endif ifeq ($(GNUSTEP_HOST_OS),rhapsody5.5) -libNGExtensions_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libNGExtensions_LIBRARIES_DEPEND_UPON += -lFoundationExt endif ifeq ($(FOUNDATION_LIB),nx) -libNGExtensions_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libNGExtensions_LIBRARIES_DEPEND_UPON += -lFoundationExt ADDITIONAL_LDFLAGS += -framework Foundation endif --- opengroupware.org-core-0.9.0cvs20030717.orig/NGLdap/GNUmakefile.preamble +++ opengroupware.org-core-0.9.0cvs20030717/NGLdap/GNUmakefile.preamble @@ -12,7 +12,8 @@ ifneq ($(FOUNDATION_LIB),nx) ifneq ($(nosasl),yes) -libNGLdap_LIBRARIES_DEPEND_UPON += -lsasl +# libsasl2 is pulled in by libldap; libsasl not found +#libNGLdap_LIBRARIES_DEPEND_UPON += -lsasl endif ifneq ($(nossl),yes) libNGLdap_LIBRARIES_DEPEND_UPON += -lssl @@ -20,9 +21,9 @@ else -libNGLdap_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libNGLdap_LIBRARIES_DEPEND_UPON += -lFoundationExt ADDITIONAL_LDFLAGS += -framework Foundation -ADDITIONAL_TOOL_LIBS += -lFoundationExt +#ADDITIONAL_TOOL_LIBS += -lFoundationExt endif --- opengroupware.org-core-0.9.0cvs20030717.orig/NGMime/GNUmakefile.preamble +++ opengroupware.org-core-0.9.0cvs20030717/NGMime/GNUmakefile.preamble @@ -11,7 +11,7 @@ endif ifeq ($(GNUSTEP_TARGET_OS),darwin1.2) -libNGMime_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libNGMime_LIBRARIES_DEPEND_UPON += -lFoundationExt endif libNGMime_LIB_DIRS += \ --- opengroupware.org-core-0.9.0cvs20030717.orig/NGStreams/GNUmakefile.preamble +++ opengroupware.org-core-0.9.0cvs20030717/NGStreams/GNUmakefile.preamble @@ -10,7 +10,7 @@ endif ifeq ($(FOUNDATION_LIB),nx) -libNGStreams_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libNGStreams_LIBRARIES_DEPEND_UPON += -lFoundationExt endif ifeq ($(reentrant),yes) # # Fixes to not include extensions headers when using GNUstep-base. # I'm not sure how these affect building with Skyrix foundation libraries. # --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/NGHashMap.m +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/NGHashMap.m @@ -20,14 +20,14 @@ */ // $Id: NGHashMap.m,v 1.3 2003/07/11 17:12:46 jan Exp $ -#import "common.h" -#import "NGHashMap.h" -#import "NGMemoryAllocation.h" +#include "common.h" +#include "NGHashMap.h" +#include "NGMemoryAllocation.h" #if LIB_FOUNDATION_LIBRARY # import #elif GNUSTEP_BASE_LIBRARY -# import +//# import #else # import # import --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/FdExt.subproj/NSNull+misc.m +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/FdExt.subproj/NSNull+misc.m @@ -24,10 +24,12 @@ #include "common.h" #if LIB_FOUNDATION_LIBRARY || GNUSTEP_BASE_LIBRARY -# import -# import -# import +# include +# include +# include +#ifndef GNUSTEP # import +#endif #else # import # import --- opengroupware.org-core-0.9.0cvs20030717.orig/NGExtensions/FdExt.subproj/NSString+misc.m +++ opengroupware.org-core-0.9.0cvs20030717/NGExtensions/FdExt.subproj/NSString+misc.m @@ -20,9 +20,9 @@ */ // $Id: NSString+misc.m,v 1.3 2003/07/11 17:12:49 jan Exp $ -#import "common.h" -#import "NGMemoryAllocation.h" -#import "NSString+misc.h" +#include "common.h" +#include "NGMemoryAllocation.h" +#include "NSString+misc.h" #if !LIB_FOUNDATION_LIBRARY && !GNUSTEP_BASE_LIBRARY # import @@ -66,7 +66,7 @@ } buffer[pos] = '\0'; -#if NeXT_Foundation_LIBRARY +#if NeXT_Foundation_LIBRARY || GNUSTEP { NSString *s; --- opengroupware.org-core-0.9.0cvs20030717.orig/NGMime/NGMail/common.h +++ opengroupware.org-core-0.9.0cvs20030717/NGMime/NGMail/common.h @@ -23,7 +23,7 @@ #ifndef __NGMail_common_H__ #define __NGMail_common_H__ -#import +#include #if LIB_FOUNDATION_LIBRARY # import @@ -32,8 +32,10 @@ # import # import # else +# ifndef GNUSTEP # import # import +# endif # endif #endif --- opengroupware.org-core-0.9.0cvs20030717.orig/NGStreams/common.h +++ opengroupware.org-core-0.9.0cvs20030717/NGStreams/common.h @@ -25,7 +25,7 @@ // common include files -#import +#include // configuration @@ -55,8 +55,10 @@ # import # import #else +#ifndef GNUSTEP # include #endif +#endif #if !LIB_FOUNDATION_LIBRARY && !NeXT_Foundation_LIBRARY # define NSWillBecomeMultiThreadedNotification NSBecomingMultiThreaded --- opengroupware.org-core-0.9.0cvs20030717.orig/samples/common.h +++ opengroupware.org-core-0.9.0cvs20030717/samples/common.h @@ -20,12 +20,12 @@ */ // $Id: common.h,v 1.2 2003/07/11 17:12:50 jan Exp $ -#import +#include #if LIB_FOUNDATION_LIBRARY # import #elif GNUSTEP_BASE_LIBRARY -# import +//# import #else # import # import # # Fixes to use GNUstep (and OS X Foundation too AFAICT) classes & methods, # or extend them to get needed functionality. # --- opengroupware.org-core-0.9.0cvs20030717.orig/NGLdap/NGLdapConnection.m +++ opengroupware.org-core-0.9.0cvs20030717/NGLdap/NGLdapConnection.m @@ -722,7 +722,8 @@ while ((value = [values nextObject])) { unsigned idx; - if ((idx = [value indexOfString:@":"]) == NSNotFound) + //if ((idx = [value indexOfString:@":"]) == NSNotFound) + if ((idx = [value rangeOfString:@":"].location) == NSNotFound) /* couldn't parse value */ continue; --- opengroupware.org-core-0.9.0cvs20030717.orig/NGMime/NGImap4/NGImap4Client.m +++ opengroupware.org-core-0.9.0cvs20030717/NGMime/NGImap4/NGImap4Client.m @@ -40,6 +40,14 @@ @end /* NGImap4Client(ConnectionRegistration); */ +/* FIXME: move someplace better */ +@implementation NSException (setUserInfo) +- (id) setUserInfo: (NSDictionary*) _userInfo { + ASSIGN (self->_e_info, _userInfo); + return self; +} +@end + @interface NGImap4Client(Private) - (NGHashMap *)processCommand:(NSString *)_command; @@ -1615,7 +1623,7 @@ NSString *pref; pref = [VersionPrefixDict objectForKey:key]; - index = [lowServer indexOfString:pref]; + index = [lowServer rangeOfString:pref].location; if (index != NSNotFound) { /* cyrus server */ --- opengroupware.org-core-0.9.0cvs20030717.orig/NGMime/NGImap4/common.h +++ opengroupware.org-core-0.9.0cvs20030717/NGMime/NGImap4/common.h @@ -23,10 +23,12 @@ #ifndef __NGImap4_common_H__ #define __NGImap4_common_H__ -#import +#include #if LIB_FOUNDATION_LIBRARY || GNUSTEP_BASE_LIBRARY +#ifndef GNUSTEP # include +#endif #else # import # import @@ -35,11 +37,15 @@ # import #endif -#import +#include #include #include #include #include #include +@interface NSException (setUserInfo) +- (id) setUserInfo: (NSDictionary*) _userInfo; +@end + #endif /* __NGImap4_common_H__ */ --- opengroupware.org-core-0.9.0cvs20030717.orig/NGiCal/iCalDateHolder.m +++ opengroupware.org-core-0.9.0cvs20030717/NGiCal/iCalDateHolder.m @@ -85,7 +85,6 @@ - (id)awakeAfterUsingSaxDecoder:(id)_decoder { NSString *s; NSTimeZone *tz; - unsigned idx; s = self->string; if ([s length] < 5) { @@ -104,7 +103,8 @@ else tz = [self timeZone]; - if ((idx = [s indexOfString:@"T"]) != NSNotFound) { + //if ((idx = [s indexOfString:@"T"]) != NSNotFound) { + if ([s rangeOfString:@"T"].location != NSNotFound) { /* 012345678901234 20021009T094500 - 15 chars # # Just compiler warning fixes (about missing declarations or other things). # --- opengroupware.org-core-0.9.0cvs20030717.orig/samples/EOQualTool.h +++ opengroupware.org-core-0.9.0cvs20030717/samples/EOQualTool.h @@ -20,7 +20,10 @@ */ // $Id: EOQualTool.h,v 1.2 2003/07/11 17:12:50 jan Exp $ -#import +#ifndef __OGo_EOQualTool_H__ +#define __OGo_EOQualTool_H__ + +#include @class NSArray, EOQualifier; @@ -39,3 +42,4 @@ - (int)runWithArguments:(NSArray *)_args; @end +#endif --- opengroupware.org-core-0.9.0cvs20030717.orig/samples/EOQualTool.m +++ opengroupware.org-core-0.9.0cvs20030717/samples/EOQualTool.m @@ -20,10 +20,11 @@ */ // $Id: EOQualTool.m,v 1.2 2003/07/11 17:12:50 jan Exp $ -#import "EOQualTool.h" -#import "common.h" +#include "EOQualTool.h" +#include "common.h" #include #include +#include @interface dateTime : NSDate @end --- opengroupware.org-core-0.9.0cvs20030717.orig/samples/EncodingTool.h +++ opengroupware.org-core-0.9.0cvs20030717/samples/EncodingTool.h @@ -20,8 +20,11 @@ */ // $Id: EncodingTool.h,v 1.2 2003/07/11 17:12:50 jan Exp $ -#import -#import +#ifndef __OGo_EncodingTool_H__ +#define __OGo_EncodingTool_H__ + +#include +#include @class NSString; @@ -41,3 +44,4 @@ - (int)runWithArguments:(NSArray *)_args; @end +#endif --- opengroupware.org-core-0.9.0cvs20030717.orig/samples/ImapListTool.h +++ opengroupware.org-core-0.9.0cvs20030717/samples/ImapListTool.h @@ -20,7 +20,10 @@ */ // $Id: ImapListTool.h,v 1.2 2003/07/11 17:12:50 jan Exp $ -#import "ImapTool.h" +#ifndef __OGo_ImapListTool_H__ +#define __OGo_ImapListTool_H__ + +#include "ImapTool.h" @class NSArray; @@ -41,3 +44,4 @@ - (int)runWithArguments:(NSArray *)_args; @end +#endif --- opengroupware.org-core-0.9.0cvs20030717.orig/samples/Mime2XmlTool.h +++ opengroupware.org-core-0.9.0cvs20030717/samples/Mime2XmlTool.h @@ -20,7 +20,10 @@ */ // $Id: Mime2XmlTool.h,v 1.2 2003/07/11 17:12:50 jan Exp $ -#import +#ifndef __OGo_Mime2XMLTool_H__ +#define __OGo_Mime2XMLTool_H__ + +#include @class NSArray; @@ -45,3 +48,4 @@ - (int)runWithArguments:(NSArray *)_args; @end +#endif --- opengroupware.org-core-0.9.0cvs20030717.orig/samples/test_qpdecode.m +++ opengroupware.org-core-0.9.0cvs20030717/samples/test_qpdecode.m @@ -25,6 +25,7 @@ */ #include "common.h" +#include static void test(void) { static unsigned char *fields[] = { --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=diff-skyrix-xml --- OpenGroupware.org/SOPE/skyrix-xml/DOM/DOMNode.m +++ skyrix-xml/opengroupware.org-xml-0.9.0cvs20030717/DOM/DOMNode.m @@ -172,7 +172,7 @@ - (id)previousSibling { DOMNode *parent; - if ((parent = [self parentNode]) == nil) return nil; + if ((parent = (DOMNode*) [self parentNode]) == nil) return nil; if (parent == nil) return nil; if (![parent respondsToSelector:@selector(_domNodeBeforeNode:)]) return nil; return [parent _domNodeBeforeNode:self]; @@ -180,7 +180,7 @@ - (id)nextSibling { DOMNode *parent; - if ((parent = [self parentNode]) == nil) return nil; + if ((parent = (DOMNode*) [self parentNode]) == nil) return nil; if (parent == nil) return nil; if (![parent respondsToSelector:@selector(_domNodeBeforeNode:)]) return nil; return [parent _domNodeAfterNode:self]; --- OpenGroupware.org/SOPE/skyrix-xml/DOM/DOMXMLOutputter.m +++ skyrix-xml/opengroupware.org-xml-0.9.0cvs20030717/DOM/DOMXMLOutputter.m @@ -182,7 +182,7 @@ unsigned i, count; // getting new attributes prefixes and namespaces - list = [self newAttributePrefixesAndNamespaces:[_node attributes]]; + list = [self newAttributePrefixesAndNamespaces: (NSArray*) [_node attributes]]; // push new attribute prefixes and namespaces to stack for (i = 0, count = [list count]; i < count; i = i + 2) { --- OpenGroupware.org/SOPE/skyrix-xml/SaxObjC/SaxXMLReaderFactory.m +++ skyrix-xml/opengroupware.org-xml-0.9.0cvs20030717/SaxObjC/SaxXMLReaderFactory.m @@ -28,6 +28,7 @@ - (id)copyWithZone:(NSZone *)_zone { return [self retain]; } +@end #endif @implementation SaxXMLReaderFactory --- OpenGroupware.org/SOPE/skyrix-xml/XmlRpc/NSNotification+XmlRpcCoding.m +++ skyrix-xml/opengroupware.org-xml-0.9.0cvs20030717/XmlRpc/NSNotification+XmlRpcCoding.m @@ -41,7 +41,7 @@ - (void)encodeWithXmlRpcCoder:(XmlRpcEncoder *)_coder { NSString *n; -#if APPLE_Foundation_LIBRARY || NeXT_Foundation_LIBRARY +#if APPLE_Foundation_LIBRARY || NeXT_Foundation_LIBRARY || GNUSTEP n = [self name]; #else n = [self notificationName]; --uAKRQypu60I7Lcqm-- From fvallon@fr.alcove.com Thu Jul 17 22:21:25 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id A3BE218F679; Thu, 17 Jul 2003 22:21:25 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 29794-07; Thu, 17 Jul 2003 22:21:24 +0200 (CEST) Received: from smtp.alcove-fr (unknown [81.80.245.157]) by mail.opengroupware.org (Postfix) with ESMTP id 8633B18F647; Thu, 17 Jul 2003 22:21:23 +0200 (CEST) Received: from vitel.alcove-fr ([10.16.10.8]) by smtp.alcove-fr with esmtp (Exim 3.12 #1 (Debian)) id 19dFKR-0006VL-00; Thu, 17 Jul 2003 22:26:15 +0200 Received: from fvallon by vitel.alcove-fr with local (Exim 3.35 #1 (Debian)) id 19dFKP-0004gr-00; Thu, 17 Jul 2003 22:26:13 +0200 Date: Thu, 17 Jul 2003 22:26:13 +0200 From: Fabien VALLON To: developer@opengroupware.org Cc: macosx@opengroupware.org, gnustep-port@opengroupware.org Message-ID: <20030717202613.GA17948@vitel.alcove-fr> References: <20030717122549.62994.qmail@web10704.mail.yahoo.com> <3F16AF97.8010702@opengroupware.org> <20030717193958.GA17822@vitel.alcove-fr> <01624AD8-B891-11D7-8344-000393C29C2A@opengroupware.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <01624AD8-B891-11D7-8344-000393C29C2A@opengroupware.org> User-Agent: Mutt/1.3.25i X-Operating-System: GNU/Linux/2.4.20-station+usbdev (i686) X-Uptime: 22:05:59 up 30 days, 7:39, 14 users, load average: 0.01, 0.02, 0.00 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Re: [OGo-Developer] Roadmap and Versioning Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Helge Hess (helge.hess@opengroupware.org) wrote: > On Donnerstag, 17. Juli 2003, at 21:39 Uhr, Fabien VALLON wrote: > >>Excellent :-) I hope more people (znek!) join in and can actually > >>start > >>to get something going regarding the OSX port. > >>Fabien said he might help on that, too. > >> > >>I can help on specific problems, but lets talk about that at > >>macosx@ogo. > > > >why did you separate MOSX (Cocoa) & GNUstep port ? > >It should be quite the same .... > > Hm. I'm not sure. I think Cocoa is quite different to GNUstep, depends > on how we intend to do it, eg PBX or gnustep-make on Cocoa (I would now > prefer the latter). Is there a problem using gnustep-make on OSX (Nicola ?) I think MOSX could use it :) ( who says "Embrace & Extends" ;-) I'm talking about code. Do you plan separate cvs tree ? > And the target audience usually is also quite different, little OSX > people knowing GNUstep very well and the reverse as well. Well GNUstep/Foundation & Cocoa/Foundation are quite the same ... > Anyway, feel free to do crossposts ;-) done :) Fabien -- Fabien VALLON - fabien.vallon@fr.alcove.com Ingénieur Informatique Libre - Alcôve - http://www.alcove.com GNUstep - http://www.gnustep.org - From helge.hess@opengroupware.org Fri Jul 18 09:03:52 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 7E8C618F57E; Fri, 18 Jul 2003 09:03:52 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 16718-02; Fri, 18 Jul 2003 09:03:51 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 92EFE18F545; Fri, 18 Jul 2003 09:03:51 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id 1804DCE0A8; Fri, 18 Jul 2003 09:09:20 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id BAD3C42139; Fri, 18 Jul 2003 09:12:03 +0200 (CEST) Received: from opengroupware.org (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id D7EE1FA9B; Fri, 18 Jul 2003 09:11:38 +0200 (CEST) Message-ID: <3F179BA8.8080005@opengroupware.org> Date: Fri, 18 Jul 2003 09:03:04 +0200 From: Helge Hess User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: macosx@opengroupware.org Cc: gnustep-port@opengroupware.org References: <20030717122549.62994.qmail@web10704.mail.yahoo.com> <3F16AF97.8010702@opengroupware.org> <20030717193958.GA17822@vitel.alcove-fr> <01624AD8-B891-11D7-8344-000393C29C2A@opengroupware.org> <20030717202613.GA17948@vitel.alcove-fr> In-Reply-To: <20030717202613.GA17948@vitel.alcove-fr> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Cocoa Porting, was: Re: [OGo-Developer] Roadmap and Versioning Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: I took out developer@, since this is a macosx/gnustep-port issue. Fabien VALLON wrote: > Is there a problem using gnustep-make on OSX (Nicola ?) I don't think that there is a general problem. I invited Nicola to join the list, we'll see whether he finds time ;-) > I think MOSX could use it :) Yes, but it might be complicate to setup since the developer needs to fiddle around with all those environment sourcing which is a bit difficult in Finder. And the build-results should definitely be independend from GNUstep, that is, the build process should create frameworks and bundles usable without the GNUstep environment. Nicola has shown that this can work with Renaissance. > I'm talking about code. > Do you plan separate cvs tree ? Definitely not. A single codebase should work everywhere. >>And the target audience usually is also quite different, little OSX >>people knowing GNUstep very well and the reverse as well. > > Well GNUstep/Foundation & Cocoa/Foundation are quite the same ... Like libFoundation. GNUstep-base differs as much from libFoundation as Cocoa Foundation does. One concrete example is porting the file-descriptor handling in NSRunLoop, which isn't part of ObjC Cocoa, but both, libFoundation and gstep-base provide that. So we should use exactly that on gstep-base and find a good workaround for Cocoa (we currently use a hack there which uses NSFileHandle but seems to work fine). I think on Cocoa we might fix that by using CFRunLoop instead of NSRunLoop. Anyway, people should just get started ;-) regards, Helge -- http://www.opengroupware.org/ From helge.hess@opengroupware.org Fri Jul 18 10:21:42 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id E12E918F5EB for ; Fri, 18 Jul 2003 10:21:41 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 05753-04 for ; Fri, 18 Jul 2003 10:21:41 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 58E1418F57E for ; Fri, 18 Jul 2003 10:21:41 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id 4C5DB57097 for ; Fri, 18 Jul 2003 10:27:11 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id B84A44213E for ; Fri, 18 Jul 2003 10:30:04 +0200 (CEST) Received: from opengroupware.org (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id A1B03D3F5 for ; Fri, 18 Jul 2003 10:29:49 +0200 (CEST) Message-ID: <3F17ADFA.1060207@opengroupware.org> Date: Fri, 18 Jul 2003 10:21:14 +0200 From: Helge Hess User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gnustep-port@opengroupware.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Now I'm in ... Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Hi, I didn't realize that I'm actually not yet subscribed to the list, sigh ... Nice to see Nicola in here :-) There were patches to SOPE, can someone please send me the patches, I'll try if it breaks something and commit if not. regards, Helge -- http://www.opengroupware.org/ From helge.hess@skyrix.com Fri Jul 18 10:37:36 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 554C418F5EB; Fri, 18 Jul 2003 10:37:36 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 11677-02; Fri, 18 Jul 2003 10:37:35 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id CFF6418F57E; Fri, 18 Jul 2003 10:37:35 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id 3E9075722C; Fri, 18 Jul 2003 10:43:06 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 9A7FB4213F; Fri, 18 Jul 2003 10:46:10 +0200 (CEST) Received: from skyrix.com (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 2E7C7D3F5; Fri, 18 Jul 2003 10:46:09 +0200 (CEST) Message-ID: <3F17B1CE.3020303@skyrix.com> Date: Fri, 18 Jul 2003 10:37:34 +0200 From: Helge Hess Organization: http://www.skyrix.com User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: developer , gnustep-port@opengroupware.org, macosx@opengroupware.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Patches Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Hi, please send any patches you want to have applied to patches@opengroupware.org. We are going to review/edit, test a bit and commit if everything looks fine. Thanks a lot, Helge -- __________________________________________________________________ Helge Hess Email: helge.hess@skyrix.com SKYRIX Software AG Tel: +49-391-6623-0 Universitaetsplatz 12 Fax: +49-391-6623-599 39104 Magdeburg, Germany Internet: http://www.skyrix.com __________________________________________________________________ Exchange your Exchange http://www.opengroupware.org/ __________________________________________________________________ From mechanix@slider.rack66.net Fri Jul 18 11:28:43 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id A6A3618F6AC; Fri, 18 Jul 2003 11:28:43 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 25675-08; Fri, 18 Jul 2003 11:28:42 +0200 (CEST) Received: from slider.rack66.net (slider.rack66.net [212.3.252.135]) by mail.opengroupware.org (Postfix) with ESMTP id CAE4118F66D; Fri, 18 Jul 2003 11:28:42 +0200 (CEST) Received: by slider.rack66.net (Postfix, from userid 1026) id 3E77FF1FF; Fri, 18 Jul 2003 11:34:04 +0200 (CEST) Date: Fri, 18 Jul 2003 11:34:04 +0200 From: Filip Van Raemdonck To: developer@opengroupware.org Cc: gnustep-port@opengroupware.org Message-ID: <20030718093404.GJ10720@debian> Mail-Followup-To: developer@opengroupware.org, gnustep-port@opengroupware.org References: <3F17B2CD.7030109@opengroupware.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F17B2CD.7030109@opengroupware.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Re: [OGo-Developer] Patches Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Fri, Jul 18, 2003 at 10:41:49AM +0200, Helge Hess wrote: > > please send any patches you want to have applied to > patches@opengroupware.org. We are going to review/edit, test a bit and > commit if everything looks fine. Is this to stay that way? Or only for now? Wouldn't it be better to send patches to (a) relevant mailing list(s) for review/feedback by more people? (you never know who's lurking) Regards, Filip -- "The MS-DOS filesystem is nice for removable media." -- H. Peter Anvin From nicola@brainstorm.co.uk Fri Jul 18 11:30:31 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 7B66218F6AC; Fri, 18 Jul 2003 11:30:31 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 27303-02; Fri, 18 Jul 2003 11:30:31 +0200 (CEST) Received: from mail.brainstorm.co.uk (smtp.brainstorm.co.uk [217.169.5.196]) by mail.opengroupware.org (Postfix) with ESMTP id 888F018F66D; Fri, 18 Jul 2003 11:30:30 +0200 (CEST) Received: from nicola.brainstorm.co.uk (IDENT:AlfDEVvzukAdZAgamuxKcatBaPf3BtxL@nicola.brainstorm.co.uk [192.168.4.138]) by mail.brainstorm.co.uk (8.11.4/8.11.4) with ESMTP id h6I9ZpO17850; Fri, 18 Jul 2003 10:35:51 +0100 Date: Fri, 18 Jul 2003 10:40:12 +0100 (BST) From: Nicola Pero To: gnustep-port@opengroupware.org Cc: developer@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Re: [OGo-Developer] Patches In-Reply-To: <20030718093404.GJ10720@debian> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: > > please send any patches you want to have applied to > > patches@opengroupware.org. We are going to review/edit, test a bit and > > commit if everything looks fine. > > Is this to stay that way? Or only for now? > > Wouldn't it be better to send patches to (a) relevant mailing list(s) for > review/feedback by more people? (you never know who's lurking) I agree. From helge.hess@opengroupware.org Fri Jul 18 11:49:55 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 0758418F66D; Fri, 18 Jul 2003 11:49:55 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 31703-09; Fri, 18 Jul 2003 11:49:54 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 2E25E18F57B; Fri, 18 Jul 2003 11:49:54 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id EBC985757F; Fri, 18 Jul 2003 11:55:26 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 664E842148; Fri, 18 Jul 2003 11:58:10 +0200 (CEST) Received: from opengroupware.org (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id B6B2B4214A; Fri, 18 Jul 2003 11:57:47 +0200 (CEST) Message-ID: <3F17C298.3090301@opengroupware.org> Date: Fri, 18 Jul 2003 11:49:12 +0200 From: Helge Hess User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: developer@opengroupware.org Cc: gnustep-port@opengroupware.org References: <3F17B2CD.7030109@opengroupware.org> <20030718093404.GJ10720@debian> In-Reply-To: <20030718093404.GJ10720@debian> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Re: [OGo-Developer] Patches Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Filip Van Raemdonck wrote: > On Fri, Jul 18, 2003 at 10:41:49AM +0200, Helge Hess wrote: >>please send any patches you want to have applied to >>patches@opengroupware.org. We are going to review/edit, test a bit and >>commit if everything looks fine. > > Is this to stay that way? Or only for now? We'll see what works out best. But we will stay to make tight control on who exactly is allowed to commit to ensure high quality of the codebase (I think this is the same for other OpenSource projects). I think I'll put up a list of people who are allowed to commit to the codebase later. For now, just post to patches. > Wouldn't it be better to send patches to (a) relevant mailing list(s) for > review/feedback by more people? (you never know who's lurking) Yes, it's certainly a good idea to post patches to a mailing list to get some feedback prior posting ot patches@ogo. Thanks a lot, Helge -- http://www.opengroupware.org/ From helge.hess@opengroupware.org Fri Jul 18 13:13:09 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id C218D18F6AC for ; Fri, 18 Jul 2003 13:13:09 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 22625-03 for ; Fri, 18 Jul 2003 13:13:09 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 4838A18F57B for ; Fri, 18 Jul 2003 13:13:09 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id 1FE333E5AB for ; Fri, 18 Jul 2003 13:18:44 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 98A3442158 for ; Fri, 18 Jul 2003 13:21:37 +0200 (CEST) Received: from opengroupware.org (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 666E04214C for ; Fri, 18 Jul 2003 13:21:23 +0200 (CEST) Message-ID: <3F17D62F.80803@opengroupware.org> Date: Fri, 18 Jul 2003 13:12:47 +0200 From: Helge Hess User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gnustep-port@opengroupware.org References: <3F17ADFA.1060207@opengroupware.org> In-Reply-To: <3F17ADFA.1060207@opengroupware.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Re: Patches Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Hi, regarding the patches. The skyrix-xml patches are all applied in CVS. But various things in core are dubious and I'm still inspecting them ;-) eg: --- -#if NeXT_Foundation_LIBRARY +#if NeXT_Foundation_LIBRARY || GNUSTEP --- Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be selected even for Cocoa and libFoundation when used with gstep-make, right ? Note: I won't accept any patches which will break Cocoa or libFoundation. I definitely do not want to have the mess which happend with gstep-gui, which back when Ovidiu worked on it happened to work with any Foundation (even the NeXT one) and now has a lot of ties into gstep-base internals. Please take care that lF and Cocoa compatibility are not broken. I would actually prefer that all of you have a parallel libFoundation/OGo-gstep-base installation to ensure that patches actually work (lessens workload on me ;-). best regards, Helge -- http://www.opengroupware.org/ From helge.hess@opengroupware.org Fri Jul 18 13:22:05 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 0F61318F6E4 for ; Fri, 18 Jul 2003 13:22:05 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 25203-04 for ; Fri, 18 Jul 2003 13:22:03 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 3A9FD18F57B for ; Fri, 18 Jul 2003 13:22:03 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id D898C570FB for ; Fri, 18 Jul 2003 13:27:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 6CDA84214A for ; Fri, 18 Jul 2003 13:30:31 +0200 (CEST) Received: from opengroupware.org (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 4C3AA42145 for ; Fri, 18 Jul 2003 13:30:17 +0200 (CEST) Message-ID: <3F17D845.7040202@opengroupware.org> Date: Fri, 18 Jul 2003 13:21:41 +0200 From: Helge Hess User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gnustep-port@opengroupware.org References: <3F17B1CE.3020303@skyrix.com> In-Reply-To: <3F17B1CE.3020303@skyrix.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] Re: Patches Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Hi, Helge Hess wrote: > please send any patches you want to have applied to > patches@opengroupware.org. We are going to review/edit, test a bit and > commit if everything looks fine. If you replace indexOfString: with rangeOfString:, AFAIK this is not supposed to work: --- - index = [lowServer indexOfString:pref]; + index = [lowServer rangeOfString:pref].location; if (index != NSNotFound) { --- If you use -rangeOfString:, you need to check the length, to find out whether something was actually found: --- r = [lowServer rangeOfString:pref] if (r.length > 0) { --- I think I run into this on Cocoa, but I'm not sure. regards, Helge -- http://www.opengroupware.org/ From nicola@brainstorm.co.uk Fri Jul 18 13:31:20 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 0726C18F6AC for ; Fri, 18 Jul 2003 13:31:20 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 26696-02 for ; Fri, 18 Jul 2003 13:31:19 +0200 (CEST) Received: from mail.brainstorm.co.uk (smtp.brainstorm.co.uk [217.169.5.196]) by mail.opengroupware.org (Postfix) with ESMTP id 440B718F57B for ; Fri, 18 Jul 2003 13:31:19 +0200 (CEST) Received: from nicola.brainstorm.co.uk (IDENT:UJpif9GVdErCK4BV/xqrYFqWgOlDiDZ8@nicola.brainstorm.co.uk [192.168.4.138]) by mail.brainstorm.co.uk (8.11.4/8.11.4) with ESMTP id h6IBagO27556 for ; Fri, 18 Jul 2003 12:36:42 +0100 Date: Fri, 18 Jul 2003 12:41:03 +0100 (BST) From: Nicola Pero To: gnustep-port@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Re: Patches In-Reply-To: <3F17D62F.80803@opengroupware.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: > eg: > --- > -#if NeXT_Foundation_LIBRARY > +#if NeXT_Foundation_LIBRARY || GNUSTEP > --- > > Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be > selected even for Cocoa and libFoundation when used with gstep-make, right ? No. gnustep-make/base #define GNUSTEP if and only if gnustep-base is being used. GNUSTEP and GNUSTEP_BASE_LIBRARY are equivalent. I know OGo's own makefile #defines GNUSTEP if gnustep-make is being used, but that's OGo's own strange quirk which should be removed (see my previous posts before replying). The macro GNUSTEP should of course be #defined by gnustep itself, not by OGo's makefile. > Note: I won't accept any patches which will break Cocoa or > libFoundation. That is fine. I agree. > I would actually prefer that all of you have a parallel > libFoundation/OGo-gstep-base installation to ensure that patches > actually work (lessens workload on me ;-). To setup the parallel installation you can use library-combos - if you do make sure to enable library-combos when ./configuring gnustep-make, as they are disabled by default in the latest gnustep-make (at popular request). From helge.hess@opengroupware.org Fri Jul 18 13:54:32 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id F31AC18F6B3; Fri, 18 Jul 2003 13:54:31 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 13586-01; Fri, 18 Jul 2003 13:54:31 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 57CE018F6AC; Fri, 18 Jul 2003 13:54:31 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id A91CCCF196; Fri, 18 Jul 2003 14:00:06 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id AC51742147; Fri, 18 Jul 2003 14:02:47 +0200 (CEST) Received: from opengroupware.org (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 29D654212D; Fri, 18 Jul 2003 14:02:24 +0200 (CEST) Message-ID: <3F17DFCC.9050905@opengroupware.org> Date: Fri, 18 Jul 2003 13:53:48 +0200 From: Helge Hess User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gnustep-port@opengroupware.org Cc: developer@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Re: Patches References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Hi, more issues, I think I post them to developer too, before other people step over it ;-) skyrix-core/NGLdap ---snip--- ifneq ($(nosasl),yes) -libNGLdap_LIBRARIES_DEPEND_UPON += -lsasl +# libsasl2 is pulled in by libldap; libsasl not found +#libNGLdap_LIBRARIES_DEPEND_UPON += -lsasl endif ---snap---- Wrong. OGo shouldn't only work on the latest, hippiest GNU/Linux distribution but even on old ones. And if we added a special compilation option on that, it certainly made some sense ;-) To be exact, there are deployed libldap libraries in some distribution (I think it was SuSE 6.3 or something) which do NOT link against libsasl even though requiring it. I know that it breaks on the latest GNU/Linux systems which use libsasl2, probably we need to make a configure script which checks for the proper sasl library available in the system. So on modern systems, you can type make debug=yes nosasl=yes all Maybe we should toggle the default-value, probably makes sense. best regards, Helge PS: I know I should post the OGo source styleguides, will do later ... -- http://www.opengroupware.org/ From mechanix@slider.rack66.net Fri Jul 18 14:06:21 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id C0DA918F6AC for ; Fri, 18 Jul 2003 14:06:21 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 13648-10 for ; Fri, 18 Jul 2003 14:06:20 +0200 (CEST) Received: from slider.rack66.net (slider.rack66.net [212.3.252.135]) by mail.opengroupware.org (Postfix) with ESMTP id 7E12B18F57B for ; Fri, 18 Jul 2003 14:06:20 +0200 (CEST) Received: by slider.rack66.net (Postfix, from userid 1026) id AB584F108; Fri, 18 Jul 2003 14:11:44 +0200 (CEST) Date: Fri, 18 Jul 2003 14:11:44 +0200 From: Filip Van Raemdonck To: gnustep-port@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Re: Patches Message-ID: <20030718121144.GK10720@debian> Mail-Followup-To: gnustep-port@opengroupware.org References: <3F17B1CE.3020303@skyrix.com> <3F17D845.7040202@opengroupware.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F17D845.7040202@opengroupware.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Fri, Jul 18, 2003 at 01:21:41PM +0200, Helge Hess wrote: > > If you use -rangeOfString:, you need to check the length, to find out > whether something was actually found: <...> > I think I run into this on Cocoa, but I'm not sure. And it appears you're right, according to http://216.239.37.104/search?q=cache:3yf0ePoBBYIJ:developer.apple.com/techpubs/macosx/ReleaseNotes/CoreFoundation.html+rangeOfString+location+NSNotFound&hl=nl&ie=UTF-8 which mentions that being a bug and it being fixed in 10.2. So, I guess it's better to check the length then. /me goes of fixing that in other changes he has pipelined :-/ Regards, Filip -- "The nice thing about standards is that there are so many to choose from. And if you really don't like all the standards you just have to wait another year until the one arises you are looking for." -- Andrew Tanenbaum, "Introduction to Computer Networks" From helge.hess@opengroupware.org Fri Jul 18 14:20:20 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 68E1E18F6AC; Fri, 18 Jul 2003 14:20:20 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 24519-05; Fri, 18 Jul 2003 14:20:19 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 9EE0218F57B; Fri, 18 Jul 2003 14:20:18 +0200 (CEST) Received: from skyrix.in.skyrix.com (gw.skyrix.com [213.211.192.97]) by imap.mdlink.de (Postfix) with ESMTP id 6CB48CF8C2; Fri, 18 Jul 2003 14:25:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 7173D42149; Fri, 18 Jul 2003 14:28:37 +0200 (CEST) Received: from opengroupware.org (dogbert.in.skyrix.com [192.168.0.118]) by skyrix.in.skyrix.com (Postfix on SuSE Linux 7.1 (i386)) with ESMTP id 52FF84212D; Fri, 18 Jul 2003 14:28:10 +0200 (CEST) Message-ID: <3F17E5D6.1090209@opengroupware.org> Date: Fri, 18 Jul 2003 14:19:34 +0200 From: Helge Hess User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gnustep-port@opengroupware.org Cc: macosx@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Re: Patches References: <3F17B1CE.3020303@skyrix.com> <3F17D845.7040202@opengroupware.org> <20030718121144.GK10720@debian> In-Reply-To: <20030718121144.GK10720@debian> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by AMaViS perl-11 X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Further: -#import +#include I won't check that in, since it breaks Cocoa. I know that #import will be removed from gcc, but I'm not going to replace the Foundation includes for #import _now_, we can take how to deal with the issue later. Any other #import (imports which do not include Foundation, Cocoa or Appkit), should be replaced with #include of course. regards, Helge -- http://www.opengroupware.org/ From nicola@brainstorm.co.uk Fri Jul 18 14:40:17 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id AF14A18F6AC; Fri, 18 Jul 2003 14:40:17 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 28978-07; Fri, 18 Jul 2003 14:40:17 +0200 (CEST) Received: from mail.brainstorm.co.uk (smtp.brainstorm.co.uk [217.169.5.196]) by mail.opengroupware.org (Postfix) with ESMTP id AEE0D18F57B; Fri, 18 Jul 2003 14:40:16 +0200 (CEST) Received: from nicola.brainstorm.co.uk (IDENT:wqZ4JLOSl27cLTl2IPqiv35IS651r3N1@nicola.brainstorm.co.uk [192.168.4.138]) by mail.brainstorm.co.uk (8.11.4/8.11.4) with ESMTP id h6ICjeO00648; Fri, 18 Jul 2003 13:45:40 +0100 Date: Fri, 18 Jul 2003 13:50:02 +0100 (BST) From: Nicola Pero To: gnustep-port@opengroupware.org Cc: developer@opengroupware.org, Subject: Re: [OGo-GNUstep-Port] Re: [OGo-Developer] Roadmap and Versioning In-Reply-To: <20030717202613.GA17948@vitel.alcove-fr> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: > > >>Excellent :-) I hope more people (znek!) join in and can actually > > >>start > > >>to get something going regarding the OSX port. > > >>Fabien said he might help on that, too. > > >> > > >>I can help on specific problems, but lets talk about that at > > >>macosx@ogo. > > > > > >why did you separate MOSX (Cocoa) & GNUstep port ? > > >It should be quite the same .... > > > > Hm. I'm not sure. I think Cocoa is quite different to GNUstep, depends > > on how we intend to do it, eg PBX or gnustep-make on Cocoa (I would now > > prefer the latter). > > Is there a problem using gnustep-make on OSX (Nicola ?) > I think MOSX could use it :) Yes. I don't think there is anything wrong with using PBX, but using gnustep-make should be very easy, and be cross-platform. You can check Renaissance. We can probably improve on the framework vs library support. From nicola@brainstorm.co.uk Fri Jul 18 14:49:55 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 2699B18F6E4; Fri, 18 Jul 2003 14:49:55 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 00853-01; Fri, 18 Jul 2003 14:49:54 +0200 (CEST) Received: from mail.brainstorm.co.uk (smtp.brainstorm.co.uk [217.169.5.196]) by mail.opengroupware.org (Postfix) with ESMTP id 4203A18F6AC; Fri, 18 Jul 2003 14:49:54 +0200 (CEST) Received: from nicola.brainstorm.co.uk (IDENT:xrHPppamRfpjq5D29spIQnguLx+bwO+j@nicola.brainstorm.co.uk [192.168.4.138]) by mail.brainstorm.co.uk (8.11.4/8.11.4) with ESMTP id h6ICtIO01475; Fri, 18 Jul 2003 13:55:18 +0100 Date: Fri, 18 Jul 2003 13:59:40 +0100 (BST) From: Nicola Pero To: gnustep-port@opengroupware.org Cc: macosx@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Cocoa Porting, was: Re: [OGo-Developer] Roadmap and Versioning In-Reply-To: <3F179BA8.8080005@opengroupware.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: > Yes, but it might be complicate to setup since the developer needs to > fiddle around with all those environment sourcing which is a bit > difficult in Finder. > And the build-results should definitely be independend from GNUstep, > that is, the build process should create frameworks and bundles usable > without the GNUstep environment. Yes - I agree. gnustep-make should only be required when building. But for building, it works nicely for me, and it's quite easy to do. > Nicola has shown that this can work with Renaissance. Yes. It works nicely for me. Much more nicely than having to support PBX files, which would be difficult for me since I'm almost always on a linux box (left my Apple in Italy, so I rarely touch it now), and PBX files are inherently difficult to edit by hand. With Renaissance I can change the makefiles in linux, and be reasonably confident that if it compiles on linux, the result will build according to the new makefiles on Apple as well. If you attempt this route, please get/use the latest gnustep-make from CVS, and please contribute back to the main gnustep-make all changes and enhancements you do. Sharing is the root of success. :-) From helge.hess@opengroupware.org Fri Jul 18 15:11:56 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id CD9FF18F6EA; Fri, 18 Jul 2003 15:11:56 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 03594-02; Fri, 18 Jul 2003 15:11:56 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id E727918F6AC; Fri, 18 Jul 2003 15:11:55 +0200 (CEST) Received: from opengroupware.org (unknown [213.211.192.194]) by imap.mdlink.de (Postfix) with ESMTP id 050B85708E; Fri, 18 Jul 2003 15:17:33 +0200 (CEST) In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v578) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <2A3362E6-B922-11D7-B026-000393C29C2A@opengroupware.org> Content-Transfer-Encoding: 7bit Cc: macosx@opengroupware.org From: Helge Hess Subject: Re: [OGo-GNUstep-Port] Re: [OGo-Developer] Roadmap and Versioning Date: Fri, 18 Jul 2003 15:17:21 +0200 To: gnustep-port@opengroupware.org X-Mailer: Apple Mail (2.578) X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Freitag, 18. Juli 2003, at 14:50 Uhr, Nicola Pero wrote: >> Is there a problem using gnustep-make on OSX (Nicola ?) >> I think MOSX could use it :) > > Yes. I don't think there is anything wrong with using PBX, but using > gnustep-make should be very easy, and be cross-platform. You can check > Renaissance. Problem is, that compilation for PBX users isn't that easy. We would need at least detailed instructions on how to setup the environment. Or we write some "make" wrapper (maybe gsmake) which sources GNUstep.sh prior forking make. Then we have the Xcode issue, not sure whether it will still support legacy targets. But I agree, we should start out using gstep-make and can add "proper" PBX files later. The PBX projects could support both, GNUstep make and own targets at the same time (and I actually think I prepared them that way). > We can probably improve on the framework vs library support. I guess we should resolve this issue first, IMHO it's a very important one. We should in no case use frameworks on any other OS but OSX. And we should definitely use frameworks on OSX. Since this is a pretty general topic, I think it should be covered by library.make (maybe supporting a XXX_NO_FRAMEWORK bool variable for disabling frameworks on OSX, so that they can still be used for libraries on that platform). regards, Helge -- OpenGroupware.org - http://www.opengroupware.org/ From helge.hess@opengroupware.org Fri Jul 18 15:21:55 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 9519C18F6F4; Fri, 18 Jul 2003 15:21:55 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 07158-03; Fri, 18 Jul 2003 15:21:54 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id C319E18F6EA; Fri, 18 Jul 2003 15:21:54 +0200 (CEST) Received: from opengroupware.org (unknown [213.211.192.194]) by imap.mdlink.de (Postfix) with ESMTP id 249FECD7F0; Fri, 18 Jul 2003 15:27:32 +0200 (CEST) In-Reply-To: References: Mime-Version: 1.0 (Apple Message framework v578) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <8F3A9ED7-B923-11D7-B026-000393C29C2A@opengroupware.org> Content-Transfer-Encoding: 7bit Cc: gnustep-port@opengroupware.org From: Helge Hess Subject: Re: [OGo-MacOSX] Re: [OGo-GNUstep-Port] Cocoa Porting, was: Re: [OGo-Developer] Roadmap and Versioning Date: Fri, 18 Jul 2003 15:27:20 +0200 To: macosx@opengroupware.org X-Mailer: Apple Mail (2.578) X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Freitag, 18. Juli 2003, at 14:59 Uhr, Nicola Pero wrote: > If you attempt this route, please get/use the latest gnustep-make from > CVS, and please contribute back to the main gnustep-make all changes > and > enhancements you do. Sharing is the root of success. :-) Yes, this needs to be done, but it may be a bit hard since OGo gstep-make has changes which need to be merged and which may conflict with "official" GNUstep make policies. It also contains some workarounds around "weird" bugs we found during package building on some old distributions. Also I definitely want to keep a "proven" gstep-make in CVS, GNUstep make wasn't very stable in the past changing a lot of things like pathes which are certainly important for GNUstep in it's state, but would break too much code considered stable in OGo. So I would suggest that we find a way where the OGo sources work with the OGo gstep-make and with the "official" GNUstep make packages at the same time. Does gstep-make allow USER_ROOT=SYSTEM_ROOT=LOCAL_ROOT ? (aka a --with-user-root configure option ?). regards, Helge -- OpenGroupware.org - http://www.opengroupware.org/ From helge.hess@opengroupware.org Fri Jul 18 17:14:22 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 4FAA418F6EA for ; Fri, 18 Jul 2003 17:14:22 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 03770-02 for ; Fri, 18 Jul 2003 17:14:21 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 115E718F6AC for ; Fri, 18 Jul 2003 17:14:21 +0200 (CEST) Received: from opengroupware.org (unknown [213.211.192.194]) by imap.mdlink.de (Postfix) with ESMTP id 4AC395E330 for ; Fri, 18 Jul 2003 17:20:05 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v578) In-Reply-To: References: Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <577993A4-B933-11D7-8201-00039340AF4A@opengroupware.org> Content-Transfer-Encoding: 7bit From: Helge Hess Subject: Re: [OGo-GNUstep-Port] Re: Patches Date: Fri, 18 Jul 2003 17:20:19 +0200 To: gnustep-port@opengroupware.org X-Mailer: Apple Mail (2.578) X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Freitag, 18. Juli 2003, at 13:41 Uhr, Nicola Pero wrote: >> Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be >> selected even for Cocoa and libFoundation when used with gstep-make, >> right ? > > No. gnustep-make/base #define GNUSTEP if and only if gnustep-base is > being used. GNUSTEP and GNUSTEP_BASE_LIBRARY are equivalent. Well, that doesn't make a lot of sense to me. Either GNUSTEP is different to GNUSTEP_BASE_LIBRARY (what does it mean then, gnu-gnu-gnu library combo ?) or if it is the same like GNUSTEP_BASE_LIBRARY, it should be removed. In any case GNUSTEP_BASE_LIBRARY is what was *meant* in the source code (since the section is gstep-base specific) and should be used. In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting base-library specific sections (just like we use LIB_FOUNDATION_LIBRARY and APPLE_FOUNDATION_LIBRARY, case may differ). > I know OGo's own makefile #defines GNUSTEP if gnustep-make is being > used, > but that's OGo's own strange quirk which should be removed (see my > previous posts before replying). The macro GNUSTEP should of course be > #defined by gnustep itself, not by OGo's makefile. I guess GNUSTEP is used instead of something like GNUSTEP_MAKEFILES_ACTIVE, but I don't see the point of it anyway then. I think we need to distinguish two things: a) is gstep-make used for compilation or not b) is gstep-make used at runtime or not (eg use env for resource lookup) (didn't found a previous post of you, sorry ;-) > To setup the parallel installation you can use library-combos - if you > do > make sure to enable library-combos when ./configuring gnustep-make, as > they are disabled by default in the latest gnustep-make (at popular > request). Well, if that actually works in practice ;-) regards, Helge -- OpenGroupware.org http://www.opengroupware.org/ From nicola@brainstorm.co.uk Fri Jul 18 17:40:20 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 9C01418F6D6 for ; Fri, 18 Jul 2003 17:40:19 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 28895-02 for ; Fri, 18 Jul 2003 17:40:18 +0200 (CEST) Received: from mail.brainstorm.co.uk (smtp.brainstorm.co.uk [217.169.5.196]) by mail.opengroupware.org (Postfix) with ESMTP id 51E7D18F6D5 for ; Fri, 18 Jul 2003 17:40:15 +0200 (CEST) Received: from nicola.brainstorm.co.uk (IDENT:lOKchPDEPweyALpEnuLqH+nwr1AoBIUU@nicola.brainstorm.co.uk [192.168.4.138]) by mail.brainstorm.co.uk (8.11.4/8.11.4) with ESMTP id h6IFjmO16021 for ; Fri, 18 Jul 2003 16:45:48 +0100 Date: Fri, 18 Jul 2003 16:50:10 +0100 (BST) From: Nicola Pero To: gnustep-port@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Re: Patches In-Reply-To: <577993A4-B933-11D7-8201-00039340AF4A@opengroupware.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: > >> Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be > >> selected even for Cocoa and libFoundation when used with gstep-make, > >> right ? > > > > No. gnustep-make/base #define GNUSTEP if and only if gnustep-base is > > being used. GNUSTEP and GNUSTEP_BASE_LIBRARY are equivalent. > > Well, that doesn't make a lot of sense to me. Either GNUSTEP is > different to GNUSTEP_BASE_LIBRARY (what does it mean then, gnu-gnu-gnu > library combo ?) or if it is the same like GNUSTEP_BASE_LIBRARY, it > should be removed. GNUSTEP really means *-gnu-gnu, while GNUSTEP_BASE_LIBRARY means *-gnu-*. In OGo's case, the gui part of the library combo does not count, moreover at the moment gnustep-base implies gnustep-gui (which is not going to change unless Apple ports their AppKit to run on gnustep), so the two are equivalent from your point of view. You can use GNUSTEP_BASE_LIBRARY and forget about GNUSTEP if you think it's the only name which makes sense of the two. In that case, please remove any GNUSTEP define in your code to avoid conflicts with the other usage. > In any case GNUSTEP_BASE_LIBRARY is what was *meant* in the source code > (since the section is gstep-base specific) and should be used. Ok. That's fine then. > In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting > base-library specific sections (just like we use LIB_FOUNDATION_LIBRARY > and APPLE_FOUNDATION_LIBRARY, case may differ). Ok. I'm absolutely happy with that. APPLE_FOUNDATION_LIBRARY is not currently defined in gnustep-make, but we can add it (I'd like the #defines used in OGo, and the ones generally #defined by gnustep-make and which everyone else is using, to match). > > I know OGo's own makefile #defines GNUSTEP if gnustep-make is being used, > > but that's OGo's own strange quirk which should be removed (see my > > previous posts before replying). The macro GNUSTEP should of course be > > #defined by gnustep itself, not by OGo's makefile. > > I guess GNUSTEP is used instead of something like > GNUSTEP_MAKEFILES_ACTIVE, but I don't see the point of it anyway then. > > I think we need to distinguish two things: > a) is gstep-make used for compilation or not > b) is gstep-make used at runtime or not (eg use env for resource lookup) How important is it to know inside the Objective-C source code if gnustep-make is used or not ? If it is, maybe gnustep-make should #define something itself to let code know it's being used to compile. > (didn't found a previous post of you, sorry ;-) http://mail.opengroupware.org/pipermail/gnustep-port/2003-July/000002.html From mechanix@slider.rack66.net Fri Jul 18 20:22:39 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id CC57718F545; Fri, 18 Jul 2003 20:22:39 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 20855-08; Fri, 18 Jul 2003 20:22:38 +0200 (CEST) Received: from slider.rack66.net (slider.rack66.net [212.3.252.135]) by mail.opengroupware.org (Postfix) with ESMTP id B62A618F51C; Fri, 18 Jul 2003 20:22:38 +0200 (CEST) Received: by slider.rack66.net (Postfix, from userid 1026) id 3A8A3F257; Fri, 18 Jul 2003 20:28:18 +0200 (CEST) Date: Fri, 18 Jul 2003 20:28:18 +0200 From: Filip Van Raemdonck To: gnustep-port@opengroupware.org Cc: patches@opengroupware.org Message-ID: <20030718182818.GB29813@debian> Mail-Followup-To: gnustep-port@opengroupware.org, patches@opengroupware.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="WhfpMioaduB5tiZL" Content-Disposition: inline User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] NSString extensions Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: --WhfpMioaduB5tiZL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Some string extensions used in OGo are not in gnustep-base anymore; attached is a patch which fixes that by changing the conditions whether they should be built internally or not. Also in the patch are two more small fixes, one for (not) linking Foundation extensions and another for (not) including Foundation extension headers. Regards, Filip -- www.benefon.fi is running Microsoft-IIS/4.0 on Solaris neat trick hmms. how come I think that netcraft is on crack --WhfpMioaduB5tiZL Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=diff-skyrix-core --- opengroupware.org-core-0.9.0cvs20030718.orig/NGExtensions/FdExt.subproj/NSString+misc.m +++ opengroupware.org-core-0.9.0cvs20030718/NGExtensions/FdExt.subproj/NSString+misc.m @@ -20,9 +20,9 @@ */ // $Id: NSString+misc.m,v 1.3 2003/07/11 17:12:49 jan Exp $ -#import "common.h" -#import "NGMemoryAllocation.h" -#import "NSString+misc.h" +#include "common.h" +#include "NGMemoryAllocation.h" +#include "NSString+misc.h" #if !LIB_FOUNDATION_LIBRARY && !GNUSTEP_BASE_LIBRARY # import @@ -66,7 +66,7 @@ } buffer[pos] = '\0'; -#if NeXT_Foundation_LIBRARY +#if NeXT_Foundation_LIBRARY || GNUSTEP_BASE_LIBRARY { NSString *s; --- opengroupware.org-core-0.9.0cvs20030718.orig/NGExtensions/NGExtensions/NSString+Ext.h +++ opengroupware.org-core-0.9.0cvs20030718/NGExtensions/NGExtensions/NSString+Ext.h @@ -23,31 +23,40 @@ #ifndef __NGExtensions_NSString_Ext_H__ #define __NGExtensions_NSString_Ext_H__ #import -/* specific to gstep-base, supported in libFoundation */ +#if !LIB_FOUNDATION_LIBRARY + +@interface NSString(lfNSURLUtilities) + +- (BOOL)isAbsoluteURL; +- (NSString *)urlScheme; -#if !LIB_FOUNDATION_LIBRARY && !GNUSTEP_BASE_LIBRARY +@end @interface NSString(GSAdditions) +/* the following are not available in gstep-base 1.6 */ + - (NSString *)stringWithoutPrefix:(NSString *)_prefix; - (NSString *)stringWithoutSuffix:(NSString *)_suffix; +- (NSString *)stringByTrimmingLeadWhiteSpaces; +- (NSString *)stringByTrimmingTailWhiteSpaces; +- (NSString *)stringByTrimmingWhiteSpaces; + +#if !GNUSTEP_BASE_LIBRARY - (NSString *)stringByReplacingString:(NSString *)_orignal withString:(NSString *)_replacement; - (NSString *)stringByTrimmingLeadSpaces; - (NSString *)stringByTrimmingTailSpaces; - (NSString *)stringByTrimmingSpaces; - -/* the following are not available in gstep-base 1.6 ? */ -- (NSString *)stringByTrimmingLeadWhiteSpaces; -- (NSString *)stringByTrimmingTailWhiteSpaces; -- (NSString *)stringByTrimmingWhiteSpaces; +#endif @end /* NSString(GSAdditions) */ +#if !GNUSTEP_BASE_LIBRARY @interface NSMutableString(GNUstepCompatibility) - (void)trimLeadSpaces; @@ -55,20 +64,8 @@ - (void)trimSpaces; @end /* NSMutableString(GNUstepCompatibility) */ +#endif /* !GNUSTEP_BASE_LIBRARY */ -#endif - -/* specific to libFoundation */ - -#if !LIB_FOUNDATION_LIBRARY - -@interface NSString(lfNSURLUtilities) - -- (BOOL)isAbsoluteURL; -- (NSString *)urlScheme; - -@end - -#endif +#endif /* !LIB_FOUNDATION_LIBRARY */ #endif /* __NGExtensions_NSString_Ext_H__ */ --- opengroupware.org-core-0.9.0cvs20030718.orig/NGStreams/GNUmakefile.preamble +++ opengroupware.org-core-0.9.0cvs20030718/NGStreams/GNUmakefile.preamble @@ -10,7 +10,7 @@ endif ifeq ($(FOUNDATION_LIB),nx) -libNGStreams_LIBRARIES_DEPEND_UPON += -lFoundationExt +#libNGStreams_LIBRARIES_DEPEND_UPON += -lFoundationExt endif ifeq ($(reentrant),yes) --- opengroupware.org-core-0.9.0cvs20030718.orig/NGStreams/common.h +++ opengroupware.org-core-0.9.0cvs20030718/NGStreams/common.h @@ -25,7 +25,7 @@ // common include files -#import +#include // configuration @@ -55,8 +55,10 @@ # import # import #else +#ifndef GNUSTEP_BASE_LIBRARY # include #endif +#endif #if !LIB_FOUNDATION_LIBRARY && !NeXT_Foundation_LIBRARY # define NSWillBecomeMultiThreadedNotification NSBecomingMultiThreaded --WhfpMioaduB5tiZL-- From helge.hess@opengroupware.org Fri Jul 18 22:04:00 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id EC50718F545 for ; Fri, 18 Jul 2003 22:03:59 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 19225-04 for ; Fri, 18 Jul 2003 22:03:58 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id D0C2518F51C for ; Fri, 18 Jul 2003 22:03:58 +0200 (CEST) Received: from opengroupware.org (unknown [213.211.192.194]) by imap.mdlink.de (Postfix) with ESMTP id 8FB34CEE09 for ; Fri, 18 Jul 2003 22:09:53 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v578) In-Reply-To: References: Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Helge Hess Subject: Re: [OGo-GNUstep-Port] Re: Patches Date: Fri, 18 Jul 2003 22:09:39 +0200 To: gnustep-port@opengroupware.org X-Mailer: Apple Mail (2.578) X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Freitag, 18. Juli 2003, at 17:50 Uhr, Nicola Pero wrote: > GNUSTEP really means *-gnu-gnu, while GNUSTEP_BASE_LIBRARY means > *-gnu-*. OK. > You can use GNUSTEP_BASE_LIBRARY and forget about GNUSTEP if you think > it's the only name which makes sense of the two. In the case of OGo it's obviously the one and only correct selection since OGo code only cares about Foundation. And #ifdef GNUSTEP would imply a dependency on gui, which it has not. I also like the consistency in the naming (XXX_Foundation_LIBRARY). > In that case, please remove any GNUSTEP define in your code to avoid > conflicts with the other usage. Can anyone provide a patch for that ? Is it really used somewhere ? Actually I think it isn't used anywhere, but I'm not sure. >> In any case GNUSTEP_BASE_LIBRARY is what was *meant* in the source >> code >> (since the section is gstep-base specific) and should be used. > Ok. That's fine then. Yup :-) Didn't want to be offend, just wanted to point out how we do things, after all this is not a GNUstep project ;-) >> In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting >> base-library specific sections (just like we use >> LIB_FOUNDATION_LIBRARY >> and APPLE_FOUNDATION_LIBRARY, case may differ). > > Ok. I'm absolutely happy with that. APPLE_FOUNDATION_LIBRARY is not > currently defined in gnustep-make, but we can add it (I'd like the > #defines used in OGo, and the ones generally #defined by gnustep-make > and > which everyone else is using, to match). I currently mix up NeXT_Foundation_LIBRARY and APPLE_Foundation_LIBRARY all over the code. It does mean the same to OGo source code :-( Anyone willing to provide a patch for that ? Actually I think we use COCOA_Foundation_LIBRARY, not APPLE. I don't know, someone just needs to clear that up and send a patch. Didn't say that MacOSX port is ready, said that it needs quite some work ;-) >> I guess GNUSTEP is used instead of something like >> GNUSTEP_MAKEFILES_ACTIVE, but I don't see the point of it anyway then. >> >> I think we need to distinguish two things: >> a) is gstep-make used for compilation or not >> b) is gstep-make used at runtime or not (eg use env for resource >> lookup) > > How important is it to know inside the Objective-C source code if > gnustep-make is used or not ? If it is, maybe gnustep-make should > #define > something itself to let code know it's being used to compile. Good question. I think it definitely needs to know whether it is compiled *for* a GNUstep environment (I suggested to split GNUstep-make into GNUstep-env and -make long time ago :-( ), so that we know whether we should consider the GNUSTEP_XXX variables. >> (didn't found a previous post of you, sorry ;-) > http://mail.opengroupware.org/pipermail/gnustep-port/2003-July/ > 000002.html Ah, OK. Well, this contains some errors (which you corrected above) and you should document the exact meanings of the define somewhere, eg: ---snip--- The theory is that GNUSTEP is a GNUstep specific #define, and is #defined by gnustep-base to let the code know that gnustep-base is being used (check core/base/base.make). Which makes sense after all. ---snap--- As we all know now, it specifies a gnustep-base + gnustep-gui (and should be defined by gnustep-make, since gnustep-base can't know whether it's used with gnustep-gui. I think we can stay with NeXT_Foundation_LIBRARY. best regards, Helge -- OpenGroupware.org - http://www.opengroupware.org/ From mechanix@slider.rack66.net Fri Jul 18 22:31:58 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 181FB18F545 for ; Fri, 18 Jul 2003 22:31:58 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 27283-02 for ; Fri, 18 Jul 2003 22:31:57 +0200 (CEST) Received: from slider.rack66.net (slider.rack66.net [212.3.252.135]) by mail.opengroupware.org (Postfix) with ESMTP id 393E318F51C for ; Fri, 18 Jul 2003 22:31:57 +0200 (CEST) Received: by slider.rack66.net (Postfix, from userid 1026) id 3F04FF21A; Fri, 18 Jul 2003 22:37:38 +0200 (CEST) Date: Fri, 18 Jul 2003 22:37:38 +0200 From: Filip Van Raemdonck To: gnustep-port@opengroupware.org Subject: Re: [OGo-GNUstep-Port] Re: Patches Message-ID: <20030718203738.GC29813@debian> Mail-Followup-To: gnustep-port@opengroupware.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Fri, Jul 18, 2003 at 10:09:39PM +0200, Helge Hess wrote: > On Freitag, 18. Juli 2003, at 17:50 Uhr, Nicola Pero wrote: >> >> In that case, please remove any GNUSTEP define in your code to avoid >> conflicts with the other usage. > > Is it really used somewhere? It is defined in some files, but not actually used anywhere it seems: mechanix@yggdrasil:opengroupware.org$ grep -r [^_-]GNUSTEP[^_-] OpenGroupware.org/ | grep -v ChangeLog | grep -v '/\*' OpenGroupware.org/SOPE/skyrix-core/NGExtensions/common.h:# define GNUSTEP 1 OpenGroupware.org/SOPE/skyrix-core/NGExtensions/common.h:# define GNUSTEP 0 OpenGroupware.org/SOPE/skyrix-core/NGExtensions/common.h:# define GNUSTEP 1 OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:# define GNUSTEP 1 OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:# define GNUSTEP 1 OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:# define GNUSTEP 0 OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:# define GNUSTEP 1 OpenGroupware.org/ThirdParty/libFoundation/Foundation/libFoundation.make.in:FND_DEFINE = -DLIB_FOUNDATION_LIBRARY=1 -DFD_WITH_GSMAKE=1 -DGNUSTEP=1 OpenGroupware.org/ThirdParty/libFoundation/Foundation/libFoundation.make.in:GNUSTEP_DEFINE = -DGNUSTEP=1 -DWITH_GSTEP_MAKE=1 >>> In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting >>> base-library specific sections Doing that now for new changes. What about makefiles? Anything specific to use / check for there, if needed? Regards, Filip -- "The only stupid question is the unasked one." -- Martin Schulze From mechanix@slider.rack66.net Fri Jul 18 23:14:17 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id BAC7A18F545 for ; Fri, 18 Jul 2003 23:14:17 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 09305-08 for ; Fri, 18 Jul 2003 23:14:16 +0200 (CEST) Received: from slider.rack66.net (slider.rack66.net [212.3.252.135]) by mail.opengroupware.org (Postfix) with ESMTP id DB27918F518 for ; Fri, 18 Jul 2003 23:14:16 +0200 (CEST) Received: by slider.rack66.net (Postfix, from userid 1026) id 5D6B0F209; Fri, 18 Jul 2003 23:19:54 +0200 (CEST) Date: Fri, 18 Jul 2003 23:19:49 +0200 From: Filip Van Raemdonck To: gnustep-port@opengroupware.org Message-ID: <20030718211937.GD29813@debian> Mail-Followup-To: gnustep-port@opengroupware.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Subject: [OGo-GNUstep-Port] gcc 3 warnings Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: Hi, Gcc 3 is a bit more picky about some things, and some of the complaints it has go like this: SoHTTPAuthenticator.m: In function `-[SoHTTPAuthenticator authRealm]': SoHTTPAuthenticator.m:45: warning: multiple declarations for method `name' /usr/lib/gcc-lib/i386-linux/3.3.1/include/objc/Object.h:59: warning: using `-(const char *)name' /usr/lib/GNUstep/System/Headers/NGMime/NGMimeHeaderFields.h:58: warning: also found `-(NSString *)name' /usr/lib/GNUstep/System/Headers/NGExtensions/EOGrouping.h:82: warning: also found `-(NSString *)name' /usr/lib/GNUstep/System/Headers/Foundation/NSTimeZone.h:66: warning: also found `-(NSString *)name' /usr/lib/GNUstep/System/Headers/Foundation/NSHost.h:68: warning: also found `-(NSString *)name' /usr/lib/GNUstep/System/Headers/Foundation/NSNotification.h:52: warning: also found `-(NSString *)name' ../NGObjWeb/WOApplication.h:64: warning: also found `-(NSString *)name' /usr/lib/GNUstep/System/Headers/Foundation/NSException.h:61: warning: also found `-(NSString *)name' SoHTTPAuthenticator.m:45: warning: return from incompatible pointer type Now there are depending on the situation two or one solutions to get rid of these, AFAICT. The first is, where messages are sent which are defined in OGo specific classes, not to use too generic names for these methods so that they don't clash with others. The second is typecasting the recievers to the class from which the desired method is. For new methods, IMHO it's a good idea to use the first solution as it has the added benefit of (usually) making it easier to go find out where a specific method comes from when reading some code. However, it's a lot of work to change that through out an entire source tree, and it's error prone. So, would it be ok to typecast receivers as per the second solution to fix these warnings? Any objections? Regards, Filip -- "From a security perspective, Bluetooth is a disaster waiting to happen." -- Martin Reynolds From helge.hess@opengroupware.org Sat Jul 19 01:21:41 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 513DA18F70F for ; Sat, 19 Jul 2003 01:21:41 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 09982-05 for ; Sat, 19 Jul 2003 01:21:40 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 6B94C18F70B for ; Sat, 19 Jul 2003 01:21:40 +0200 (CEST) Received: from opengroupware.org (unknown [213.211.192.194]) by imap.mdlink.de (Postfix) with ESMTP id DF4E5CDAC6 for ; Sat, 19 Jul 2003 01:27:38 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v578) In-Reply-To: <20030718211937.GD29813@debian> References: <20030718211937.GD29813@debian> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <6255B2E4-B977-11D7-BC19-000393C29C2A@opengroupware.org> Content-Transfer-Encoding: 7bit From: Helge Hess Subject: Re: [OGo-GNUstep-Port] gcc 3 warnings Date: Sat, 19 Jul 2003 01:27:23 +0200 To: gnustep-port@opengroupware.org X-Mailer: Apple Mail (2.578) X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Freitag, 18. Juli 2003, at 23:19 Uhr, Filip Van Raemdonck wrote: > Gcc 3 is a bit more picky about some things, and some of the > complaints it > has go like this: I know, we already fixed a lot of that stuff, but not everything :-( Actually it is not picky, but rather follows the spec (AFAIK Nicola has fixed the compiler which previously did not consider ObjC typing at all). > SoHTTPAuthenticator.m: In function `-[SoHTTPAuthenticator authRealm]': > SoHTTPAuthenticator.m:45: warning: multiple declarations for method > `name' ... > Now there are depending on the situation two or one solutions to get > rid > of these, AFAICT. > > The first is, where messages are sent which are defined in OGo specific > classes, not to use too generic names for these methods so that they > don't > clash with others. Well: a) this would be completely against the Smalltalk idea of ObjC, names should be the same if they do similiar things (like -name) b) it would be an unacceptable change to source code potentially breaking a lot of things > The second is typecasting the recievers to the class from which the > desired method is. This is the way to go, even being ugly, I admit :-( > For new methods, IMHO it's a good idea to use the first solution as it > has > the added benefit of (usually) making it easier to go find out where a > specific method comes from when reading some code. No, it's absolutely no good idea and is against all OO programming principles. Either you disable those warnings (because they are just warnings!) or you cast if you want to use the type system of C. We'll prefer the latter. > However, it's a lot of work to change that through out an entire source > tree, and it's error prone. Exactly. Not an option. > So, would it be ok to typecast receivers as per the second solution to > fix these warnings? Any objections? Yes, this is the way to go. It also makes the actual type of the receiver explicit which is not necessarily a bad thing. Thanks for your work! Helge -- OpenGroupware.org - http://www.opengroupware.org/ From helge.hess@opengroupware.org Sun Jul 20 13:39:45 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id 5012918F7AE for ; Sun, 20 Jul 2003 13:39:45 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 11472-05 for ; Sun, 20 Jul 2003 13:39:44 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 7E9DF18F7A0 for ; Sun, 20 Jul 2003 13:39:44 +0200 (CEST) Received: from opengroupware.org (unknown [213.211.192.194]) by imap.mdlink.de (Postfix) with ESMTP id C0F36D142B for ; Sun, 20 Jul 2003 13:46:25 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v578) In-Reply-To: <20030718203738.GC29813@debian> References: <20030718203738.GC29813@debian> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Helge Hess Subject: Re: [OGo-GNUstep-Port] Re: Patches Date: Sun, 20 Jul 2003 13:45:58 +0200 To: gnustep-port@opengroupware.org X-Mailer: Apple Mail (2.578) X-Virus-Scanned: by amavisd-new-20030314-p2 (Debian) at opengroupware.org Sender: gnustep-port-admin@opengroupware.org Errors-To: gnustep-port-admin@opengroupware.org X-BeenThere: gnustep-port@opengroupware.org X-Mailman-Version: 2.0.11 Precedence: bulk Reply-To: gnustep-port@opengroupware.org List-Help: List-Post: List-Subscribe: , List-Id: GNUstep Porting List-Unsubscribe: , List-Archive: On Freitag, 18. Juli 2003, at 22:37 Uhr, Filip Van Raemdonck wrote: >>> In that case, please remove any GNUSTEP define in your code to avoid >>> conflicts with the other usage. >> Is it really used somewhere? > > It is defined in some files, but not actually used anywhere it seems: I'll remove it tomorrow. It was probably used in a "historic" OSX port. >>>> In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting >>>> base-library specific sections > Doing that now for new changes. Excellent :-) > What about makefiles? Anything specific to use / check for there, if > needed? Just the usual check: --- ifeq ($(FOUNDATION_LIB),gnu) --- Thanks a lot, Helge -- OpenGroupware.org - http://www.opengroupware.org/ From helge.hess@opengroupware.org Mon Jul 21 19:51:30 2003 Return-Path: Delivered-To: gnustep-port@opengroupware.org Received: from localhost (mail.opengroupware.org [213.211.192.141]) by mail.opengroupware.org (Postfix) with ESMTP id F2EDC18F521 for ; Mon, 21 Jul 2003 19:51:29 +0200 (CEST) Received: from mail.opengroupware.org ([213.211.192.141]) by localhost (mail [213.211.192.141]) (amavisd-new, port 10024) with ESMTP id 20070-03 for ; Mon, 21 Jul 2003 19:51:29 +0200 (CEST) Received: from mail.mdlink.net (medusa.mdlink.de [213.211.192.34]) by mail.opengroupware.org (Postfix) with ESMTP id 6C70C18F51C for ; Mon, 21 Jul 2003 19:51:29 +0200 (CEST) Received: from opengroupware.org (unknown [213.211.192.194]) by imap.mdlink.de (Postfix) with ESMTP id 8F7DFD1EFD for ; Mon, 21 Jul 2003 19:59:06 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v578) In-Reply-