[OGo-GNUstep-Port] Re: Patches

[Helge Hess]

Hi,

regarding the patches.

The skyrix-xml patches are all applied in CVS. But various things in 
core are dubious and I'm still inspecting them ;-)

eg:
---
-#if NeXT_Foundation_LIBRARY
+#if NeXT_Foundation_LIBRARY || GNUSTEP
---

Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be 
selected even for Cocoa and libFoundation when used with gstep-make, right ?

Note: I won't accept any patches which will break Cocoa or 
libFoundation. I definitely do not want to have the mess which happend 
with gstep-gui, which back when Ovidiu worked on it happened to work 
with any Foundation (even the NeXT one) and now has a lot of ties into 
gstep-base internals.
Please take care that lF and Cocoa compatibility are not broken.

I would actually prefer that all of you have a parallel 
libFoundation/OGo-gstep-base installation to ensure that patches 
actually work (lessens workload on me ;-).

best regards,
   Helge
-- 
http://www.opengroupware.org/