[OGo-GNUstep-Port] Re: Patches

[Nicola Pero]

> eg:
> ---
> -#if NeXT_Foundation_LIBRARY
> +#if NeXT_Foundation_LIBRARY || GNUSTEP
> ---
> 
> Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be 
> selected even for Cocoa and libFoundation when used with gstep-make, right ?

No.  gnustep-make/base #define GNUSTEP if and only if gnustep-base is
being used.  GNUSTEP and GNUSTEP_BASE_LIBRARY are equivalent.

I know OGo's own makefile #defines GNUSTEP if gnustep-make is being used,
but that's OGo's own strange quirk which should be removed (see my
previous posts before replying).  The macro GNUSTEP should of course be
#defined by gnustep itself, not by OGo's makefile.

 
> Note: I won't accept any patches which will break Cocoa or
> libFoundation.

That is fine.  I agree.


> I would actually prefer that all of you have a parallel 
> libFoundation/OGo-gstep-base installation to ensure that patches 
> actually work (lessens workload on me ;-).

To setup the parallel installation you can use library-combos - if you do
make sure to enable library-combos when ./configuring gnustep-make, as
they are disabled by default in the latest gnustep-make (at popular
request).