[OGo-GNUstep-Port] Re: Patches

[Helge Hess]

On Freitag, 18. Juli 2003, at 13:41 Uhr, Nicola Pero wrote:
>> Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be
>> selected even for Cocoa and libFoundation when used with gstep-make, 
>> right ?
>
> No.  gnustep-make/base #define GNUSTEP if and only if gnustep-base is
> being used.  GNUSTEP and GNUSTEP_BASE_LIBRARY are equivalent.

Well, that doesn't make a lot of sense to me. Either GNUSTEP is 
different to GNUSTEP_BASE_LIBRARY (what does it mean then, gnu-gnu-gnu 
library combo ?) or if it is the same like GNUSTEP_BASE_LIBRARY, it 
should be removed.

In any case GNUSTEP_BASE_LIBRARY is what was *meant* in the source code 
(since the section is gstep-base specific) and should be used.

In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting 
base-library specific sections (just like we use LIB_FOUNDATION_LIBRARY 
and APPLE_FOUNDATION_LIBRARY, case may differ).

> I know OGo's own makefile #defines GNUSTEP if gnustep-make is being 
> used,
> but that's OGo's own strange quirk which should be removed (see my
> previous posts before replying).  The macro GNUSTEP should of course be
> #defined by gnustep itself, not by OGo's makefile.

I guess GNUSTEP is used instead of something like 
GNUSTEP_MAKEFILES_ACTIVE, but I don't see the point of it anyway then.
I think we need to distinguish two things:
a) is gstep-make used for compilation or not
b) is gstep-make used at runtime or not (eg use env for resource lookup)

(didn't found a previous post of you, sorry ;-)

> To setup the parallel installation you can use library-combos - if you 
> do
> make sure to enable library-combos when ./configuring gnustep-make, as
> they are disabled by default in the latest gnustep-make (at popular
> request).

Well, if that actually works in practice ;-)

regards,
   Helge
-- 
OpenGroupware.org	http://www.opengroupware.org/