[OGo-GNUstep-Port] Re: Patches

[Nicola Pero]

> >> Shouldn't that be || GNUSTEP_BASE_LIBRARY ? Otherwise the code will be
> >> selected even for Cocoa and libFoundation when used with gstep-make, 
> >> right ?
> >
> > No.  gnustep-make/base #define GNUSTEP if and only if gnustep-base is
> > being used.  GNUSTEP and GNUSTEP_BASE_LIBRARY are equivalent.
> 
> Well, that doesn't make a lot of sense to me. Either GNUSTEP is 
> different to GNUSTEP_BASE_LIBRARY (what does it mean then, gnu-gnu-gnu 
> library combo ?) or if it is the same like GNUSTEP_BASE_LIBRARY, it 
> should be removed.

GNUSTEP really means *-gnu-gnu, while GNUSTEP_BASE_LIBRARY means *-gnu-*.

In OGo's case, the gui part of the library combo does not count, moreover
at the moment gnustep-base implies gnustep-gui (which is not going to
change unless Apple ports their AppKit to run on gnustep), so the two are
equivalent from your point of view.

You can use GNUSTEP_BASE_LIBRARY and forget about GNUSTEP if you think
it's the only name which makes sense of the two.

In that case, please remove any GNUSTEP define in your code to avoid
conflicts with the other usage.

 
> In any case GNUSTEP_BASE_LIBRARY is what was *meant* in the source code 
> (since the section is gstep-base specific) and should be used.

Ok.  That's fine then.


> In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting 
> base-library specific sections (just like we use LIB_FOUNDATION_LIBRARY 
> and APPLE_FOUNDATION_LIBRARY, case may differ).

Ok.  I'm absolutely happy with that.  APPLE_FOUNDATION_LIBRARY is not
currently defined in gnustep-make, but we can add it (I'd like the
#defines used in OGo, and the ones generally #defined by gnustep-make and
which everyone else is using, to match).


> > I know OGo's own makefile #defines GNUSTEP if gnustep-make is being used,
> > but that's OGo's own strange quirk which should be removed (see my
> > previous posts before replying).  The macro GNUSTEP should of course be
> > #defined by gnustep itself, not by OGo's makefile.
> 
> I guess GNUSTEP is used instead of something like 
> GNUSTEP_MAKEFILES_ACTIVE, but I don't see the point of it anyway then.
>
> I think we need to distinguish two things:
> a) is gstep-make used for compilation or not
> b) is gstep-make used at runtime or not (eg use env for resource lookup)

How important is it to know inside the Objective-C source code if
gnustep-make is used or not ?  If it is, maybe gnustep-make should #define
something itself to let code know it's being used to compile.


> (didn't found a previous post of you, sorry ;-)

http://mail.opengroupware.org/pipermail/gnustep-port/2003-July/000002.html