[OGo-GNUstep-Port] Re: Patches

[Filip Van Raemdonck]

On Fri, Jul 18, 2003 at 10:09:39PM +0200, Helge Hess wrote:
> On Freitag, 18. Juli 2003, at 17:50 Uhr, Nicola Pero wrote:
>>
>> In that case, please remove any GNUSTEP define in your code to avoid
>> conflicts with the other usage.
>
> Is it really used somewhere?

It is defined in some files, but not actually used anywhere it seems:

mechanix@yggdrasil:opengroupware.org$ grep -r [^_-]GNUSTEP[^_-] OpenGroupware.org/ | grep -v ChangeLog | grep -v '/\*'
OpenGroupware.org/SOPE/skyrix-core/NGExtensions/common.h:#  define GNUSTEP  1
OpenGroupware.org/SOPE/skyrix-core/NGExtensions/common.h:#  define GNUSTEP  0
OpenGroupware.org/SOPE/skyrix-core/NGExtensions/common.h:#  define GNUSTEP  1
OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:#  define GNUSTEP  1
OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:#    define GNUSTEP 1
OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:#  define GNUSTEP  0
OpenGroupware.org/SOPE/skyrix-core/NGExtensions/NGExtensions/AutoDefines.h:#  define GNUSTEP  1
OpenGroupware.org/ThirdParty/libFoundation/Foundation/libFoundation.make.in:FND_DEFINE  = -DLIB_FOUNDATION_LIBRARY=1 -DFD_WITH_GSMAKE=1 -DGNUSTEP=1
OpenGroupware.org/ThirdParty/libFoundation/Foundation/libFoundation.make.in:GNUSTEP_DEFINE = -DGNUSTEP=1 -DWITH_GSTEP_MAKE=1

>>> In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting
>>> base-library specific sections

Doing that now for new changes.

What about makefiles? Anything specific to use / check for there, if
needed?


Regards,

Filip

-- 
"The only stupid question is the unasked one."
	-- Martin Schulze