[OGo-GNUstep-Port] Re: Patches

Helge Hess gnustep-port@opengroupware.org
Sun, 20 Jul 2003 13:45:58 +0200


On Freitag, 18. Juli 2003, at 22:37 Uhr, Filip Van Raemdonck wrote:
>>> In that case, please remove any GNUSTEP define in your code to avoid
>>> conflicts with the other usage.
>> Is it really used somewhere?
>
> It is defined in some files, but not actually used anywhere it seems:

I'll remove it tomorrow. It was probably used in a "historic" OSX port.

>>>> In other words: patches should use GNUSTEP_BASE_LIBRARY for denoting
>>>> base-library specific sections
> Doing that now for new changes.

Excellent :-)

> What about makefiles? Anything specific to use / check for there, if
> needed?

Just the usual check:
---
ifeq ($(FOUNDATION_LIB),gnu)
---

Thanks a lot,
   Helge
-- 
OpenGroupware.org	- http://www.opengroupware.org/