[OGo-GNUstep-Port] script API change
Filip Van Raemdonck
gnustep-port@opengroupware.org
Fri, 25 Jul 2003 14:19:49 +0200
--jq0ap7NbKX2Kqbes
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Hi,
This one I'm not sure about whether it's correct.
Apparently the scripting interface slightly changed in the past, adding an
argument to one message and removing one to another, but
NGObjWeb/WOScriptedComponent.m was not updated to reflect this change.
I've changed it into what I think is correct, but as I don't know the SOPE
API (and it's internals) all that well yet, I can't tell for sure.
Comments from someone in the knowing would be very welcome.
Regards,
Filip
--
"If we knew what it was we were doing, we wouldn't call it research."
-- Albert Einstein
--jq0ap7NbKX2Kqbes
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff-skyrix-sope-scripting
diff -ru skyrix-sope-old/NGObjWeb/WOScriptedComponent.m skyrix-sope-new/NGObjWeb/WOScriptedComponent.m
--- skyrix-sope-old/NGObjWeb/WOScriptedComponent.m 2003-07-23 10:52:10.000000000 +0200
+++ skyrix-sope-new/NGObjWeb/WOScriptedComponent.m 2003-07-25 13:10:54.000000000 +0200
@@ -127,7 +127,8 @@
- (id)evaluateScript:(NSString *)_script language:(NSString *)_lang
source:(NSString *)_src line:(unsigned)_line
{
- return [self->shadow evaluateScript:_script source:_src line:_line];
+ /* FIXME: is onObject: the right one? */
+ return [self->shadow evaluateScript:_script onObject:shadow source:_src line:_line];
}
/* notification mapping */
@@ -196,8 +197,9 @@
[self logWithFormat:@"KVC: for key %@ call %@(%@)",
_key, funcName, _value];
}
-
- result = [self->shadow callScriptFunction:funcName withObject:_value];
+
+ /* FIXME: no more withObject? */
+ result = [self->shadow callScriptFunction:funcName];
}
else {
[self logWithFormat:
--jq0ap7NbKX2Kqbes--