[OGo-GNUstep-Port] Re: skyrix-sope rangeOfString changes

Helge Hess gnustep-port@opengroupware.org
Mon, 28 Jul 2003 18:59:21 +0200


Filip Van Raemdonck wrote:
> Attached is a patch which converts all indexOfString calls in skyrix-sope to
> rangeOfString, as well as minimal other fixes (mostly typecasts, and a few
> ifdef GNUSTEP_BASE_LIBRARY things) in files touched by these rangeOfString
> changes.
> 
> Fairly straightforward I'd say; please apply.

Cleaned up and applied that.

Note: if you use rangeOfString, I consider this good style:

   r = [x rangeOfString:@"Action"];
   trailer = [x substringFromIndex:(r.location + r.length)];

instead of:
   trailer = [x substringFromIndex:(r.location + 6)];

much more secure regarding changes ;-)

regards,
   Helge
-- 
http://www.opengroupware.org/