From gnustep-port@opengroupware.org  Sun Jun  3 15:51:06 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Sun, 03 Jun 2007 16:51:06 +0200
Subject: [OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'
Message-ID: <20070603145106.E2B33404F7@l00-bugdead-prods.de>

Hi,

when opening the OGo Mail or Scheduler preferences page, ogo stopped with 
the exception:

Jun 03 16:03:36 ogo-webui-1.1 [25547]: |ogo-webui-1.1| 
<OpenGroupware[0x0x89e86208]: name=ogo-webui-1.1>: caught:
  <NSException: 0x7e5b1028> NAME:NSInvalidArgumentException 
REASON:setNilValueForKey: -- SkyCollapsibleContent 0x82eceb88: Given nil 
value to set for key "visibility"
in context:
  <0x0x8af4cc08[WOContext]: 0094662c9c78af4cc08 app=ogo-webui-1.1 
sn=63CB63CB014662C98B eid=0094662c9c78af4cc08.0.17.1.1.47 
rqeid=0084662c9c187206808.0.17.1.11.1.5.1.1.6.3>.

find the backtrace at the end.

I had to change the *.wod templates, whereever a SkyCollapsibleContents was 
called, I exchanged "visibility" with "visibilityDefault" like this example:

original:
EditorTitle: SkyCollapsibleContent {
  visibility       = session.userDefaults.scheduler_pref_expand_editor;
  submitActionName = "";
  title            = labels.EditorDefaults;
}
working version:
EditorTitle: SkyCollapsibleContent {
  visibilityDefault       = "scheduler_pref_expand_editor";
  submitActionName = "";
  title            = labels.EditorDefaults;
}

I don't know why it was not working when using the original version with 
visibility instead of visibilityDefault. I found the same on some other 
places, and changed it there too. Don't know whether this is the best idea, 
or a good one at all. But if it is, I could create a patch for testing.

kind regards
Sebastian

2007-06-03 16:01:44.475 ogo-webui-1.1[25547] 
OGoUIElements/SkyCollapsibleContent.m: init: initialized self <0x0x82eceb88
[SkyCollapsibleContent]: name=SkyCollapsibleContent>!!!!
2007-06-03 16:01:44.476 ogo-webui-1.1[25547] 
OGoUIElements/SkyCollapsibleContent.m: setVisibilityDefault: _defName: 0
Jun 03 16:01:44 ogo-webui-1.1 [25547]: [ERROR] SkyCollapsibleContent unable 
to set 'nil' for key: 'visibility'

Breakpoint 2, -[NSException raise] (self=0x7e5b1028, _cmd=0x2b541598)
    at NSException.m:782
782       if (GSPrivateEnvironmentFlag("GNUSTEP_STACK_TRACE", NO) == YES
(gdb) bt
#0  -[NSException raise] (self=0x7e5b1028, _cmd=0x2b541598)
    at NSException.m:782
#1  0x0b5215a2 in +[NSException raise:format:arguments:] (self=0x2b5413a0,
    _cmd=0x2b541580, name=0x2b5416dc, format=0x2b54725c,
    argList=0xcfbce890 "\b\020
[~&#65533;?&#65533;\204\210&#65533;&#65533;\202&#65533;>&#65533;\204=&#65533;Q+\210&#65533;&#65533;\202&#65533;&#65533;&#65533;&#1003;\024R\013=&#65533;Q+\230aW+

kU+\230aW+`kU+\210&#65533;&#65533;\2028&#65533;&#65533;&#65533;&#65533;\177_\013\210&#65533;&#65533;\202(&#65533;V+&#65533;>&#65533;\204\016}_\013")
at 
NSException.m:753
#2  0x0b5214f3 in +[NSException raise:format:] (self=0x2b5413a0,
    _cmd=0x2b547090, name=0x2b5416dc, format=0x2b54725c) at 
NSException.m:739
#3  0x0b541cd3 in -[NSObject(KeyValueCoding) setNilValueForKey:] (
    self=0x82eceb88, _cmd=0x2b56e228, aKey=0x84bc3ea8)
    at NSKeyValueCoding.m:274
#4  0x0b5f7fec in GSObjCSetVal (self=0x82eceb88, 
key=0xcfbce960 "visibility",
    val=0x0, sel=0x8867a520, type=0x814f3886 "C8", size=10, 
offset=246198076)
    at GSObjCRuntime.m:1817
#5  0x0b542ee3 in -[NSObject(KeyValueCoding) takeValue:forKey:] (
    self=0x82eceb88, _cmd=0x2ea6d810, anObject=0x0, aKey=0x851056c8)
    at NSKeyValueCoding.m:594
#6  0x0ea7427a in WOComponent_syncFromParent (self=0x82eceb88,
    _parent=0x7c073408) at WOComponent+Sync.m:120
#7  0x0ea78a2f in WOContext_enterComponent (self=0x8af4cc08,
    _component=0x82eceb88, _content=0x865e8988) at WOContext.m:430
#8  0x0ea9cc04 in -[WOChildComponentReference appendToResponse:inContext:] (
---Type <return> to continue, or q <return> to quit---
    self=0x83e80c08, _cmd=0x2ea8d270, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOChildComponentReference.m:187
#9  0x0eaeb04d in -[WOCompoundElement appendToResponse:inContext:] (
    self=0x7c073208, _cmd=0x2ea8e1f0, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOCompoundElement.m:247
#10 0x0eaeec70 in -[WOForm appendToResponse:inContext:] (self=0x80e73708,
    _cmd=0x2ea8d270, _response=0x8720ea88, _ctx=0x8af4cc08) at WOForm.m:407
#11 0x0eaeb04d in -[WOCompoundElement appendToResponse:inContext:] (
    self=0x7d779648, _cmd=0x20ed4980, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOCompoundElement.m:247
#12 0x00ee731d in -[OGoWindowFrame _appendContentToResponse:inContext:] (
    self=0x80e73788, _cmd=0x20ed4a58, _r=0x8720ea88, _ctx=0x8af4cc08)
    at OGoWindowFrame.m:325
#13 0x00ee7a20 in -[OGoWindowFrame appendToResponse:inContext:] (
    self=0x80e73788, _cmd=0x2ea8d270, _response=0x8720ea88, _ctx=0x8af4cc08)
    at OGoWindowFrame.m:419
#14 0x0eaeb04d in -[WOCompoundElement appendToResponse:inContext:] (
    self=0x7d779a48, _cmd=0x2ea8cb08, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOCompoundElement.m:247
#15 0x0eae96bf in -[WOComponentContent appendToResponse:inContext:] (
    self=0x82c03ee8, _cmd=0x2ea8d270, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOComponentContent.m:157
#16 0x0eaeb04d in -[WOCompoundElement appendToResponse:inContext:] (
---Type <return> to continue, or q <return> to quit---
    self=0x8899ba08, _cmd=0x2ea87ce8, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOCompoundElement.m:247
#17 0x0ead9c96 in -[WOTemplate appendToResponse:inContext:] 
(self=0x8a187c08,
    _cmd=0x2ea6d1c8, _response=0x8720ea88, _ctx=0x8af4cc08) at 
WOTemplate.m:128
#18 0x0ea72d53 in -[WOComponent appendToResponse:inContext:] 
(self=0x82ec7788,
    _cmd=0x253585c8, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOComponent.m:924
#19 0x0535a180 in -[OGoComponent appendToResponse:inContext:] (
    self=0x82ec7788, _cmd=0x20ed28b8, _r=0x8720ea88, _ctx=0x8af4cc08)
    at OGoComponent.m:132
#20 0x00ee0509 in -[LSWSkyrixFrame appendToResponse:inContext:] (
    self=0x82ec7788, _cmd=0x2ea77ba0, _r=0x8720ea88, _ctx=0x8af4cc08)
    at LSWSkyrixFrame.m:452
#21 0x0ea9cc2f in -[WOChildComponentReference appendToResponse:inContext:] (
    self=0x7d779a08, _cmd=0x2ea8d270, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOChildComponentReference.m:188
#22 0x0eaeb04d in -[WOCompoundElement appendToResponse:inContext:] (
    self=0x7d779ac8, _cmd=0x2ea87ce8, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOCompoundElement.m:247
#23 0x0ead9c96 in -[WOTemplate appendToResponse:inContext:] 
(self=0x81a86c48,
    _cmd=0x2ea6d1c8, _response=0x8720ea88, _ctx=0x8af4cc08) at 
WOTemplate.m:128
#24 0x0ea72d53 in -[WOComponent appendToResponse:inContext:] 
(self=0x7c073408,
    _cmd=0x253585c8, _response=0x8720ea88, _ctx=0x8af4cc08)
---Type <return> to continue, or q <return> to quit---
    at WOComponent.m:924
#25 0x0535a180 in -[OGoComponent appendToResponse:inContext:] (
    self=0x7c073408, _cmd=0x2ea72c30, _r=0x8720ea88, _ctx=0x8af4cc08)
    at OGoComponent.m:132
#26 0x0ea8988d in -[WOSession appendToResponse:inContext:] (self=0x82df4f08,
    _cmd=0x2535c710, _response=0x8720ea88, _ctx=0x8af4cc08) at 
WOSession.m:550
#27 0x05365c21 in -[OGoSession appendToResponse:inContext:] 
(self=0x82df4f08,
    _cmd=0x2ea6b8e0, _response=0x8720ea88, _ctx=0x8af4cc08) at 
OGoSession.m:478
#28 0x0ea6a385 in -[WOApplication appendToResponse:inContext:] (
    self=0x89e86208, _cmd=0x2ea7d988, _response=0x8720ea88, _ctx=0x8af4cc08)
    at WOApplication.m:928
#29 0x0eab4240 in -[WORequestHandler(Support) 
generateResponseForComponent:inContext:application:] (self=0x7e84f138, 
_cmd=0x2ea74fc8, _component=0x7c073408,
    _ctx=0x8af4cc08, _app=0x89e86208) at WORequestHandler.m:483
#30 0x0ea917ae in -[OWViewRequestHandler runTransactionWithContext:] (
    self=0x7e84f138, _cmd=0x2ea750d0, _ctx=0x8af4cc08)
    at OWViewRequestHandler.m:113
#31 0x0ea92283 in -[OWViewRequestHandler 
handleRequest:inContext:session:application:] (self=0x7e84f138, 
_cmd=0x2ea7d858, _request=0x816aa188,
    context=0x8af4cc08, session=0x82df4f08, app=0x89e86208)
    at OWViewRequestHandler.m:279
#32 0x0eab3408 in -[WORequestHandler handleRequest:] (self=0x7e84f138,
    _cmd=0x2ea6c578, _request=0x816aa188) at WORequestHandler.m:241
---Type <return> to continue, or q <return> to quit---
#33 0x0ea6e0cd in -[WOCoreApplication dispatchRequest:usingHandler:] (
    self=0x89e86208, _cmd=0x2ea6c5b0, _request=0x816aa188, 
handler=0x7e84f138)
    at WOCoreApplication.m:669
#34 0x0ea6e424 in -[WOCoreApplication dispatchRequest:] (self=0x89e86208,
    _cmd=0x3c0060a8, _request=0x816aa188) at WOCoreApplication.m:709
#35 0x1c006647 in -[OpenGroupware dispatchRequest:] (self=0x89e86208,
    _cmd=0x2ea9b7f0, _request=0x816aa188) at OpenGroupware.m:829
#36 0x0eb13c4d in -[WOHttpTransaction _run] (self=0x85547408, 
_cmd=0x2ea9b808)
    at WOHttpTransaction.m:540
#37 0x0eb1401e in -[WOHttpTransaction run] (self=0x85547408, 
_cmd=0x2ea9abb8)
    at WOHttpTransaction.m:593
#38 0x0eb0fc48 in -[WOHttpAdaptor runConnection:] (self=0x8b303b48,
    _cmd=0x2ea9ac08, _socket=0x86aa4c48) at WOHttpAdaptor.m:484
#39 0x0eb0fea7 in -[WOHttpAdaptor _handleAcceptedConnection:] (
    self=0x8b303b48, _cmd=0x2ea9ac60, _connection=0x86aa4c48)
    at WOHttpAdaptor.m:518
#40 0x0eb105e8 in -[WOHttpAdaptor acceptConnection:] (self=0x8b303b48,
    _cmd=0x2ea9ab70, _notification=0x7ed6cd88) at WOHttpAdaptor.m:626
#41 0x0b54ca7a in -[NSNotificationCenter _postAndRelease:] (self=0x7d63a738,
    _cmd=0x2b549168, notification=0x7ed6cd88) at NSNotificationCenter.m:1068
#42 0x0b54cd24 in -[NSNotificationCenter 
postNotificationName:object:userInfo:]
    (self=0x7d63a738, _cmd=0x2b549170, name=0x2acbb4c4, object=0x8b303c48,
    info=0x0) at NSNotificationCenter.m:1136
---Type <return> to continue, or q <return> to quit---
#43 0x0b54cbd4 in -[NSNotificationCenter postNotificationName:object:] (
    self=0x7d63a738, _cmd=0x2acbd988, name=0x2acbb4c4, object=0x8b303c48)
    at NSNotificationCenter.m:1116
#44 0x0acdb4b1 in -[NSObject(FileObjectWatcher) 
receivedEvent:type:extra:forMode:] (self=0x8b303c48, _cmd=0x2b5739a0, 
_fdData=0x8, _type=ET_RDESC, _extra=0x8,
    _mode=0x2b552db0) at NSRunLoop+FileObjects.m:57
#45 0x0b624b6c in -[GSRunLoopCtxt pollUntil:within:] (self=0x7e12a488,
    _cmd=0x2b552cb0, milliseconds=7933, contexts=0x7efd0188)
    at GSRunLoopCtxt.m:592
#46 0x0b58a363 in -[NSRunLoop acceptInputForMode:beforeDate:] (
    self=0x7efd0148, _cmd=0x2b552cd8, mode=0x2b552db0, 
limit_date=0x884a9a28)
    at NSRunLoop.m:969
#47 0x0b58a70e in -[NSRunLoop runMode:beforeDate:] (self=0x7efd0148,
    _cmd=0x2ea6c4e8, mode=0x2b552db0, date=0x7efd00e8) at NSRunLoop.m:1041
#48 0x0ea6d8d4 in -[WOCoreApplication run] (self=0x89e86208, 
_cmd=0x2ea77870)
    at WOCoreApplication.m:541
#49 0x0ea9beab in WOApplicationMain (_appClassName=0x3c005630, argc=3,
    argv=0xcfbcfb94) at WOApplicationMain.m:42
#50 0x0eabbcaf in WOWatchDogApplicationMain (appName=0x3c005630, argc=3,
    argv=0xcfbcfb94) at WOWatchDogApplicationMain.m:251
#51 0x1c001c88 in gnustep_base_user_main (argc=3, argv=0xcfbcfb94,
    env=0xcfbcfba4) at main.m:32
#52 0x0b57716b in main (argc=3, argv=0xcfbcfb94, env=0xcfbcfba4)
---Type <return> to continue, or q <return> to quit---
    at NSProcessInfo.m:897
#53 0x1c001b50 in ___start ()
#54 0x1c001abf in _start ()
#55 0x00000000 in ?? ()
(gdb) c
Continuing.
Jun 03 16:03:36 ogo-webui-1.1 [25547]: |ogo-webui-1.1| 
<OpenGroupware[0x0x89e86208]: name=ogo-webui-1.1>: caught:
  <NSException: 0x7e5b1028> NAME:NSInvalidArgumentException 
REASON:setNilValueForKey: -- SkyCollapsibleContent 0x82eceb88: Given nil 
value to set for key "visibility"
in context:
  <0x0x8af4cc08[WOContext]: 0094662c9c78af4cc08 app=ogo-webui-1.1 
sn=63CB63CB014662C98B eid=0094662c9c78af4cc08.0.17.1.1.47 
rqeid=0084662c9c187206808.0.17.1.11.1.5.1.1.6.3>.


From gnustep-port@opengroupware.org  Sun Jun  3 18:14:58 2007
From: gnustep-port@opengroupware.org (Helge Hess)
Date: Sun, 3 Jun 2007 19:14:58 +0200
Subject: [OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'
In-Reply-To: <20070603145106.E2B33404F7@l00-bugdead-prods.de>
References: <20070603145106.E2B33404F7@l00-bugdead-prods.de>
Message-ID: <4B3EFB22-DE64-4964-982D-87D8786CBE32@opengroupware.org>

On Jun 3, 2007, at 16:51, Sebastian Reitenbach wrote:
> I don't know why it was not working when using the original version  
> with
> visibility instead of visibilityDefault. I found the same on some  
> other
> places, and changed it there too. Don't know whether this is the  
> best idea,
> or a good one at all. But if it is, I could create a patch for  
> testing.

If the element does support 'visibilityDefault' I think its a pretty  
good idea.

However, the original issue is a GNUstep one.

Greets,
   Helge
-- 
Helge Hess
http://www.helgehess.eu/



From gnustep-port@opengroupware.org  Sun Jun  3 18:51:31 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Sun, 03 Jun 2007 19:51:31 +0200
Subject: [OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'
Message-ID: <20070603175131.E9C0E40694@l00-bugdead-prods.de>

------=_=-_OpenGroupware_org_NGMime-21476-1180893091.531730-0------
content-type: text/plain; charset="us-ascii"
content-transfer-encoding: 7bit
content-length: 655

Hi,

gnustep-port@opengroupware.org wrote: 
> On Jun 3, 2007, at 16:51, Sebastian Reitenbach wrote:
> > I don't know why it was not working when using the original version  
> > with
> > visibility instead of visibilityDefault. I found the same on some  
> > other
> > places, and changed it there too. Don't know whether this is the  
> > best idea,
> > or a good one at all. But if it is, I could create a patch for  
> > testing.
> 
> If the element does support 'visibilityDefault' I think its a pretty  
> good idea.
patch is appended. Not sure whether the changes are needed on all of the 
places where I made the changes.


kind regards
Sebastian


------=_=-_OpenGroupware_org_NGMime-21476-1180893091.531730-0------
content-disposition: inline; filename="patch.visibilityDefault"
content-length: 15013
content-transfer-encoding: 7bit
content-type: application/octet-stream; name="patch.visibilityDefault"

diff -ru opengroupware.org/WebUI/Templates/AddressUI/SkyPersonalAttributesViewer.wod /usr/local/share/opengroupware.org-1.1/templates/AddressUI/SkyPersonalAttributesViewer.wod
--- opengroupware.org/WebUI/Templates/AddressUI/SkyPersonalAttributesViewer.wod	Mon May 28 22:46:21 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/AddressUI/SkyPersonalAttributesViewer.wod	Sun Jun  3 16:18:23 2007
@@ -14,7 +14,7 @@
 }
 
 PatternTitle: SkyCollapsibleContent {
-  visibility     = patternVisibility;
+  visibilityDefault     = "patternVisibility";
   structuredMode = YES;
   title          = item;
 }
diff -ru opengroupware.org/WebUI/Templates/AdminUI/SkyDefaultsViewer.wod /usr/local/share/opengroupware.org-1.1/templates/AdminUI/SkyDefaultsViewer.wod
--- opengroupware.org/WebUI/Templates/AdminUI/SkyDefaultsViewer.wod	Mon May 28 22:46:18 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/AdminUI/SkyDefaultsViewer.wod	Sun Jun  3 16:17:56 2007
@@ -9,7 +9,7 @@
 }
 
 Collapsible: SkyCollapsibleContent {
-  visibility = isVisible;
+  visibilityDefault = "isVisible";
   title = currentDomain.name;
   structuredMode = YES;
 }
diff -ru opengroupware.org/WebUI/Templates/EnterprisesUI/SkyEnterpriseEditor.wod /usr/local/share/opengroupware.org-1.1/templates/EnterprisesUI/SkyEnterpriseEditor.wod
--- opengroupware.org/WebUI/Templates/EnterprisesUI/SkyEnterpriseEditor.wod	Mon May 28 22:46:24 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/EnterprisesUI/SkyEnterpriseEditor.wod	Sun Jun  3 16:17:25 2007
@@ -87,49 +87,49 @@
 }
 
 CommonCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.enterprise_editor_commonVisibility;
+  visibilityDefault       = "enterprise_editor_commonVisibility";
   submitActionName = "";
   title            = labels.commonAttributes; 
 }
 
 ExtendedCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.enterprise_editor_extendedVisibility;
+  visibilityDefault       = "enterprise_editor_extendedVisibility";
   submitActionName = "";
   title            = labels.extendedAttributes; 
 }
 
 CommentCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.enterprise_editor_commentVisibility;
+  visibilityDefault       = "enterprise_editor_commentVisibility";
   submitActionName = "";
   title            = labels.comment; 
 }
 
 ContactCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.enterprise_editor_contactVisibility;
+  visibilityDefault       = "enterprise_editor_contactVisibility";
   submitActionName = "";
   title            = labels.contact; 
 }
 
 CategoryCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.enterprise_editor_categoryVisibility;
+  visibilityDefault       = "enterprise_editor_categoryVisibility";
   submitActionName = "";
   title            = labels.categories; 
 }
 
 AddressCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.enterprise_editor_addressVisibility;
+  visibilityDefault       = "enterprise_editor_addressVisibility";
   submitActionName = "";
   title            = labels.addresses;
 }
 
 PrivateCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.enterprise_editor_privateVisibility;
+  visibilityDefault       = "enterprise_editor_privateVisibility";
   submitActionName = "";
   title            = labels.privateAttributes; 
 }
 
 TelephoneCollapsible: SkyCollapsibleContent {
-  visibility      = session.userDefaults.enterprise_editor_telephoneVisibility;
+  visibilityDefault      = "enterprise_editor_telephoneVisibility";
   submitActionName = "";
   title            = labels.telephones;
 }
diff -ru opengroupware.org/WebUI/Templates/JobUI/LSWJobEditor.wod /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobEditor.wod
--- opengroupware.org/WebUI/Templates/JobUI/LSWJobEditor.wod	Mon May 28 22:46:25 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobEditor.wod	Sun Jun  3 16:15:35 2007
@@ -186,7 +186,7 @@
 }
 
 AttributesCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.job_editor_attributesVisibility;
+  visibilityDefault       = "job_editor_attributesVisibility";
   submitActionName = "";
   title            = labels.attributes; 
 }
@@ -201,31 +201,31 @@
 }
 
 CommonCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.job_editor_commonVisibility;
+  visibilityDefault       = "job_editor_commonVisibility";
   submitActionName = "";
   title            = labels.commonAttributes; 
 }
 
 ExtendedCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.job_editor_extendedVisibility;
+  visibilityDefault       = "job_editor_extendedVisibility";
   submitActionName = "";
   title            = labels.extendedAttributes; 
 }
 
 ProjectCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.job_editor_projectVisibility;
+  visibilityDefault       = "job_editor_projectVisibility";
   submitActionName = "";
   title            = labels.projectAttributes; 
 }
 
 ExecutantCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.job_editor_executantVisibility;
+  visibilityDefault       = "job_editor_executantVisibility";
   submitActionName = "";
   title            = labels.executantAttributes; 
 }
 
 CommentCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.job_editor_commentVisibility;
+  visibilityDefault       = "job_editor_commentVisibility";
   submitActionName = "";
   title            = labels.commentAttributes; 
 }
@@ -313,7 +313,7 @@
 ShowPreferredAccounts: WOConditional { condition = preferredExecutantsEnabled;}
 
 PreferredAccountsTitle:  SkyCollapsibleContent {
-  visibility = session.userDefaults.job_editor_prefExecutantVisibility;
+  visibilityDefault = "job_editor_prefExecutantVisibility";
   title      = searchPreferredAccountsLabel;
   submitActionName = "";
   isClicked = isParticipantsClicked;
diff -ru opengroupware.org/WebUI/Templates/JobUI/LSWJobViewer.wod /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobViewer.wod
--- opengroupware.org/WebUI/Templates/JobUI/LSWJobViewer.wod	Mon May 28 22:46:25 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobViewer.wod	Sun Jun  3 16:13:47 2007
@@ -359,7 +359,7 @@
 
 CommentCollapsible: SkyCollapsibleContent {
   title      = labels.annotation;
-  visibility = session.userDefaults.jobui_history_expand_quickcreate;
+  visibilityDefault = "jobui_history_expand_quickcreate";
 }
 
 CommentQuickCreateForm: WOForm { action = quickCreateComment; }
diff -ru opengroupware.org/WebUI/Templates/LSWProject/LSWProjectEditor.wod /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectEditor.wod
--- opengroupware.org/WebUI/Templates/LSWProject/LSWProjectEditor.wod	Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectEditor.wod	Sun Jun  3 16:12:41 2007
@@ -385,17 +385,17 @@
   privateLabel = privateLabel;
 }
 ExtendedCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.project_editor_extendedVisibility;
+  visibilityDefault       = "project_editor_extendedVisibility";
   submitActionName = "";
   title            = labels.extended; 
 }
 CommonCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.project_editor_commonVisibility;
+  visibilityDefault       = "project_editor_commonVisibility";
   submitActionName = "";
   title            = labels.common; 
 }
 CommentCollapsible: SkyCollapsibleContent {
-  visibility       = session.userDefaults.project_editor_commentVisibility;
+  visibilityDefault       = "project_editor_commentVisibility";
   submitActionName = "";
   title            = labels.comment; 
 }
diff -ru opengroupware.org/WebUI/Templates/LSWProject/LSWProjectJobList.wod /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectJobList.wod
--- opengroupware.org/WebUI/Templates/LSWProject/LSWProjectJobList.wod	Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectJobList.wod	Sun Jun  3 16:11:25 2007
@@ -102,7 +102,7 @@
 }
 
 ReportCollapsible: SkyCollapsibleContent {
-  visibility = session.userDefaults.project_viewer_jobVisibility;
+  visibilityDefault = "project_viewer_jobVisibility";
   title      = labels.projectReportLabel;
   condition  = showProjectReport;
 }
diff -ru opengroupware.org/WebUI/Templates/LSWScheduler/LSWSchedulerPreferences.wod /usr/local/share/opengroupware.org-1.1/templates/LSWScheduler/LSWSchedulerPreferences.wod
--- opengroupware.org/WebUI/Templates/LSWScheduler/LSWSchedulerPreferences.wod	Mon May 28 22:46:25 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/LSWScheduler/LSWSchedulerPreferences.wod	Sun Jun  3 16:31:04 2007
@@ -13,20 +13,20 @@
 }
 
 EditorTitle: SkyCollapsibleContent {
-  visibility       = session.userDefaults.scheduler_pref_expand_editor;
+  visibilityDefault       = "scheduler_pref_expand_editor";
   submitActionName = "";
   title            = labels.EditorDefaults;
 }
 EditorLabel: WOString { value = labels.EditorDefaults; }
 
 AccessWindowTitle: SkyCollapsibleContent {
-  visibility       = session.userDefaults.scheduler_pref_expand_access;
+  visibilityDefault       = "scheduler_pref_expand_access";
   submitActionName = "";
   title            = labels.DefaultAccessPreferences;
 }
 
 OverviewTitle: SkyCollapsibleContent {
-  visibility       = session.userDefaults.scheduler_pref_expand_overview;
+  visibilityDefault       = "scheduler_pref_expand_overview";
   submitActionName = "";
   title            = labels.DefaultOverview;
 }
@@ -324,14 +324,14 @@
 }
 
 AccessTitle: SkyCollapsibleContent {
-  visibility = session.userDefaults.scheduler_pref_expand_access;
+  visibilityDefault = "scheduler_pref_expand_access";
   title      = labels.writeAccess;
 }
 
 // Day Overview
 
 DayOverviewTitle: SkyCollapsibleContent {
-  visibility = session.userDefaults.scheduler_pref_expand_dayOverview;
+  visibilityDefault = "scheduler_pref_expand_dayOverview";
   title      = labels.DayOverview;
 }
 DayOverviewLabel: WOString {
@@ -380,7 +380,7 @@
 // Holidays
 
 HolidaysTitle: SkyCollapsibleContent {
-  visibility = session.userDefaults.scheduler_pref_expand_holidays;
+  visibilityDefault = "scheduler_pref_expand_holidays";
   title      = labels.holidays;
 }
 
@@ -444,7 +444,7 @@
 
 // WeekOverview
 WeekOverviewTitle: SkyCollapsibleContent {
-  visibility = session.userDefaults.scheduler_pref_expand_weekOverview;
+  visibilityDefault = "scheduler_pref_expand_weekOverview";
   title      = labels.WeekOverview;
 }
 WeekOverviewLabel: WOString {
@@ -506,7 +506,7 @@
 }
 
 MailTemplateTitle: SkyCollapsibleContent {
-  visibility       = session.userDefaults.scheduler_pref_template_editor;
+  visibilityDefault       = "scheduler_pref_template_editor";
   submitActionName = "";
   title            = labels.TemplateDefault;
 }
diff -ru opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocTarInlineViewer.wod /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocTarInlineViewer.wod
--- opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocTarInlineViewer.wod	Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocTarInlineViewer.wod	Sun Jun  3 16:10:29 2007
@@ -5,7 +5,7 @@
 }
 
 TarCollaps: SkyCollapsibleContent {
-  visibility  = tarVisibility;
+  visibilityDefault  = "tarVisibility";
   openedLabel = "Tar Info";
   closedLabel = "Tar Info";
 }
diff -ru opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocZipInlineViewer.wod /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocZipInlineViewer.wod
--- opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocZipInlineViewer.wod	Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocZipInlineViewer.wod	Sun Jun  3 16:09:59 2007
@@ -5,7 +5,7 @@
 }
 
 ZipCollaps: SkyCollapsibleContent { 
-  visibility  = zipVisibility;
+  visibilityDefault  = "zipVisibility";
   title       = "Zip Info"; // TODO: localize
 }
 
diff -ru opengroupware.org/WebUI/Templates/OGoWebMail/LSWMailPreferences.wod /usr/local/share/opengroupware.org-1.1/templates/OGoWebMail/LSWMailPreferences.wod
--- opengroupware.org/WebUI/Templates/OGoWebMail/LSWMailPreferences.wod	Mon May 28 22:46:18 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/OGoWebMail/LSWMailPreferences.wod	Sun Jun  3 19:06:24 2007
@@ -34,57 +34,57 @@
 
 MDNTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_MDN;
+  visibilityDefault = "mail_pref_expand_MDN";
   title      = labels.DefaultsMDN;
   submitActionName = "";
 }
 
 MailListTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_mailList;
+  visibilityDefault = "mail_pref_expand_mailList";
   title      = labels.DefaultsMailList;
   submitActionName = "";
 }
 
 SearchMailListTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_searchMailList;
+  visibilityDefault = "mail_pref_expand_searchMailList";
   title      = labels.DefaultsSearchMailList;
   submitActionName = "";
 }
 GeneralDefaultsTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_generalDefaults;
+  visibilityDefault = "mail_pref_expand_generalDefaults";
   title      = labels.GeneralDefaults;
 }
 OnlyRootVisiblePreferences: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_onlyRooVisiblePreferences;
+  visibilityDefault = "mail_pref_expand_onlyRooVisiblePreferences";
   title      = labels.OnlyRootVisiblePreferences;
 }
 FromPopupValuesTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_fromPopupValues;
+  visibilityDefault = "mail_pref_expand_fromPopupValues";
   title      = labels.FromPopupValues;
 }
 GeneralMailListTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_generalMailList;
+  visibilityDefault = "mail_pref_expand_generalMailList";
   title      = labels.GeneralMailListDefaults;
 }
 SignatureTitle: SkyCollapsibleContent {
-  visibility = session.userDefaults.mail_pref_expand_signature;
+  visibilityDefault = "mail_pref_expand_signature";
   titleColspan = 4;
   title      = labels.signature;
 }
 SpecialFolderTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_specialFolder;
+  visibilityDefault = "mail_pref_expand_specialFolder";
   title      = labels.DefaultsSpecialFolder;
 }
 AccessTitle: SkyCollapsibleContent {
   titleColspan = 4;
-  visibility = session.userDefaults.mail_pref_expand_access;
+  visibilityDefault = "mail_pref_expand_access";
   title      = labels.DefaultAccessPreferences;
 }
 

------=_=-_OpenGroupware_org_NGMime-21476-1180893091.531730-0--------

From gnustep-port@opengroupware.org  Sun Jun  3 18:55:14 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Sun, 03 Jun 2007 19:55:14 +0200
Subject: [OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'
Message-ID: <20070603175514.66BA6406CE@l00-bugdead-prods.de>

Hi,

> If the element does support 'visibilityDefault' I think its a pretty  
> good idea.
from the SkyCollapsibleContent.m:

/*
   <> visibility           this or visibilityDefault is required
    > visibilityDefault
    > title                default = nil
    > condition            default = NO


Sebastian


From gnustep-port@opengroupware.org  Sun Jun  3 20:37:12 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Sun, 03 Jun 2007 21:37:12 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
Message-ID: <20070603193712.C076C405AA@l00-bugdead-prods.de>

Hi,

found another exception when trying to enter a project from a search result 
list, OGo stops with the following exception:

2007-06-03 21:26:09.939 ogo-webui-1.1[4495] ./Source/NSDictionary.m: [result 
class] GSMutableDictionary
2007-06-03 21:26:09.957 ogo-webui-1.1[4495] NGObjWeb/WOContext.m: 
valueForKey: _key WEDropContainerScriptDone
2007-06-03 21:26:09.957 ogo-webui-1.1[4495] NGObjWeb/NSObject+WO.m: 
WOGetKVCValueUsingMethod: object: <0x0x8630a008[WOContext]: 
006466315d18630a008 app=ogo-webui-1.1 sn=118F118F01466315C3 
eid=006466315d18630a008.0.9 rqeid=(nil)>, _key: WEDropContainerScriptDone
2007-06-03 21:26:09.957 ogo-webui-1.1[4495] NGObjWeb/WOContext.m: 
valueForKey: _key WEDragContainerScriptDone
2007-06-03 21:26:09.957 ogo-webui-1.1[4495] NGObjWeb/NSObject+WO.m: 
WOGetKVCValueUsingMethod: object: <0x0x8630a008[WOContext]: 
006466315d18630a008 app=ogo-webui-1.1 sn=118F118F01466315C3 
eid=006466315d18630a008.0.11 rqeid=(nil)>, _key: WEDragContainerScriptDone

Breakpoint 2, -[NSException raise] (self=0x83eb7288, _cmd=0x26caeef0) at 
NSException.m:782
782       if (GSPrivateEnvironmentFlag("GNUSTEP_STACK_TRACE", NO) == YES
(gdb) bt
#0  -[NSException raise] (self=0x83eb7288, _cmd=0x26caeef0) at 
NSException.m:782
#1  0x06cb1d17 in -[EOAdaptorChannel 
selectAttributes:describedByQualifier:fetchOrder:lock:] (self=0x8a255108, 
_cmd=0x285bf220,
    attributes=0x889a7d28, qualifier=0x889a7d48, fetchOrder=0x0, 
lockFlag=0 '\000') at EOAdaptorChannel.m:282
#2  0x085e24f3 in -[SkyProjectFileManagerCache 
_primaryFetchAccountLogin4PersonIdCache] (self=0x7c675188, _cmd=0x285bf250)
    at SkyProjectFileManagerCache.m:736
#3  0x085e2839 in -[SkyProjectFileManagerCache accountLogin4PersonId:] 
(self=0x7c675188, _cmd=0x285bb188, _personId=0x8a079218)
    at SkyProjectFileManagerCache.m:774
#4  0x085cc6af in +[SkyProjectFileManager(FileAttributes) 
buildFileAttrsForDoc:editing:atPath:isVersion:projectId:projectName:projectNumber:fileAttrContext:]

(self=0x285bc460, _cmd=0x285bb068, _doc=0x889a7808, _editing=0x0, _path=0x0, 
_isVersion=0 '\000', _projectId=0x88acdb58, _pName=0x0,
    _pNumber=0x0, _context=0x7c675188) at 
SkyProjectFileManager+FileAttributes.m:546
#5  0x085ca7b9 in +[SkyProjectFileManager(FileAttributes) 
buildFileAttrsForDoc:editing:atPath:isVersion:projectId:fileAttrContext:] (
    self=0x285bc460, _cmd=0x285be370, _doc=0x889a7808, _editing=0x0, 
_path=0x0, _isVersion=0 '\000', _projectId=0x88acdb58, _context=0x7c675188)
    at SkyProjectFileManager+FileAttributes.m:162
#6  0x085de244 in -[SkyProjectFileManagerCache(Internals) rootFolderAttrs] 
(self=0x7c675188, _cmd=0x285be410)
    at SkyProjectFileManagerCache+Internals.m:1260
#7  0x085de2ce in -[SkyProjectFileManagerCache(Internals) 
fileAttributesAtPathCache] (self=0x7c675188, _cmd=0x285bcd30)
    at SkyProjectFileManagerCache+Internals.m:1275
#8  0x085d5cbd in -[SkyProjectFileManagerCache(Caching) 
fileAttributesAtPath:manager:] (self=0x7c675188, _cmd=0x285bc6c0, 
_path=0x285b9890,
    _manager=0x7e804888) at SkyProjectFileManagerCache+Caching.m:112
#9  0x085ce3fc in -[SkyProjectFileManager 
fileAttributesAtPath:traverseLink:] (self=0x7e804888, _cmd=0x285bc670, 
_path=0x285b9890,
    _followLink=0 '\000') at SkyProjectFileManager.m:364
#10 0x085d4988 in -[SkyProjectFileManager fileSystemAttributesAtPath:] 
(self=0x7e804888, _cmd=0x2476b850, _path=0x285b9890)
    at SkyProjectFileManager.m:1520
#11 0x0478f126 in -[SkyProject4Viewer fileSystemAttributes] 
(self=0x801c3208, _cmd=0x2476b630) at SkyProject4Viewer.m:399
#12 0x0478db1a in -[SkyProject4Viewer label] (self=0x801c3208, 
_cmd=0x2545efa0) at SkyProject4Viewer.m:125
#13 0x036dd439 in GSObjCGetVal (self=0x801c3208, key=0xcfbbfc90 "label", 
sel=0x2545efa0, type=0x86adad30 "@8@0:4", size=5, offset=6)
    at GSObjCRuntime.m:1507
#14 0x03627699 in ValueForKey (self=0x801c3208, key=0xcfbbfc90 "label", 
size=5) at NSKeyValueCoding.m:178
#15 0x036297d5 in -[NSObject(KeyValueCoding) valueForKey:] (self=0x801c3208, 
_cmd=0x26652378, aKey=0x26652440) at NSKeyValueCoding.m:749
#16 0x066696dc in -[SkyNavigation itemLabel] (self=0x8630f988, 
_cmd=0x7c0a8080) at SkyNavigation.m:80
#17 0x026512bc in _getComponentValue (self=0x8b7f6c28, object=0x8630f988, 
info=0x8b7f6e60) at WOKeyPathAssociation.m:528
#18 0x0265152a in _getOneValue (self=0x8b7f6c28, root=0x8630f988) at 
WOKeyPathAssociation.m:723
#19 0x02651f3c in -[WOKeyPathAssociation valueInComponent:] 
(self=0x8b7f6c28, _cmd=0x2260b450, _component=0x8630f988) at 
WOKeyPathAssociation.m:945
#20 0x0264e993 in -[WOAssociation valueInContext:] (self=0x8b7f6c28, 
_cmd=0x2261af88, _ctx=0x8630a008) at WOAssociation.m:227
#21 0x02689d26 in -[_WOComplexString appendToResponse:inContext:] 
(self=0x7d0f9b08, _cmd=0x22614660, _response=0x8630b508, _ctx=0x8630a008)
    at WOString.m:566
---Type <return> to continue, or q <return> to quit---q
Quit
(gdb) c
Continuing.
Jun 03 21:26:40 ogo-webui-1.1 [4495]: |ogo-webui-1.1| 
<OpenGroupware[0x0x8737e288]: name=ogo-webui-1.1>: caught:
  <PostgreSQL72Exception: 0x83eb7288> NAME:PostgreSQL72FatalError 
REASON:fatal pgsql error (channel=<0x0x8a255108[PostgreSQL72Channel]: 
connection=<0x0x7ecb4628[PGConnection]:  connection=0x0x7e4d0800>>): ERROR:  
column "yes" does not exist
LINE 1: ...ompany_id, t1.login FROM  person t1 WHERE t1.is_person = YES
                                                                    ^

in context:
  <0x0x8630a008[WOContext]: 006466315d18630a008 app=ogo-webui-1.1 
sn=118F118F01466315C3 eid=006466315d18630a008.0.15.1.1.3.2.3.1 rqeid=(nil)>.
Jun 03 21:26:40 ogo-webui-1.1 [4495]: |ogo-webui-1.1| terminating session 
due to exception: 118F118F01466315C3
Jun 03 21:26:40 ogo-webui-1.1 [4495]: |ogo-webui-1.1| WOServerSessionStore: 
session 118F118F01466315C3 terminated.
Jun 03 21:26:40 ogo-webui-1.1 [4495]: [da-handler] application terminates 
because it refuses new sessions and the active session count (0) is below 
the minimum (1).
10.0.0.9 - - [03/Jun/2007:21:26:40 
GMT] "GET
/OpenGroupware.woa/x/activate?woinst=4495&oid=12620&wosid=118F118F01466315C3 
HTTP/1.1" 200 897/0 30.638 - - -
Jun 03 21:26:40 ogo-webui-1.1 [4495]: <0x0x87638c48[WOHttpAdaptor]> adaptor 
stops application: <OpenGroupware[0x0x8737e288]: name=ogo-webui-1.1 
terminating> ...

Program exited normally.


it should be: t1.is_person = 1 instead of: t1.is_person = YES 

Sebastian


From gnustep-port@opengroupware.org  Sun Jun  3 22:37:22 2007
From: gnustep-port@opengroupware.org (Helge Hess)
Date: Sun, 3 Jun 2007 23:37:22 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
In-Reply-To: <20070603193712.C076C405AA@l00-bugdead-prods.de>
References: <20070603193712.C076C405AA@l00-bugdead-prods.de>
Message-ID: <5DEFEFE3-23DB-4A4C-92E9-B724BB7695F0@opengroupware.org>

On Jun 3, 2007, at 21:37, Sebastian Reitenbach wrote:
>   <PostgreSQL72Exception: 0x83eb7288> NAME:PostgreSQL72FatalError
> REASON:fatal pgsql error (channel=<0x0x8a255108[PostgreSQL72Channel]:
> connection=<0x0x7ecb4628[PGConnection]:   
> connection=0x0x7e4d0800>>): ERROR:
> column "yes" does not exist
> LINE 1: ...ompany_id, t1.login FROM  person t1 WHERE t1.is_person =  
> YES
>                                                                     ^

Hm, OK. Thats probably the stringValue of a boolean NSNumber. Which  
probably is YES on GNUstep and 1 on libFoundation/Cocoa. Would need  
to check.

This is in NSNumber+PGVal.m:
---snip---
- (NSString *)stringValueForPostgreSQLType:(NSString *)_type
   attribute:(EOAttribute *)_attribute
{
   // TODO: can we avoid the lowercaseString?
   unsigned len;
   unichar  c1;

   if (debugOn)
     NSLog(@"%s(type=%@,attr=%@)", __PRETTY_FUNCTION__, _type,  
_attribute);

   if ((len = [_type length]) == 0) {
     if (debugOn) NSLog(@"  no type, return string");
     return [self stringValue];
   }
   if (len < 4) { /* apparently this is 'INT'? */
     if (debugOn) NSLog(@"  type len < 4 (%@), return string", _type);
#if GNUSTEP_BASE_LIBRARY
     /*
        on gstep-base -stringValue of bool's return YES or NO, which  
seems to
        be different on Cocoa and liBFoundation.
     */
     {
       Class BoolClass = Nil;

       if (BoolClass == Nil) BoolClass = NSClassFromString 
(@"NSBoolNumber");
       if ([self isKindOfClass:BoolClass])
	return [self boolValue] ? @"1" : @"0";
     }
#endif
     return [self stringValue];
   }
---snap---

Greets,
   Helge
-- 
Helge Hess
http://www.helgehess.eu/



From gnustep-port@opengroupware.org  Mon Jun  4 05:55:38 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Mon, 04 Jun 2007 06:55:38 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
Message-ID: <20070604045538.C4B464074B@l00-bugdead-prods.de>

Hi,

I added some lines for debugging:

  if (len < 4) { /* apparently this is 'INT'? */
    if (debugOn) NSLog(@"  type len < 4 (%@), return string", _type);
#if GNUSTEP_BASE_LIBRARY
    /*
       on gstep-base -stringValue of bool's return YES or NO, which seems to
       be different on Cocoa and liBFoundation.
    */

    {
      Class BoolClass = Nil;
NSLog(@"sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: here in 
GNUSTEP_BASE_LIBRARY!!! self class: %@", [self class]);
      if (BoolClass == Nil) BoolClass = NSClassFromString(@"NSBoolNumber");
      if ([self isKindOfClass:BoolClass])
        return [self boolValue] ? @"1" : @"0";
    }
#endif
NSLog(@"sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: not a  
GNUSTEP_BASE_LIBRARY!!!");
    return [self stringValue];
  }

This is the outcome:

2007-06-04 06:43:09.312 ogo-webui-1.1[1563] 
sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: here in GNUSTEP_BASE_LIBRARY!!! 
self class: NSIntNumber
2007-06-04 06:43:09.312 ogo-webui-1.1[1563] 
sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: not a  GNUSTEP_BASE_LIBRARY!!!


obviously       if ([self isKindOfClass:BoolClass])
        return [self boolValue] ? @"1" : @"0";

doesn't work.

kind regards
Sebastian


From gnustep-port@opengroupware.org  Mon Jun  4 17:54:19 2007
From: gnustep-port@opengroupware.org (Helge Hess)
Date: Mon, 4 Jun 2007 18:54:19 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
In-Reply-To: <20070604045538.C4B464074B@l00-bugdead-prods.de>
References: <20070604045538.C4B464074B@l00-bugdead-prods.de>
Message-ID: <F68DADA9-0360-4F9A-A028-C081EB10A9A6@opengroupware.org>

On Jun 4, 2007, at 06:55, Sebastian Reitenbach wrote:
> This is the outcome:
>
> 2007-06-04 06:43:09.312 ogo-webui-1.1[1563]
> sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: here in  
> GNUSTEP_BASE_LIBRARY!!!
> self class: NSIntNumber
> 2007-06-04 06:43:09.312 ogo-webui-1.1[1563]
> sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: not a   
> GNUSTEP_BASE_LIBRARY!!!
>
>
> obviously       if ([self isKindOfClass:BoolClass])
>         return [self boolValue] ? @"1" : @"0";
>
> doesn't work.

Hm, just checked, should be NSBoolNumber. I suppose your log is from  
a real int number.

Helge
-- 
Helge Hess
http://www.helgehess.eu/



From gnustep-port@opengroupware.org  Wed Jun  6 07:51:00 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Wed, 06 Jun 2007 08:51:00 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
Message-ID: <20070606065101.3E6BF4599A@l00-bugdead-prods.de>

Hi,

gnustep-port@opengroupware.org wrote: 
> On Jun 4, 2007, at 06:55, Sebastian Reitenbach wrote:
> > This is the outcome:
> >
> > 2007-06-04 06:43:09.312 ogo-webui-1.1[1563]
> > sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: here in  
> > GNUSTEP_BASE_LIBRARY!!!
> > self class: NSIntNumber
> > 2007-06-04 06:43:09.312 ogo-webui-1.1[1563]
> > sope/sope-gdl1/PostgreSQL/NSNumber+PGVal.m: not a   
> > GNUSTEP_BASE_LIBRARY!!!
> >
> >
> > obviously       if ([self isKindOfClass:BoolClass])
> >         return [self boolValue] ? @"1" : @"0";
> >
> > doesn't work.
> 
> Hm, just checked, should be NSBoolNumber. I suppose your log is from  
> a real int number.
> 

I had to make the following changes to make it work:

===================================================================
LSFetchTeamRelationCommand.m: unmodified: line 41
  qualifier = [[EOSQLQualifier alloc] initWithEntity:personEntity
                                   qualifierFormat:
                                     @"(%A = %@) AND (%A = %@)",
                                     
@"toProjectCompanyAssignment.projectId",
                                     key,
                                     
@"toProjectCompanyAssignment.hasAccess",
                                     [NSNumber numberWithInt:YES]];
===================================================================
./OGoDatabaseProject/SkyProjectFileManagerCache.m
    qualifier = [[EOSQLQualifier alloc] initWithEntity:entity
                                        qualifierFormat:@"%A = %i",
                                        @"isPerson", @"1",nil];
===================================================================
./SkyProjectFileManagerCache+Internals.m
  qualifier = [[EOSQLQualifier alloc] initWithEntity:entity
                                      qualifierFormat:@"%A = %@ AND %A 
= %@",
                                      @"projectId",
                                      [self->project 
valueForKey:@"projectId"],
                                      @"isFolder", @"1"];
===================================================================
./Logic/LSProject/LSFetchPersonRelationCommand.m
  qualifier = [[EOSQLQualifier alloc] initWithEntity:personEntity
                                   qualifierFormat:
                                     @"(%A = %@) AND (%A = %@)",
                                     
@"toProjectCompanyAssignment.projectId",
                                     key,
                                     
@"toProjectCompanyAssignment.hasAccess",
                                     [NSNumber numberWithInt:0]];
===================================================================
./Logic/LSProject/LSFetchAccountRelationCommand.m: unmodified: line 44
 personEntity = [[self databaseModel] entityNamed:@"Person"];
  qualifier = [[EOSQLQualifier alloc] initWithEntity:personEntity
                                   qualifierFormat:
                                     @"(%A = %@) AND (%A = %@)",
                                     
@"toProjectCompanyAssignment.projectId",
                                     key,
                                     
@"toProjectCompanyAssignment.hasAccess",
                                     [NSNumber numberWithInt:1]];

========================================================================
I had to change the [NSNumber numberWithBool:YES] to [NSNumber 
numberWithInt:1] or numberWithInt:YES to make it work.

Maybe It should be changed from [NSNumber numberWithBool:YES] to 
[NSBoolNumber numberWithBool:YES] and then check for Bool in 
NSNumber+PGVal.m

this at least works for me, with gnustep-base now, but dunno, whether this 
will break sth. with libFoundation or cocoa. Don't know whether there is a 
better place to make the changes. 

kind regards
Sebastian


From gnustep-port@opengroupware.org  Wed Jun  6 09:43:20 2007
From: gnustep-port@opengroupware.org (Helge Hess)
Date: Wed, 6 Jun 2007 10:43:20 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
In-Reply-To: <20070606065101.3E6BF4599A@l00-bugdead-prods.de>
References: <20070606065101.3E6BF4599A@l00-bugdead-prods.de>
Message-ID: <A0883CE3-5A7A-4C41-B250-938ED133686D@opengroupware.org>

On Jun 6, 2007, at 08:51, Sebastian Reitenbach wrote:
> I had to change the [NSNumber numberWithBool:YES] to [NSNumber
> numberWithInt:1] or numberWithInt:YES to make it work.

Thats wrong. We need to find the place where the NSBoolNumber is  
replaced with YES/NO. Maybe its in EOSQLQualifier.

Setting a breakpoint on NSBoolNumber -stringValue might help to find it.

> Maybe It should be changed from [NSNumber numberWithBool:YES] to
> [NSBoolNumber numberWithBool:YES] and then check for Bool in
> NSNumber+PGVal.m

NSNumber is a class cluster, you never access private subclasses  
directly. In fact
   [NSNumber numberWithBool:YES]

will call
   [NSBoolNumber numberWithBool:YES]

and give you back an NSBoolNumber (simplified, in the real world it  
gives you back a cached instance).

Greets,
   Helge
-- 
Helge Hess
http://www.helgehess.eu/



From gnustep-port@opengroupware.org  Fri Jun  8 20:14:26 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Fri, 08 Jun 2007 21:14:26 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
Message-ID: <20070608191426.B92B13746A@l00-bugdead-prods.de>

Hi,

gnustep-port@opengroupware.org wrote: 
> On Jun 6, 2007, at 08:51, Sebastian Reitenbach wrote:
> > I had to change the [NSNumber numberWithBool:YES] to [NSNumber
> > numberWithInt:1] or numberWithInt:YES to make it work.
> 
> Thats wrong. We need to find the place where the NSBoolNumber is  
> replaced with YES/NO. Maybe its in EOSQLQualifier.

+NSNumber numberWithBool: returns different things in libFoundation and 
gnustep-base.

what happens when you run this on apple:

#include <Foundation/Foundation.h>

int main (int argc, char **argv) {
        NSLog(@"numberWithInt: %@, numberWithBool: %@", [NSNumber 
numberWithInt:YES], [NSNumber numberWithBool:YES]);
        NSLog(@"numberWithInt: %@, numberWithBool: %@", [NSNumber 
numberWithInt:NO], [NSNumber numberWithBool:NO]);
        return 0;
}

produces this output, if compiled against gnustep-base:
2007-06-08 20:46:56.843 numbertest2[12538] numberWithInt: 1, numberWithBool: 
YES
2007-06-08 20:46:56.844 numbertest2[12538] numberWithInt: 0, numberWithBool: 
NO

and this, when compiled against libFoundation:
Jun 08 20:46:10 numbertest2 [13059]: numberWithInt: 1, numberWithBool: 1
Jun 08 20:46:10 numbertest2 [13059]: numberWithInt: 0, numberWithBool: 0

Sebastian


From gnustep-port@opengroupware.org  Fri Jun  8 23:21:04 2007
From: gnustep-port@opengroupware.org (Helge Hess)
Date: Sat, 9 Jun 2007 00:21:04 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
In-Reply-To: <20070608191426.B92B13746A@l00-bugdead-prods.de>
References: <20070608191426.B92B13746A@l00-bugdead-prods.de>
Message-ID: <B49F00C6-415F-44AE-82DB-731E3CA8E7FB@opengroupware.org>

On Jun 8, 2007, at 21:14, Sebastian Reitenbach wrote:
> gnustep-port@opengroupware.org wrote:
>> On Jun 6, 2007, at 08:51, Sebastian Reitenbach wrote:
>>> I had to change the [NSNumber numberWithBool:YES] to [NSNumber
>>> numberWithInt:1] or numberWithInt:YES to make it work.
>>
>> Thats wrong. We need to find the place where the NSBoolNumber is
>> replaced with YES/NO. Maybe its in EOSQLQualifier.
>
> +NSNumber numberWithBool: returns different things in libFoundation  
> and
> gnustep-base.
>
> what happens when you run this on apple:
>
> #include <Foundation/Foundation.h>
>
> int main (int argc, char **argv) {
>         NSLog(@"numberWithInt: %@, numberWithBool: %@", [NSNumber
> numberWithInt:YES], [NSNumber numberWithBool:YES]);
>         NSLog(@"numberWithInt: %@, numberWithBool: %@", [NSNumber
> numberWithInt:NO], [NSNumber numberWithBool:NO]);
>         return 0;
> }

helge@mbp$ ./testbool
2007-06-09 00:19:13.793 testbool[517] *** _NSAutoreleaseNoPool():  
Object 0x303140 of class NSCFNumber autoreleased with no pool in  
place - just leaking
2007-06-09 00:19:13.793 testbool[517] numberWithInt: 1,  
numberWithBool: 1
2007-06-09 00:19:13.793 testbool[517] *** _NSAutoreleaseNoPool():  
Object 0x304450 of class NSCFNumber autoreleased with no pool in  
place - just leaking
2007-06-09 00:19:13.793 testbool[517] numberWithInt: 0,  
numberWithBool: 0

So its consistent with libFoundation and GNUstep is different. But I  
wouldn't really consider returning YES as wrong. The question is why  
the SQL generator uses -description instead of processing the type of  
the number and doing the right thing in the specific context.

Greets,
   Helge
-- 
Helge Hess
http://www.helgehess.eu/



From gnustep-port@opengroupware.org  Sat Jun  9 07:25:58 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Sat, 09 Jun 2007 08:25:58 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
Message-ID: <20070609062558.EE3033AF44@l00-bugdead-prods.de>

Hi Helge,

> 
> So its consistent with libFoundation and GNUstep is different. But I  
> wouldn't really consider returning YES as wrong. The question is why  
> the SQL generator uses -description instead of processing the type of  
> the number and doing the right thing in the specific context.
> 
as I know now, both versions are correct, I think the best would be to add a 
check in EOSQLQualifier.m, in the 
- (id)initWithEntity:(EOEntity*)_entity
  qualifierFormat:(NSString *)qualifierFormat, ...
{
method.

Would it work to check all members of the va_list in that method whether it 
is kindOfClass:NSNumber, and if so, then replace it with a 0 or 1?
Don't know whether that would be a good idea, or would work at all...

kind regards
Sebastian


From gnustep-port@opengroupware.org  Sat Jun  9 21:32:30 2007
From: gnustep-port@opengroupware.org (Helge Hess)
Date: Sat, 9 Jun 2007 22:32:30 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
In-Reply-To: <20070609062558.EE3033AF44@l00-bugdead-prods.de>
References: <20070609062558.EE3033AF44@l00-bugdead-prods.de>
Message-ID: <BC098E76-D3F0-4146-985A-01B951638E28@opengroupware.org>

Hi,

I've committed a change. GDL calls -expressionValueInContext: to  
retrieve the textual SQL representation of an object. Per default  
(NSObject category) this calls either -stringValue or -description on  
the object.

I've added a gstep-base specific category which checks for NSBoolNumber.

Thanks,
   Helge

On Jun 9, 2007, at 08:25, Sebastian Reitenbach wrote:

> Hi Helge,
>
>>
>> So its consistent with libFoundation and GNUstep is different. But I
>> wouldn't really consider returning YES as wrong. The question is why
>> the SQL generator uses -description instead of processing the type of
>> the number and doing the right thing in the specific context.
>>
> as I know now, both versions are correct, I think the best would be  
> to add a
> check in EOSQLQualifier.m, in the
> - (id)initWithEntity:(EOEntity*)_entity
>   qualifierFormat:(NSString *)qualifierFormat, ...
> {
> method.
>
> Would it work to check all members of the va_list in that method  
> whether it
> is kindOfClass:NSNumber, and if so, then replace it with a 0 or 1?
> Don't know whether that would be a good idea, or would work at all...
>
> kind regards
> Sebastian
>
> -- 
> OpenGroupware.org GNUstep Port
> gnustep-port@opengroupware.org
> http://mail.opengroupware.org/mailman/listinfo/gnustep-port

-- 
Helge Hess
http://www.helgehess.eu/



From gnustep-port@opengroupware.org  Sun Jun 10 07:07:50 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Sun, 10 Jun 2007 08:07:50 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
Message-ID: <20070610060751.153983B684@l00-bugdead-prods.de>

Hi Helge,

> 
> I've committed a change. GDL calls -expressionValueInContext: to  
> retrieve the textual SQL representation of an object. Per default  
> (NSObject category) this calls either -stringValue or -description on  
> the object.
> 
> I've added a gstep-base specific category which checks for NSBoolNumber.

Thanks a lot, I'll test when the new nightly packages are built and 
available. 

Sebastian


From gnustep-port@opengroupware.org  Sun Jun 10 12:34:43 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Sun, 10 Jun 2007 13:34:43 +0200
Subject: [OGo-GNUstep-Port] postgresql adapter exception while entering a project
Message-ID: <20070610113444.084853B27B@l00-bugdead-prods.de>

Hi,

gnustep-port@opengroupware.org wrote: 
> Hi Helge,
> 
> > 
> > I've committed a change. GDL calls -expressionValueInContext: to  
> > retrieve the textual SQL representation of an object. Per default  
> > (NSObject category) this calls either -stringValue or -description on  
> > the object.
> > 
> > I've added a gstep-base specific category which checks for NSBoolNumber.
> 
> Thanks a lot, I'll test when the new nightly packages are built and 
> available. 
>
tested, and works well. Now it seems I only run into these fatal exceptions 
in 
-[NSKeyValueCoding setNilValueForKey:] 
and 
-[NSKeyValueCoding setValue: forUndefinedKey:]

can these exceptions be handled somewhere in sope or ogo?

not really gnustep-port related, but could you apply the patches to bugs 
1804 and 1805? would be good for the package creation to have not too much 
patch files to deal with.

Sebastian



From gnustep-port@opengroupware.org  Wed Jun 20 12:37:07 2007
From: gnustep-port@opengroupware.org (Helge Hess)
Date: Wed, 20 Jun 2007 13:37:07 +0200
Subject: [OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'
In-Reply-To: <20070603175131.E9C0E40694@l00-bugdead-prods.de>
References: <20070603175131.E9C0E40694@l00-bugdead-prods.de>
Message-ID: <C518C3C0-43C1-4F89-BA5C-26F44638B311@opengroupware.org>

On 03.06.2007, at 19:51, Sebastian Reitenbach wrote:
> patch is appended.

This patch is b0rked.

---snip---
  PatternTitle: SkyCollapsibleContent {
-  visibility     = patternVisibility;
+  visibilityDefault     = "patternVisibility";
---snap---

Thats non-sense. The visibilityDefault must contain the *name* of the  
default where the visibility is going to be stored. That is, you need  
to lookup the patternVisibility method in the code and check which  
default is being used.

Notably 'visibility' does not imply that a default is being used at  
all! (that is, you can't just replace all 'visibility' bindings with  
'visibilityDefault', but this should be rather obvious)


Eg this one is correct:
---snip---
-  visibility       =  
session.userDefaults.enterprise_editor_commonVisibility;
+  visibilityDefault       = "enterprise_editor_commonVisibility";
---snap---
'visibilityDefault' is a shortcut for 'session.userDefaults'.

Thanks,
   Helge


From gnustep-port@opengroupware.org  Wed Jun 20 14:08:28 2007
From: gnustep-port@opengroupware.org (Sebastian Reitenbach)
Date: Wed, 20 Jun 2007 15:08:28 +0200
Subject: [OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'
Message-ID: <20070620130828.D3B353F146@l00-bugdead-prods.de>

gnustep-port@opengroupware.org wrote: 
> On 03.06.2007, at 19:51, Sebastian Reitenbach wrote:
> > patch is appended.
> 
> This patch is b0rked.
> 
> ---snip---
>   PatternTitle: SkyCollapsibleContent {
> -  visibility     = patternVisibility;
> +  visibilityDefault     = "patternVisibility";
> ---snap---
> 
> Thats non-sense. The visibilityDefault must contain the *name* of the  
> default where the visibility is going to be stored. That is, you need  
> to lookup the patternVisibility method in the code and check which  
> default is being used.

I'll take a look.

Sebastian