[OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'
Sebastian Reitenbach
gnustep-port@opengroupware.org
Sun, 03 Jun 2007 19:51:31 +0200
------=_=-_OpenGroupware_org_NGMime-21476-1180893091.531730-0------
content-type: text/plain; charset="us-ascii"
content-transfer-encoding: 7bit
content-length: 655
Hi,
gnustep-port@opengroupware.org wrote:
> On Jun 3, 2007, at 16:51, Sebastian Reitenbach wrote:
> > I don't know why it was not working when using the original version
> > with
> > visibility instead of visibilityDefault. I found the same on some
> > other
> > places, and changed it there too. Don't know whether this is the
> > best idea,
> > or a good one at all. But if it is, I could create a patch for
> > testing.
>
> If the element does support 'visibilityDefault' I think its a pretty
> good idea.
patch is appended. Not sure whether the changes are needed on all of the
places where I made the changes.
kind regards
Sebastian
------=_=-_OpenGroupware_org_NGMime-21476-1180893091.531730-0------
content-disposition: inline; filename="patch.visibilityDefault"
content-length: 15013
content-transfer-encoding: 7bit
content-type: application/octet-stream; name="patch.visibilityDefault"
diff -ru opengroupware.org/WebUI/Templates/AddressUI/SkyPersonalAttributesViewer.wod /usr/local/share/opengroupware.org-1.1/templates/AddressUI/SkyPersonalAttributesViewer.wod
--- opengroupware.org/WebUI/Templates/AddressUI/SkyPersonalAttributesViewer.wod Mon May 28 22:46:21 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/AddressUI/SkyPersonalAttributesViewer.wod Sun Jun 3 16:18:23 2007
@@ -14,7 +14,7 @@
}
PatternTitle: SkyCollapsibleContent {
- visibility = patternVisibility;
+ visibilityDefault = "patternVisibility";
structuredMode = YES;
title = item;
}
diff -ru opengroupware.org/WebUI/Templates/AdminUI/SkyDefaultsViewer.wod /usr/local/share/opengroupware.org-1.1/templates/AdminUI/SkyDefaultsViewer.wod
--- opengroupware.org/WebUI/Templates/AdminUI/SkyDefaultsViewer.wod Mon May 28 22:46:18 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/AdminUI/SkyDefaultsViewer.wod Sun Jun 3 16:17:56 2007
@@ -9,7 +9,7 @@
}
Collapsible: SkyCollapsibleContent {
- visibility = isVisible;
+ visibilityDefault = "isVisible";
title = currentDomain.name;
structuredMode = YES;
}
diff -ru opengroupware.org/WebUI/Templates/EnterprisesUI/SkyEnterpriseEditor.wod /usr/local/share/opengroupware.org-1.1/templates/EnterprisesUI/SkyEnterpriseEditor.wod
--- opengroupware.org/WebUI/Templates/EnterprisesUI/SkyEnterpriseEditor.wod Mon May 28 22:46:24 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/EnterprisesUI/SkyEnterpriseEditor.wod Sun Jun 3 16:17:25 2007
@@ -87,49 +87,49 @@
}
CommonCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_commonVisibility;
+ visibilityDefault = "enterprise_editor_commonVisibility";
submitActionName = "";
title = labels.commonAttributes;
}
ExtendedCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_extendedVisibility;
+ visibilityDefault = "enterprise_editor_extendedVisibility";
submitActionName = "";
title = labels.extendedAttributes;
}
CommentCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_commentVisibility;
+ visibilityDefault = "enterprise_editor_commentVisibility";
submitActionName = "";
title = labels.comment;
}
ContactCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_contactVisibility;
+ visibilityDefault = "enterprise_editor_contactVisibility";
submitActionName = "";
title = labels.contact;
}
CategoryCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_categoryVisibility;
+ visibilityDefault = "enterprise_editor_categoryVisibility";
submitActionName = "";
title = labels.categories;
}
AddressCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_addressVisibility;
+ visibilityDefault = "enterprise_editor_addressVisibility";
submitActionName = "";
title = labels.addresses;
}
PrivateCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_privateVisibility;
+ visibilityDefault = "enterprise_editor_privateVisibility";
submitActionName = "";
title = labels.privateAttributes;
}
TelephoneCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.enterprise_editor_telephoneVisibility;
+ visibilityDefault = "enterprise_editor_telephoneVisibility";
submitActionName = "";
title = labels.telephones;
}
diff -ru opengroupware.org/WebUI/Templates/JobUI/LSWJobEditor.wod /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobEditor.wod
--- opengroupware.org/WebUI/Templates/JobUI/LSWJobEditor.wod Mon May 28 22:46:25 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobEditor.wod Sun Jun 3 16:15:35 2007
@@ -186,7 +186,7 @@
}
AttributesCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.job_editor_attributesVisibility;
+ visibilityDefault = "job_editor_attributesVisibility";
submitActionName = "";
title = labels.attributes;
}
@@ -201,31 +201,31 @@
}
CommonCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.job_editor_commonVisibility;
+ visibilityDefault = "job_editor_commonVisibility";
submitActionName = "";
title = labels.commonAttributes;
}
ExtendedCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.job_editor_extendedVisibility;
+ visibilityDefault = "job_editor_extendedVisibility";
submitActionName = "";
title = labels.extendedAttributes;
}
ProjectCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.job_editor_projectVisibility;
+ visibilityDefault = "job_editor_projectVisibility";
submitActionName = "";
title = labels.projectAttributes;
}
ExecutantCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.job_editor_executantVisibility;
+ visibilityDefault = "job_editor_executantVisibility";
submitActionName = "";
title = labels.executantAttributes;
}
CommentCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.job_editor_commentVisibility;
+ visibilityDefault = "job_editor_commentVisibility";
submitActionName = "";
title = labels.commentAttributes;
}
@@ -313,7 +313,7 @@
ShowPreferredAccounts: WOConditional { condition = preferredExecutantsEnabled;}
PreferredAccountsTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.job_editor_prefExecutantVisibility;
+ visibilityDefault = "job_editor_prefExecutantVisibility";
title = searchPreferredAccountsLabel;
submitActionName = "";
isClicked = isParticipantsClicked;
diff -ru opengroupware.org/WebUI/Templates/JobUI/LSWJobViewer.wod /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobViewer.wod
--- opengroupware.org/WebUI/Templates/JobUI/LSWJobViewer.wod Mon May 28 22:46:25 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/JobUI/LSWJobViewer.wod Sun Jun 3 16:13:47 2007
@@ -359,7 +359,7 @@
CommentCollapsible: SkyCollapsibleContent {
title = labels.annotation;
- visibility = session.userDefaults.jobui_history_expand_quickcreate;
+ visibilityDefault = "jobui_history_expand_quickcreate";
}
CommentQuickCreateForm: WOForm { action = quickCreateComment; }
diff -ru opengroupware.org/WebUI/Templates/LSWProject/LSWProjectEditor.wod /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectEditor.wod
--- opengroupware.org/WebUI/Templates/LSWProject/LSWProjectEditor.wod Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectEditor.wod Sun Jun 3 16:12:41 2007
@@ -385,17 +385,17 @@
privateLabel = privateLabel;
}
ExtendedCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.project_editor_extendedVisibility;
+ visibilityDefault = "project_editor_extendedVisibility";
submitActionName = "";
title = labels.extended;
}
CommonCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.project_editor_commonVisibility;
+ visibilityDefault = "project_editor_commonVisibility";
submitActionName = "";
title = labels.common;
}
CommentCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.project_editor_commentVisibility;
+ visibilityDefault = "project_editor_commentVisibility";
submitActionName = "";
title = labels.comment;
}
diff -ru opengroupware.org/WebUI/Templates/LSWProject/LSWProjectJobList.wod /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectJobList.wod
--- opengroupware.org/WebUI/Templates/LSWProject/LSWProjectJobList.wod Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/LSWProject/LSWProjectJobList.wod Sun Jun 3 16:11:25 2007
@@ -102,7 +102,7 @@
}
ReportCollapsible: SkyCollapsibleContent {
- visibility = session.userDefaults.project_viewer_jobVisibility;
+ visibilityDefault = "project_viewer_jobVisibility";
title = labels.projectReportLabel;
condition = showProjectReport;
}
diff -ru opengroupware.org/WebUI/Templates/LSWScheduler/LSWSchedulerPreferences.wod /usr/local/share/opengroupware.org-1.1/templates/LSWScheduler/LSWSchedulerPreferences.wod
--- opengroupware.org/WebUI/Templates/LSWScheduler/LSWSchedulerPreferences.wod Mon May 28 22:46:25 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/LSWScheduler/LSWSchedulerPreferences.wod Sun Jun 3 16:31:04 2007
@@ -13,20 +13,20 @@
}
EditorTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_expand_editor;
+ visibilityDefault = "scheduler_pref_expand_editor";
submitActionName = "";
title = labels.EditorDefaults;
}
EditorLabel: WOString { value = labels.EditorDefaults; }
AccessWindowTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_expand_access;
+ visibilityDefault = "scheduler_pref_expand_access";
submitActionName = "";
title = labels.DefaultAccessPreferences;
}
OverviewTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_expand_overview;
+ visibilityDefault = "scheduler_pref_expand_overview";
submitActionName = "";
title = labels.DefaultOverview;
}
@@ -324,14 +324,14 @@
}
AccessTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_expand_access;
+ visibilityDefault = "scheduler_pref_expand_access";
title = labels.writeAccess;
}
// Day Overview
DayOverviewTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_expand_dayOverview;
+ visibilityDefault = "scheduler_pref_expand_dayOverview";
title = labels.DayOverview;
}
DayOverviewLabel: WOString {
@@ -380,7 +380,7 @@
// Holidays
HolidaysTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_expand_holidays;
+ visibilityDefault = "scheduler_pref_expand_holidays";
title = labels.holidays;
}
@@ -444,7 +444,7 @@
// WeekOverview
WeekOverviewTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_expand_weekOverview;
+ visibilityDefault = "scheduler_pref_expand_weekOverview";
title = labels.WeekOverview;
}
WeekOverviewLabel: WOString {
@@ -506,7 +506,7 @@
}
MailTemplateTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.scheduler_pref_template_editor;
+ visibilityDefault = "scheduler_pref_template_editor";
submitActionName = "";
title = labels.TemplateDefault;
}
diff -ru opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocTarInlineViewer.wod /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocTarInlineViewer.wod
--- opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocTarInlineViewer.wod Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocTarInlineViewer.wod Sun Jun 3 16:10:29 2007
@@ -5,7 +5,7 @@
}
TarCollaps: SkyCollapsibleContent {
- visibility = tarVisibility;
+ visibilityDefault = "tarVisibility";
openedLabel = "Tar Info";
closedLabel = "Tar Info";
}
diff -ru opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocZipInlineViewer.wod /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocZipInlineViewer.wod
--- opengroupware.org/WebUI/Templates/OGoProjectZip/SkyDocZipInlineViewer.wod Mon May 28 22:46:19 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/OGoProjectZip/SkyDocZipInlineViewer.wod Sun Jun 3 16:09:59 2007
@@ -5,7 +5,7 @@
}
ZipCollaps: SkyCollapsibleContent {
- visibility = zipVisibility;
+ visibilityDefault = "zipVisibility";
title = "Zip Info"; // TODO: localize
}
diff -ru opengroupware.org/WebUI/Templates/OGoWebMail/LSWMailPreferences.wod /usr/local/share/opengroupware.org-1.1/templates/OGoWebMail/LSWMailPreferences.wod
--- opengroupware.org/WebUI/Templates/OGoWebMail/LSWMailPreferences.wod Mon May 28 22:46:18 2007
+++ /usr/local/share/opengroupware.org-1.1/templates/OGoWebMail/LSWMailPreferences.wod Sun Jun 3 19:06:24 2007
@@ -34,57 +34,57 @@
MDNTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_MDN;
+ visibilityDefault = "mail_pref_expand_MDN";
title = labels.DefaultsMDN;
submitActionName = "";
}
MailListTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_mailList;
+ visibilityDefault = "mail_pref_expand_mailList";
title = labels.DefaultsMailList;
submitActionName = "";
}
SearchMailListTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_searchMailList;
+ visibilityDefault = "mail_pref_expand_searchMailList";
title = labels.DefaultsSearchMailList;
submitActionName = "";
}
GeneralDefaultsTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_generalDefaults;
+ visibilityDefault = "mail_pref_expand_generalDefaults";
title = labels.GeneralDefaults;
}
OnlyRootVisiblePreferences: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_onlyRooVisiblePreferences;
+ visibilityDefault = "mail_pref_expand_onlyRooVisiblePreferences";
title = labels.OnlyRootVisiblePreferences;
}
FromPopupValuesTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_fromPopupValues;
+ visibilityDefault = "mail_pref_expand_fromPopupValues";
title = labels.FromPopupValues;
}
GeneralMailListTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_generalMailList;
+ visibilityDefault = "mail_pref_expand_generalMailList";
title = labels.GeneralMailListDefaults;
}
SignatureTitle: SkyCollapsibleContent {
- visibility = session.userDefaults.mail_pref_expand_signature;
+ visibilityDefault = "mail_pref_expand_signature";
titleColspan = 4;
title = labels.signature;
}
SpecialFolderTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_specialFolder;
+ visibilityDefault = "mail_pref_expand_specialFolder";
title = labels.DefaultsSpecialFolder;
}
AccessTitle: SkyCollapsibleContent {
titleColspan = 4;
- visibility = session.userDefaults.mail_pref_expand_access;
+ visibilityDefault = "mail_pref_expand_access";
title = labels.DefaultAccessPreferences;
}
------=_=-_OpenGroupware_org_NGMime-21476-1180893091.531730-0--------