[OGo-GNUstep-Port] SkyCollapsibleContent unable to set 'nil' for key: 'visibility'

[Helge Hess]

On 03.06.2007, at 19:51, Sebastian Reitenbach wrote:
> patch is appended.

This patch is b0rked.

---snip---
  PatternTitle: SkyCollapsibleContent {
-  visibility     = patternVisibility;
+  visibilityDefault     = "patternVisibility";
---snap---

Thats non-sense. The visibilityDefault must contain the *name* of the  
default where the visibility is going to be stored. That is, you need  
to lookup the patternVisibility method in the code and check which  
default is being used.

Notably 'visibility' does not imply that a default is being used at  
all! (that is, you can't just replace all 'visibility' bindings with  
'visibilityDefault', but this should be rather obvious)


Eg this one is correct:
---snip---
-  visibility       =  
session.userDefaults.enterprise_editor_commonVisibility;
+  visibilityDefault       = "enterprise_editor_commonVisibility";
---snap---
'visibilityDefault' is a shortcut for 'session.userDefaults'.

Thanks,
   Helge