[OGo-GNUstep-Port] compilation of zOGI with gnustep-base

[Sebastian Reitenbach]

------=_=-_OpenGroupware_org_NGMime-16970-1196185711.500635-0------
content-type: text/plain; charset="us-ascii"
content-transfer-encoding: 7bit
content-length: 833

gnustep-port@opengroupware.org wrote: 
> gnustep-port@opengroupware.org wrote: 
> > On 27.11.2007, at 17:19, Sebastian Reitenbach wrote:
> > > zOGIAction+Appointment.m:746: error: `NSShortInline8BitString'  
> > > undeclared
> > > (first use in this function)
> > 
> > 
> > The code does this:
> >        if (([value isKindOfClass:[NSString class]]) ||
> >            ([value isKindOfClass:[NSShortInline8BitString class]])) {
> > 
> > Which doesn't make any sense. First NSShortInline8BitString is a  
> > private class, and second its technically a subclass for NSString (so  
> > [value isKindOfClass:[NSString class]] already returns YES.
> ah, I see, I'll provide a patch that will remove/fix the problem.

appended two patches that will fix the compilation problem for me.
That useless check is removed tree times.

Sebastian


------=_=-_OpenGroupware_org_NGMime-16970-1196185711.500635-0------
content-disposition: inline; filename="patch-ZideStore_Protocols_zOGI_zOGIAction+Appointment.m"
content-length: 1063
content-transfer-encoding: 7bit
content-type: application/octet-stream; name="patch-ZideStore_Protocols_zOGI_zOGIAction+Appointment.m"

--- ZideStore/Protocols/zOGI/zOGIAction+Appointment.m	Tue Nov 27 11:05:50 2007
+++ ZideStore/Protocols/zOGI/zOGIAction+Appointment.m.new	Tue Nov 27 18:20:45 2007
@@ -742,8 +742,7 @@
       /* readAccessTeamObjectId -> accessTeamId 
          A blank string or a value of zero nulls the attribute. */
       tmp = nil;
-      if (([value isKindOfClass:[NSString class]]) ||
-          ([value isKindOfClass:[NSShortInline8BitString class]])) {
+      if ([value isKindOfClass:[NSString class]]) {
         if ([value length] == 0)
           tmp = intObj(0);
         else tmp = intObj([value intValue]);
@@ -756,8 +755,7 @@
          May be an array or a CSV string 
          TODO: Verify contained values */
         tmp = nil;
-        if (([value isKindOfClass:[NSString class]]) ||
-            ([value isKindOfClass:[NSShortInline8BitString class]])) {
+        if ([value isKindOfClass:[NSString class]]) {
           if (([tmp length] == 0) || ([tmp isEqualToString:@"0"]))
             tmp = [NSString stringWithString:@""];
           else tmp = value;

------=_=-_OpenGroupware_org_NGMime-16970-1196185711.500635-0------
content-disposition: inline; filename="patch-ZideStore_Protocols_zOGI_zOGIAction+Property.m"
content-length: 592
content-transfer-encoding: 7bit
content-type: application/octet-stream; name="patch-ZideStore_Protocols_zOGI_zOGIAction+Property.m"

--- ZideStore/Protocols/zOGI/zOGIAction+Property.m	Tue Nov 27 11:05:50 2007
+++ ZideStore/Protocols/zOGI/zOGIAction+Property.m.new	Tue Nov 27 18:37:43 2007
@@ -59,8 +59,7 @@
        @"objectProperty", @"entityName",
        _objectId, @"parentObjectId",
        nil]];
-  if (([_value class] == [NSShortInline8BitString class]) ||
-      ([_value class] == [NSString class])) {
+  if ([_value class] == [NSString class]) {
     [property setObject:@"string" forKey:@"valueType"];
    } else if ([_value isKindOfClass:[NSNumber class]]) {
     [property setObject:@"int" forKey:@"valueType"];

------=_=-_OpenGroupware_org_NGMime-16970-1196185711.500635-0--------