From sogo@opengroupware.org Mon Feb 6 17:32:22 2006 From: sogo@opengroupware.org (Helge Hess) Date: Mon, 6 Feb 2006 18:32:22 +0100 Subject: [SOGo] SOGo date handling Message-ID: Hi Francois, I just wanted to try agenor-head and noticed two things: a) you broke date formats in the client-side date validation of the apt-editor. It now only works with non-ISO dates. I think your change was unnecessary since the calendar object already does all the date parsing. Summary: http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1691 b) you don't add/explain your changes to/in the ChangeLog file. This is unacceptable. Can we expect a proper fix or should I just rollback all changes? Thanks a lot, Helge -- http://docs.opengroupware.org/Members/helge/ OpenGroupware.org From sogo@opengroupware.org Mon Feb 6 18:00:11 2006 From: sogo@opengroupware.org (Maxime Wacker) Date: Mon, 6 Feb 2006 19:00:11 +0100 Subject: [SOGo] SOGo date handling In-Reply-To: References: Message-ID: <03EA6BB5-4537-42E8-950A-119B577B28E6@linagora.com> Le 6 f=E9vr. 06 =E0 18:32, Helge Hess a =E9crit : > Hi Francois, > > I just wanted to try agenor-head and noticed two things: > > a) you broke date formats in the client-side date validation of > the apt-editor. It now only works with non-ISO dates. > I think your change was unnecessary since the calendar object > already does all the date parsing. > Summary: > http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=3D1691 > > b) you don't add/explain your changes to/in the ChangeLog file. This > is unacceptable. Isn't the commit comment unsufficient ? > > Can we expect a proper fix or should I just rollback all changes? > > Thanks a lot, Hi Helge, We thought this branch was our branch where we can do everything we =20 wanted (even the worse). Please explain what you want to do (merge ?) and how so we could =20 manage to work in manner acceptable for eachother. More generaly, we always had to work fast (and probably not so =20 cleverly) because the deadline was last September. Apologizes for this, but we're currently working on other things. =20 It'd be hard to find time to feet your wish even if we want to. > Helge > --=20 > http://docs.opengroupware.org/Members/helge/ > OpenGroupware.org > > --=20 > OpenGroupware.org SOGo > sogo@opengroupware.org > http://mail.opengroupware.org/mailman/listinfo/sogo > Maxime Wacker - Chef de projets mwacker@linagora.com T=E9l : 01-58-18-68-28 Fax : 01-58-18-68-29 From sogo@opengroupware.org Mon Feb 6 18:13:17 2006 From: sogo@opengroupware.org (Helge Hess) Date: Mon, 6 Feb 2006 19:13:17 +0100 Subject: [SOGo] SOGo date handling In-Reply-To: <03EA6BB5-4537-42E8-950A-119B577B28E6@linagora.com> References: <03EA6BB5-4537-42E8-950A-119B577B28E6@linagora.com> Message-ID: <91ad89795f98839c21bf085d809eeeaa@opengroupware.org> On Feb 6, 2006, at 19:00, Maxime Wacker wrote: > Isn't the commit comment unsufficient ? Correct ;-) The commit comment is not sufficient (or isn't unsufficient as you like to express it ;-). > We thought this branch was our branch where we can do everything we > wanted (even the worse). Well, as long as the project is hosted on the OGo website it has to play by the "OGo rules". And it certainly isn't "yours". However, sure, you can break stuff in the branch. Though I can't see the reason why this would be your intention :-) > Please explain what you want to do (merge ?) Not sure what you mean. I was indeed using the Agenor branch, especially for demonstrations. I wasn't aware that you intend to break it and make a French-only variant. > More generaly, we always had to work fast (and probably not so > cleverly) because the deadline was last September. Ok. > Apologizes for this, but we're currently working on other things. It'd > be hard to find time to feet your wish even if we want to. We'll see what we can do about it. Greets, Helge -- http://docs.opengroupware.org/Members/helge/ OpenGroupware.org