[OGo-Users] Re: click-to-dial & Asterisk

Sebastian Reitenbach users@opengroupware.org
Sun, 09 Dec 2007 22:23:06 +0100


users@opengroupware.org wrote: 
> After cleaning my source tree any re-applying the latest version of your
> CTI patch I get a compile failure.
> 
> 
awilliam@aleph:~/Works/OpenGroupware/opengroupware.org/WebUI/CTI/AsteriskDialer>

make
> Making all for bundle AsteriskDialer...
>  Creating AsteriskDialer.cti/....
>  Compiling file AsteriskDialer.m ...
> AsteriskDialer.m:61: warning: method possibly missing a [super dealloc]
> call
> AsteriskDialer.m: In function -[AsteriskDialer cleanupNumber:]:
> AsteriskDialer.m:105: warning: NSString may not respond to
> -isNotEmpty
> AsteriskDialer.m:105: warning: (Messages without a matching method
> signature
> AsteriskDialer.m:105: warning: will be assumed to return id and accept
> AsteriskDialer.m:105: warning: ... as arguments.)
>  Compiling file AsteriskConnection.m ...
>  Linking bundle AsteriskDialer ...
>  Creating AsteriskDialer.cti/Resources...
>  Creating AsteriskDialer.cti/Resources/Info-gnustep.plist...
>  Copying resources into the bundle wrapper...
> Making all for tool ogoasterisk...
>  Compiling file ogoasterisk.m ...
> ogoasterisk.m: In function -[Client run]:
> ogoasterisk.m:71: warning: NSString may not respond to -isNotEmpty
> ogoasterisk.m:71: warning: (Messages without a matching method signature
> ogoasterisk.m:71: warning: will be assumed to return id and accept
> ogoasterisk.m:71: warning: ... as arguments.)
>  Linking tool ogoasterisk ...
> /bin/sh: -c: line 1: syntax error: unexpected end of file
> make: *** [after-all] Error 2
hrm, this is the diff between the two patches:

--- patch.old   2007-12-09 22:18:25.000000000 +0100
+++ patch.new   2007-12-09 22:17:55.000000000 +0100
@@ -592,7 +592,7 @@
 diff -Nru opengroupware.org/WebUI/CTI/AsteriskDialer/GNUmakefile 
opengroupware.org/WebUI/CTI/AsteriskDialer.new/GNUmakefile
 --- opengroupware.org/WebUI/CTI/AsteriskDialer/GNUmakefile     Thu Jan  1 
01:00:00 1970
 +++ opengroupware.org/WebUI/CTI/AsteriskDialer.new/GNUmakefile Wed Apr  4 
19:30:19 2007
-@@ -0,0 +1,27 @@
+@@ -0,0 +1,31 @@
 +# $Id: GNUmakefile,v 1.1.1.1 2002/11/14 10:50:58 jan Exp $
 +
 +include $(GNUSTEP_MAKEFILES)/common.make
@@ -610,7 +610,12 @@
 +
 +TOOL_NAME             = ogoasterisk
 +ogoasterisk_OBJC_FILES = ogoasterisk.m AsteriskConnection.m
-+ogoasterisk_TOOL_LIBS  += -lNGStreams -liconv
++ogoasterisk_TOOL_LIBS  += -lNGStreams
++
++# OS dependend stuff
++ifeq ($(findstring openbsd, $(GNUSTEP_TARGET_OS)), openbsd)
++ogoasterisk_TOOL_LIBS += -liconv
++endif
 +
 +-include GNUmakefile.preamble
 +include $(GNUSTEP_MAKEFILES)/bundle.make

and it works well for me on OpenBSD, I've no idea yet, why this is new to 
you, need to investigate.

Sebastian