[OGo-Users] OGoAddressMapLink

Sebastian Reitenbach users@opengroupware.org
Sat, 15 Dec 2007 23:49:28 +0100


users@opengroupware.org wrote: 
> On 15.12.2007, at 23:19, Sebastian Reitenbach wrote:
> > I found it handy to have such a link next to an address, so maybe  
> > someone else too. feedback is welcome.
> 
> 
> Ah, thats cool! :-)
> 
> What I don't get is why the element takes a string. Shouldn't it take  
> an LSAddress object, check it and return the appropriate link?
Well, lots of room of improvments in here. I took a look where it would fit 
best, and saw that LSAddressViewer was able to return the addressString, so 
I took just that, quick and easy. 
the LSAddress object, would it just be sth. like that in the 
LSAddressViewer.wod file:
MapLink = OGoAddressMapLink {
  value = self;
};
or how would I get that object?

> The URL generation also looks a bit weird.
The URL generation is more or less taken from SkyDialNumber.

> 
> I've added a Java class I wrote a while ago to do something similiar.  
> Its attached. (this is done as Formatter object, but a dynamic element  
> is an even better thing).
need to take a look, thanks.

Sebastian
> 
> Greets,
>    Helge
> -- 
> Helge Hess
> http://www.helgehess.eu/
> 
>