[OGo-XML-RPC] zOGI and timeZone

Tobias Kaefer xmlrpc@opengroupware.org
Thu, 24 Apr 2008 07:33:42 +0200


Hi,

during my testing of the last patch I provided for sope (see
http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1964), I came
tried to fix one issue with timeZone(s) and recurrend "all day"
appointments. I recognized, that a timeZone that is given in a zOGI
"zogi.putObject"-command is not passed through the code. I did some
research and found that the times are converted by adding the time-delta
(timeZone to GMT) in zOGIAction.m, (NSCalendarDate
*)_makeCalendarDate:(id)_date withZone:(id)_zone
Line 441 to 448:
~    zoneDiff = [timeZone secondsFromGMTForDate:dateValue];
~    if (zoneDiff != 0)
~      dateValue = [dateValue dateByAddingYears:0
~                                        months:0
~                                          days:0
~                                         hours:0
~                                       minutes:0
~                                       seconds:(zoneDiff * -1)];

Wouldn't it be better to do it in a way like this: (??)
[dateValue setTimeZone:timeZone]


Greets
Tobias






-- 
Mit freundlichen Gruessen / with kind regards

Tobias S. Käfer

Tobias S. Kaefer * Portal-Development
ABAS Software AG, Suedendstrasse 42, 76135 Karlsruhe, GERMANY
Fon: +49 721 967 23 0, Fax: +49 721 967 23 100
Managing board / Vorstand: Werner Strub (CEO, Vorsitzender), Peter Walser
Chairman supervisory board / Aufsichtsratsvorsitzender: Thomas Frank
Company Register / Handelsregister: HRB 107644 Amtsgericht Mannheim
please visit our homepage / Bitte besuchen Sie unsere Homepage:
http://www.abas.de