[OGo-XML-RPC] zogi and daylight savings

[Tobias Kaefer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue Aug 25 2009 17:29:49 GMT+0200 (CEST) , Adam Tauno Williams wrote:
> On Mon, 2009-06-15 at 11:27 +0200, Tobias Kaefer wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote=
:
>>> <quote>
>>>   /* if we successfuly aquired a date then make an adjustment to
>>>      GMT if a timezone was provided;  GMT values are not changed. */
>>>   if ([dateValue isNotNull]) {
>>>     zoneDiff =3D [timeZone secondsFromGMTForDate:dateValue];
>>>     if (zoneDiff !=3D 0) {
>>>       dateValue =3D [dateValue dateByAddingYears:0
>>>                                         months:0
>>>                                           days:0
>>>                                          hours:0
>>>                                        minutes:0
>>>                                        seconds:(zoneDiff * -1)];
>>>   [dateValue setTimeZone:[NSTimeZone timeZoneWithAbbreviation:@"GMT"]=
];
>>>   return dateValue;
>>> </quote>
>> After knowing where to do some patching, the issue is very easy to
>> solve. I provided a patch for that (see
>> http://code.google.com/p/zogi/issues/detail?id=3D33#c5).
>> It's basically just this:
>> <quote>
>> dateValue =3D [NSCalendarDate dateWithYear:[dateValue yearOfCommonEra]
>>                                month:[dateValue monthOfYear]
>>                                day:[dateValue dayOfMonth]
>>                                hour:[dateValue hourOfDay]
>>                                minute:[dateValue minuteOfHour]
>>                                second:[dateValue secondOfMinute]
>>                                timeZone:timeZone];
>> </quote>
>=20
> How has this patch been working out for you? Any unforseen side effects=
?

No side effects so far. Everything is fine.

>> Maybe to much overhead, with createing a new NSCalendarDate-Object.
>=20
> It is OK with me;  groupware is massively read-oriented and this only
> effects the write path.
>=20




- --
Mit freundlichen Gruessen / with kind regards

Tobias S. K=E4fer

**********************************************************************
* Tobias S. Kaefer * Software-Developer * Diplom-Informatiker (BA)
* Tobias S. K=E4fer * Software-Entwickler * Diplom-Informatiker (BA)
* Portal-Development / Portal-Entwicklung
* ABAS Software AG  *  S=FCdendstra=DFe 42  *  76135 Karlsruhe  *  German=
y
* Phone:   +49(0)721-96723-0                 Fax:  +49(0)721-96723-100
* Webpage: http://www.abas.de
* Board of Directors / Vorstand: Werner Strub, Peter Walser
* Chairman Board of Directors / Vorstandsvorsitzender: Werner Strub
* Chairman Supervisory Board / Aufsichtsratsvorsitzender: Thomas Frank
* HRB 107644 Amtsgericht Mannheim
**********************************************************************
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqUrtcACgkQdJJ1JNEzpd1gBACfWxH56eDYzo8WNQ5Uyv+KxE1F
MUQAn0iNZCu98l3OVd/bY9r3AUKMrYl8
=3DC46t
-----END PGP SIGNATURE-----